From: Balbir Singh <bsingharora@gmail.com>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Scott Wood <oss@buserror.net>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/7] powerpc/mm: rename map_page() to map_kernel_page() on PPC32
Date: Tue, 30 May 2017 11:33:32 +1000 [thread overview]
Message-ID: <20170530113332.763d10ac@firefly.ozlabs.ibm.com> (raw)
In-Reply-To: <83aadb3163da87ec017ca4a61afcc29520a27eff.1496070452.git.christophe.leroy@c-s.fr>
On Mon, 29 May 2017 17:31:56 +0200 (CEST)
Christophe Leroy <christophe.leroy@c-s.fr> wrote:
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> ---
...
> diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c
> index de5a90e1ceaa..8e9bef964dbf 100644
> --- a/arch/powerpc/mm/mem.c
> +++ b/arch/powerpc/mm/mem.c
> @@ -305,11 +305,11 @@ void __init paging_init(void)
> unsigned long end = __fix_to_virt(FIX_HOLE);
>
> for (; v < end; v += PAGE_SIZE)
> - map_page(v, 0, 0); /* XXX gross */
> + map_kernel_page(v, 0, 0); /* XXX gross */
What is 0, 0? Everything maps to physical address 0 with 0 permissions?
Thanks for doing this
Acked-by: Balbir Singh <bsingharora@gmail.com>
Balbir
next prev parent reply other threads:[~2017-05-30 1:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-29 15:31 [PATCH 0/7] powerpc/mm: Fix kernel protection and implement STRICT_KERNEL_RWX on PPC32 Christophe Leroy
2017-05-29 15:31 ` [PATCH 1/7] powerpc/mm: rename map_page() to map_kernel_page() " Christophe Leroy
2017-05-30 1:33 ` Balbir Singh [this message]
2017-05-30 10:50 ` Michael Ellerman
2017-05-30 12:46 ` Christophe LEROY
2017-06-08 4:07 ` [1/7] " Michael Ellerman
2017-05-29 15:31 ` [PATCH 2/7] powerpc/mm: Ensure change_page_attr() doesn't invalidate pinned TLBs Christophe Leroy
2017-05-29 15:32 ` [PATCH 3/7] powerpc/mm: Fix kernel RAM protection after freeing unused memory on PPC32 Christophe Leroy
2017-05-30 1:51 ` Balbir Singh
2017-05-29 15:32 ` [PATCH 4/7] powerpc/mm: Implement STRICT_KERNEL_RWX " Christophe Leroy
2017-05-29 15:32 ` [PATCH 5/7] powerpc/mm: declare some local functions static Christophe Leroy
2017-05-29 15:32 ` [PATCH 6/7] powerpc/mm: remove __this_fixmap_does_not_exist() Christophe Leroy
2017-06-05 10:21 ` [6/7] " Michael Ellerman
2017-05-29 15:32 ` [PATCH 7/7] powerpc/mm: Simplify __set_fixmap() Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170530113332.763d10ac@firefly.ozlabs.ibm.com \
--to=bsingharora@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=oss@buserror.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).