From: Christophe LEROY <christophe.leroy@c-s.fr>
To: Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>, Scott Wood <oss@buserror.net>,
Balbir Singh <bsingharora@gmail.com>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/7] powerpc/mm: rename map_page() to map_kernel_page() on PPC32
Date: Tue, 30 May 2017 14:46:45 +0200 [thread overview]
Message-ID: <4ef6cdbc-9a35-537d-d0f4-2d7cbb67ed59@c-s.fr> (raw)
In-Reply-To: <8760gi62jw.fsf@concordia.ellerman.id.au>
Le 30/05/2017 à 12:50, Michael Ellerman a écrit :
> Christophe Leroy <christophe.leroy@c-s.fr> writes:
>
> ...
>
> Please tell me why.
Because of patch https://patchwork.ozlabs.org/patch/766777/ which
modifies patch_instruction() to use an alternative mapping.
Compilation fails on PPC32 because map_kernel_page() only exists on
PPC64. However we have map_page() which does the same on PPC32, hence
the renaming.
>
> You also moved the declaration from mmu_decl.h to book3s/32/pgtable.h,
> but didn't update any includes, presumably we're confident everything
> gets pgtable.h somehow?
Yes I did that so that lib/code_patching.c sees it.
All users of map_page() already include pgtable in a way or another.
Christophe
next prev parent reply other threads:[~2017-05-30 12:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-29 15:31 [PATCH 0/7] powerpc/mm: Fix kernel protection and implement STRICT_KERNEL_RWX on PPC32 Christophe Leroy
2017-05-29 15:31 ` [PATCH 1/7] powerpc/mm: rename map_page() to map_kernel_page() " Christophe Leroy
2017-05-30 1:33 ` Balbir Singh
2017-05-30 10:50 ` Michael Ellerman
2017-05-30 12:46 ` Christophe LEROY [this message]
2017-06-08 4:07 ` [1/7] " Michael Ellerman
2017-05-29 15:31 ` [PATCH 2/7] powerpc/mm: Ensure change_page_attr() doesn't invalidate pinned TLBs Christophe Leroy
2017-05-29 15:32 ` [PATCH 3/7] powerpc/mm: Fix kernel RAM protection after freeing unused memory on PPC32 Christophe Leroy
2017-05-30 1:51 ` Balbir Singh
2017-05-29 15:32 ` [PATCH 4/7] powerpc/mm: Implement STRICT_KERNEL_RWX " Christophe Leroy
2017-05-29 15:32 ` [PATCH 5/7] powerpc/mm: declare some local functions static Christophe Leroy
2017-05-29 15:32 ` [PATCH 6/7] powerpc/mm: remove __this_fixmap_does_not_exist() Christophe Leroy
2017-06-05 10:21 ` [6/7] " Michael Ellerman
2017-05-29 15:32 ` [PATCH 7/7] powerpc/mm: Simplify __set_fixmap() Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ef6cdbc-9a35-537d-d0f4-2d7cbb67ed59@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=benh@kernel.crashing.org \
--cc=bsingharora@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=oss@buserror.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).