From: Lee Jones <lee.jones@linaro.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: a.hajda@samsung.com, patches@opensource.cirrus.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] mfd: arizona: Fix typo using hard-coded register
Date: Tue, 6 Jun 2017 10:16:01 +0100 [thread overview]
Message-ID: <20170606091601.axffjmgzewciiuqq@dell> (raw)
In-Reply-To: <1496738793-12975-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>
On Tue, 06 Jun 2017, Charles Keepax wrote:
> A hardcoded register is accidentally used instead of the register
> address passed into the function. Correct this and use the appropriate
> variable. This would cause minor issues on wm5102, but all other
> devices using this driver would have been unaffected.
>
> Fixes: commit ef84f885e037 ("mfd: arizona: Refactor arizona_poll_reg")
> Reported-by: Andrzej Hajda <a.hajda@samsung.com>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> drivers/mfd/arizona-core.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index 75488e6..8d46e3a 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -245,8 +245,7 @@ static int arizona_poll_reg(struct arizona *arizona,
> int ret;
>
> ret = regmap_read_poll_timeout(arizona->regmap,
> - ARIZONA_INTERRUPT_RAW_STATUS_5, val,
> - ((val & mask) == target),
> + reg, val, ((val & mask) == target),
> ARIZONA_REG_POLL_DELAY_US,
> timeout_ms * 1000);
> if (ret)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2017-06-06 9:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 8:46 [PATCH RESEND] mfd: arizona: Fix typo using hard-coded register Charles Keepax
2017-06-06 9:16 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170606091601.axffjmgzewciiuqq@dell \
--to=lee.jones@linaro.org \
--cc=a.hajda@samsung.com \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).