* [PATCH RESEND] mfd: arizona: Fix typo using hard-coded register
@ 2017-06-06 8:46 Charles Keepax
2017-06-06 9:16 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Charles Keepax @ 2017-06-06 8:46 UTC (permalink / raw)
To: lee.jones; +Cc: a.hajda, patches, linux-kernel
A hardcoded register is accidentally used instead of the register
address passed into the function. Correct this and use the appropriate
variable. This would cause minor issues on wm5102, but all other
devices using this driver would have been unaffected.
Fixes: commit ef84f885e037 ("mfd: arizona: Refactor arizona_poll_reg")
Reported-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
drivers/mfd/arizona-core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
index 75488e6..8d46e3a 100644
--- a/drivers/mfd/arizona-core.c
+++ b/drivers/mfd/arizona-core.c
@@ -245,8 +245,7 @@ static int arizona_poll_reg(struct arizona *arizona,
int ret;
ret = regmap_read_poll_timeout(arizona->regmap,
- ARIZONA_INTERRUPT_RAW_STATUS_5, val,
- ((val & mask) == target),
+ reg, val, ((val & mask) == target),
ARIZONA_REG_POLL_DELAY_US,
timeout_ms * 1000);
if (ret)
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RESEND] mfd: arizona: Fix typo using hard-coded register
2017-06-06 8:46 [PATCH RESEND] mfd: arizona: Fix typo using hard-coded register Charles Keepax
@ 2017-06-06 9:16 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2017-06-06 9:16 UTC (permalink / raw)
To: Charles Keepax; +Cc: a.hajda, patches, linux-kernel
On Tue, 06 Jun 2017, Charles Keepax wrote:
> A hardcoded register is accidentally used instead of the register
> address passed into the function. Correct this and use the appropriate
> variable. This would cause minor issues on wm5102, but all other
> devices using this driver would have been unaffected.
>
> Fixes: commit ef84f885e037 ("mfd: arizona: Refactor arizona_poll_reg")
> Reported-by: Andrzej Hajda <a.hajda@samsung.com>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> drivers/mfd/arizona-core.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index 75488e6..8d46e3a 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -245,8 +245,7 @@ static int arizona_poll_reg(struct arizona *arizona,
> int ret;
>
> ret = regmap_read_poll_timeout(arizona->regmap,
> - ARIZONA_INTERRUPT_RAW_STATUS_5, val,
> - ((val & mask) == target),
> + reg, val, ((val & mask) == target),
> ARIZONA_REG_POLL_DELAY_US,
> timeout_ms * 1000);
> if (ret)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-06 9:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-06 8:46 [PATCH RESEND] mfd: arizona: Fix typo using hard-coded register Charles Keepax
2017-06-06 9:16 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).