* [PATCH] devfreq: exynos-ppmu: Staticize event list @ 2017-06-07 18:12 ` Krzysztof Kozlowski 2017-06-08 1:22 ` Chanwoo Choi [not found] ` <CGME20170607181258epcas2p4191204d7b3853ef0482d84df7a06589d@epcms1p7> 0 siblings, 2 replies; 3+ messages in thread From: Krzysztof Kozlowski @ 2017-06-07 18:12 UTC (permalink / raw) To: Chanwoo Choi, MyungJoo Ham, Kyungmin Park, Kukjin Kim, Krzysztof Kozlowski, linux-pm, linux-arm-kernel, linux-samsung-soc, linux-kernel The ppmu_events array is accessed only in this compilation unit so it can be made static. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/devfreq/event/exynos-ppmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c index 9b7350935b73..c68f3b5a10b5 100644 --- a/drivers/devfreq/event/exynos-ppmu.c +++ b/drivers/devfreq/event/exynos-ppmu.c @@ -44,7 +44,7 @@ struct exynos_ppmu { { "ppmu-event2-"#name, PPMU_PMNCNT2 }, \ { "ppmu-event3-"#name, PPMU_PMNCNT3 } -struct __exynos_ppmu_events { +static struct __exynos_ppmu_events { char *name; int id; } ppmu_events[] = { -- 2.9.3 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] devfreq: exynos-ppmu: Staticize event list 2017-06-07 18:12 ` [PATCH] devfreq: exynos-ppmu: Staticize event list Krzysztof Kozlowski @ 2017-06-08 1:22 ` Chanwoo Choi [not found] ` <CGME20170607181258epcas2p4191204d7b3853ef0482d84df7a06589d@epcms1p7> 1 sibling, 0 replies; 3+ messages in thread From: Chanwoo Choi @ 2017-06-08 1:22 UTC (permalink / raw) To: Krzysztof Kozlowski, MyungJoo Ham, Kyungmin Park, Kukjin Kim, linux-pm, linux-arm-kernel, linux-samsung-soc, linux-kernel Hi Krzysztof, On 2017년 06월 08일 03:12, Krzysztof Kozlowski wrote: > The ppmu_events array is accessed only in this compilation unit so it > can be made static. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > drivers/devfreq/event/exynos-ppmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c > index 9b7350935b73..c68f3b5a10b5 100644 > --- a/drivers/devfreq/event/exynos-ppmu.c > +++ b/drivers/devfreq/event/exynos-ppmu.c > @@ -44,7 +44,7 @@ struct exynos_ppmu { > { "ppmu-event2-"#name, PPMU_PMNCNT2 }, \ > { "ppmu-event3-"#name, PPMU_PMNCNT3 } > > -struct __exynos_ppmu_events { > +static struct __exynos_ppmu_events { > char *name; > int id; > } ppmu_events[] = { > Looks good to me. Acked-by: Chanwoo Choi <cw00.choi@samsung.com> -- Best Regards, Chanwoo Choi Samsung Electronics ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <CGME20170607181258epcas2p4191204d7b3853ef0482d84df7a06589d@epcms1p7>]
* RE: Re: [PATCH] devfreq: exynos-ppmu: Staticize event list [not found] ` <CGME20170607181258epcas2p4191204d7b3853ef0482d84df7a06589d@epcms1p7> @ 2017-06-09 0:28 ` MyungJoo Ham 0 siblings, 0 replies; 3+ messages in thread From: MyungJoo Ham @ 2017-06-09 0:28 UTC (permalink / raw) To: Chanwoo Choi, Krzysztof Kozlowski, Kyungmin Park, Kukjin Kim, linux-pm, linux-arm-kernel, linux-samsung-soc, linux-kernel > Hi Krzysztof, > > On 2017년 06월 08일 03:12, Krzysztof Kozlowski wrote: > > The ppmu_events array is accessed only in this compilation unit so it > > can be made static. > > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > --- > > drivers/devfreq/event/exynos-ppmu.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c > > index 9b7350935b73..c68f3b5a10b5 100644 > > --- a/drivers/devfreq/event/exynos-ppmu.c > > +++ b/drivers/devfreq/event/exynos-ppmu.c > > @@ -44,7 +44,7 @@ struct exynos_ppmu { > > { "ppmu-event2-"#name, PPMU_PMNCNT2 }, \ > > { "ppmu-event3-"#name, PPMU_PMNCNT3 } > > > > -struct __exynos_ppmu_events { > > +static struct __exynos_ppmu_events { > > char *name; > > int id; > > } ppmu_events[] = { > > > > Looks good to me. > Acked-by: Chanwoo Choi <cw00.choi@samsung.com> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com> Cheers, MyungJoo ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-09 0:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20170607181258epcas2p4191204d7b3853ef0482d84df7a06589d@epcas2p4.samsung.com>
2017-06-07 18:12 ` [PATCH] devfreq: exynos-ppmu: Staticize event list Krzysztof Kozlowski
2017-06-08 1:22 ` Chanwoo Choi
[not found] ` <CGME20170607181258epcas2p4191204d7b3853ef0482d84df7a06589d@epcms1p7>
2017-06-09 0:28 ` MyungJoo Ham
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).