From: Borislav Petkov <bp@alien8.de>
To: Colin King <colin.king@canonical.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/microcode/intel: make pointer intel_ucode_patch static
Date: Thu, 22 Jun 2017 11:05:13 +0200 [thread overview]
Message-ID: <20170622090513.juhp6tqhl2phap3g@pd.tnic> (raw)
In-Reply-To: <20170622084940.10286-1-colin.king@canonical.com>
On Thu, Jun 22, 2017 at 09:49:40AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer intel_ucode_patch does not need to be in global scope,
> so make it static.
>
> Cleans up sparse warning:
> "symbol 'intel_ucode_patch' was not declared. Should it be static?"
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> arch/x86/kernel/cpu/microcode/intel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/microcode/intel.c
> index d525a0bd7d28..59edbe9d4ccb 100644
> --- a/arch/x86/kernel/cpu/microcode/intel.c
> +++ b/arch/x86/kernel/cpu/microcode/intel.c
> @@ -42,7 +42,7 @@
> static const char ucode_path[] = "kernel/x86/microcode/GenuineIntel.bin";
>
> /* Current microcode patch used in early patching on the APs. */
> -struct microcode_intel *intel_ucode_patch;
> +static struct microcode_intel *intel_ucode_patch;
>
> static inline bool cpu_signatures_match(unsigned int s1, unsigned int p1,
> unsigned int s2, unsigned int p2)
> --
Acked-by: Borislav Petkov <bp@suse.de>
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
prev parent reply other threads:[~2017-06-22 9:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 8:49 [PATCH] x86/microcode/intel: make pointer intel_ucode_patch static Colin King
2017-06-22 9:05 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170622090513.juhp6tqhl2phap3g@pd.tnic \
--to=bp@alien8.de \
--cc=colin.king@canonical.com \
--cc=hpa@zytor.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).