* [PATCH] x86/microcode/intel: make pointer intel_ucode_patch static
@ 2017-06-22 8:49 Colin King
2017-06-22 9:05 ` Borislav Petkov
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-06-22 8:49 UTC (permalink / raw)
To: Borislav Petkov, Thomas Gleixner, Ingo Molnar, H . Peter Anvin, x86
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The pointer intel_ucode_patch does not need to be in global scope,
so make it static.
Cleans up sparse warning:
"symbol 'intel_ucode_patch' was not declared. Should it be static?"
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
arch/x86/kernel/cpu/microcode/intel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/microcode/intel.c
index d525a0bd7d28..59edbe9d4ccb 100644
--- a/arch/x86/kernel/cpu/microcode/intel.c
+++ b/arch/x86/kernel/cpu/microcode/intel.c
@@ -42,7 +42,7 @@
static const char ucode_path[] = "kernel/x86/microcode/GenuineIntel.bin";
/* Current microcode patch used in early patching on the APs. */
-struct microcode_intel *intel_ucode_patch;
+static struct microcode_intel *intel_ucode_patch;
static inline bool cpu_signatures_match(unsigned int s1, unsigned int p1,
unsigned int s2, unsigned int p2)
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] x86/microcode/intel: make pointer intel_ucode_patch static
2017-06-22 8:49 [PATCH] x86/microcode/intel: make pointer intel_ucode_patch static Colin King
@ 2017-06-22 9:05 ` Borislav Petkov
0 siblings, 0 replies; 2+ messages in thread
From: Borislav Petkov @ 2017-06-22 9:05 UTC (permalink / raw)
To: Colin King
Cc: Thomas Gleixner, Ingo Molnar, H . Peter Anvin, x86,
kernel-janitors, linux-kernel
On Thu, Jun 22, 2017 at 09:49:40AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer intel_ucode_patch does not need to be in global scope,
> so make it static.
>
> Cleans up sparse warning:
> "symbol 'intel_ucode_patch' was not declared. Should it be static?"
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> arch/x86/kernel/cpu/microcode/intel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/microcode/intel.c
> index d525a0bd7d28..59edbe9d4ccb 100644
> --- a/arch/x86/kernel/cpu/microcode/intel.c
> +++ b/arch/x86/kernel/cpu/microcode/intel.c
> @@ -42,7 +42,7 @@
> static const char ucode_path[] = "kernel/x86/microcode/GenuineIntel.bin";
>
> /* Current microcode patch used in early patching on the APs. */
> -struct microcode_intel *intel_ucode_patch;
> +static struct microcode_intel *intel_ucode_patch;
>
> static inline bool cpu_signatures_match(unsigned int s1, unsigned int p1,
> unsigned int s2, unsigned int p2)
> --
Acked-by: Borislav Petkov <bp@suse.de>
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-22 9:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-22 8:49 [PATCH] x86/microcode/intel: make pointer intel_ucode_patch static Colin King
2017-06-22 9:05 ` Borislav Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).