From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: Jakub Kicinski <jakub.kicinski@netronome.com>,
Ming Lei <ming.lei@redhat.com>,
yi1.li@linux.intel.com, takahiro.akashi@linaro.org,
nbroeking@me.com, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
mfuzzey@parkeon.com, ebiederm@xmission.com,
dmitry.torokhov@gmail.com, wagi@monom.org, dwmw2@infradead.org,
jewalt@lgsinnovations.com, rafal@milecki.pl,
arend.vanspriel@broadcom.com, rjw@rjwysocki.net,
atull@kernel.org, moritz.fischer@ettus.com, pmladek@suse.com,
johannes.berg@intel.com, emmanuel.grumbach@intel.com,
luciano.coelho@intel.com, luto@kernel.org,
torvalds@linux-foundation.org, keescook@chromium.org,
dhowells@redhat.com, pjones@redhat.com, hdegoede@redhat.com,
alan@linux.intel.com, tytso@mit.edu,
paul.gortmaker@windriver.com, mtosatti@redhat.com,
mawilcox@microsoft.com, stephen.boyd@linaro.org,
markivx@codeaurora.org, linux-kernel@vger.kernel.org,
Tom Gundersen <teg@jklm.no>,
oss-drivers@netronome.com
Subject: Re: [PATCH] firmware: wake all waiters
Date: Tue, 27 Jun 2017 01:41:07 +0200 [thread overview]
Message-ID: <20170626234107.GJ21846@wotan.suse.de> (raw)
In-Reply-To: <20170626212036.GE21846@wotan.suse.de>
On Mon, Jun 26, 2017 at 11:20:36PM +0200, Luis R. Rodriguez wrote:
> On Fri, Jun 23, 2017 at 04:37:02PM -0700, Jakub Kicinski wrote:
> There's a slew of bugs lurking here though!
>
> As noted the reported Intel driver issues still need other fixes, one was the
> fw_state_done() on the direct filesystem lookup mechanism [1], and that may be
> a regression since direct filesystem loading was added, and even secondary
> requests would seem to just wait forever (MAX_SCHEDULE_TIMEOUT); the combination
> of both fixes should fix your reported issue.
Actually fw_state_done() is already called on success on direct filesystem loading,
so that should be fine. The bug report proposed change only adds a fw_state_aborted()
in case of a failure on direct fs lookups. That in turn, needs consideration of the
fallback mechanism, ie, only in case of *real* final falure should fw_state_aborte()
be issued. Distros that have enabled the fallback mechanism (seems like andoid now)
have no other option but to wait for the fallback mechanism or timeout to complete.
Its one reason why the firmwared thing is a good thing to review which has the
best-effort mode and final-mode [0].
[0] https://github.com/teg/firmwared.git
Luis
next prev parent reply other threads:[~2017-06-26 23:41 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 23:37 [PATCH] firmware: wake all waiters Jakub Kicinski
2017-06-26 21:20 ` Luis R. Rodriguez
2017-06-26 21:23 ` [PATCH v2] firmware: fix batched requests - " Luis R. Rodriguez
2017-06-29 15:16 ` Greg KH
2017-06-29 15:17 ` Greg KH
2017-06-29 17:36 ` Luis R. Rodriguez
2017-06-26 23:41 ` Luis R. Rodriguez [this message]
2017-06-27 2:10 ` [PATCH] firmware: " Jakub Kicinski
2017-06-27 16:39 ` Luis R. Rodriguez
2017-06-27 21:25 ` Jakub Kicinski
2017-06-27 22:24 ` Luis R. Rodriguez
2017-06-27 22:39 ` Jakub Kicinski
2017-06-27 23:50 ` Luis R. Rodriguez
2017-06-28 7:06 ` [systemd-devel] " Lennart Poettering
2017-06-28 16:06 ` Luis R. Rodriguez
2017-06-28 16:21 ` Lennart Poettering
2017-06-28 17:57 ` Luis R. Rodriguez
2017-06-29 19:56 ` Daniel Wagner
2017-06-27 17:48 ` Bjorn Andersson
2017-06-27 18:03 ` Luis R. Rodriguez
2017-06-27 18:59 ` Bjorn Andersson
2017-06-27 19:08 ` Luis R. Rodriguez
2017-06-27 19:52 ` Bjorn Andersson
2017-06-27 20:24 ` Luis R. Rodriguez
2017-06-26 21:44 ` Linus Torvalds
2017-06-26 23:30 ` Luis R. Rodriguez
2017-06-26 23:43 ` Linus Torvalds
2017-06-27 0:15 ` Luis R. Rodriguez
2017-06-28 13:45 ` Davidlohr Bueso
2017-06-28 15:58 ` Luis R. Rodriguez
2017-06-28 19:03 ` Davidlohr Bueso
2017-06-29 19:08 ` Davidlohr Bueso
2017-06-29 19:48 ` Luis R. Rodriguez
2017-06-30 16:32 ` Davidlohr Bueso
2017-07-05 16:18 ` Peter Zijlstra
2017-07-05 16:33 ` Linus Torvalds
2017-07-12 18:45 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170626234107.GJ21846@wotan.suse.de \
--to=mcgrof@kernel.org \
--cc=alan@linux.intel.com \
--cc=arend.vanspriel@broadcom.com \
--cc=atull@kernel.org \
--cc=dhowells@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ebiederm@xmission.com \
--cc=emmanuel.grumbach@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=jakub.kicinski@netronome.com \
--cc=jewalt@lgsinnovations.com \
--cc=johannes.berg@intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=luto@kernel.org \
--cc=markivx@codeaurora.org \
--cc=mawilcox@microsoft.com \
--cc=mfuzzey@parkeon.com \
--cc=ming.lei@redhat.com \
--cc=moritz.fischer@ettus.com \
--cc=mtosatti@redhat.com \
--cc=nbroeking@me.com \
--cc=oss-drivers@netronome.com \
--cc=paul.gortmaker@windriver.com \
--cc=pjones@redhat.com \
--cc=pmladek@suse.com \
--cc=rafal@milecki.pl \
--cc=rjw@rjwysocki.net \
--cc=stephen.boyd@linaro.org \
--cc=takahiro.akashi@linaro.org \
--cc=teg@jklm.no \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=wagi@monom.org \
--cc=yi1.li@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).