Re: [PATCH] firmware: wake all waiters

From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Davidlohr Bueso <dave@stgolabs.net>,
	Matthew Wilcox <mawilcox@microsoft.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	DanielWagnerwagi@monom.org, Boqun Feng <boqun.feng@gmail.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	Ming Lei <ming.lei@redhat.com>, "Li, Yi" <yi1.li@linux.intel.com>,
	"AKASHI, Takahiro" <takahiro.akashi@linaro.org>,
	Jakub Kicinski <jakub.kicinski@netronome.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Petr Mladek <pmladek@suse.com>,
	Andrew Lutomirski <luto@kernel.org>,
	Kees Cook <keescook@chromium.org>,
	David Howells <dhowells@redhat.com>,
	Alan Cox <alan@linux.intel.com>, "Theodore Ts'o" <tytso@mit.edu>,
	oss-drivers@netronome.com
Subject: Re: [PATCH] firmware: wake all waiters
Date: Thu, 29 Jun 2017 12:48:43 -0700	[thread overview]
Message-ID: <CAB=NE6VSR2Q38xz8vCUNsgUAo770_5pDZy04yZ5LpOCvum0FUg@mail.gmail.com> (raw)
In-Reply-To: <20170629190854.GE3954@linux-80c1.suse>

On Thu, Jun 29, 2017 at 12:08 PM, Davidlohr Bueso <dave@stgolabs.net> wrote:
> On Tue, 27 Jun 2017, Luis R. Rodriguez wrote:
>>
>>  * As a side effect of this; the data structures are slimmer.
>>  *
>> - * One would recommend using this wait queue where possible.
>> + * NOTE: swait is for cases of extreme memory considerations and some
>> very
>> + * special realtime issues, where it saves a couple of bytes in
>> structures that
>> + * need close packing. As such its very special-use. Consider using
>> regular
>> + * waits queues from wait.h instead *first*.
>
>
> How about the following?

And do we want to make it even more *special-use* by wrapping it with
#ifndef MODULE as suggested by Matthew Wilcox ?

  Luis