From: Borislav Petkov <bp@alien8.de>
To: "Ghannam, Yazen" <Yazen.Ghannam@amd.com>
Cc: "Suthikulpanit, Suravee" <Suravee.Suthikulpanit@amd.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Duran, Leo" <leo.duran@amd.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket
Date: Tue, 27 Jun 2017 20:44:35 +0200 [thread overview]
Message-ID: <20170627184435.kf2dx4wvp2ojvupw@pd.tnic> (raw)
In-Reply-To: <DM5PR1201MB0140E8FBFD6C72F6EA540F15F8DC0@DM5PR1201MB0140.namprd12.prod.outlook.com>
On Tue, Jun 27, 2017 at 06:32:34PM +0000, Ghannam, Yazen wrote:
> > you want all those threads to belong to a single scheduling group.
> > Correct?
> >
> > Now that thing has a memory controller attached to it, correct?
> >
> > If so, why is this thing not a logical NUMA node, as described in SRAT/SLIT?
> >
> > If not, what does a NUMA node entail on Zen as described by SRAT/SLIT?
> > I.e., what is the difference between the two things? I.e., how many dies as
> > above are in a NUMA node?
> >
> > Now, SRAT should contain the assignment which core belongs to which node.
> > Why is that not sufficient?
> >
> > Ok, that should be enough questions for now. Let's start with them.
> >
>
> This group is a NUMA node. It is the "identity" NUMA node. Linux skips the
Please be more specific. Which group exactly? Which question above are
you answering?
> identity NUMA node when finding the NUMA levels. This is fine as long as the
> MC domain is equivalent to the identity NUMA node. However, this is not the
> case on Zen systems.
>
> We could patch the sched/topology.c to not skip the identity NUMA node.
> Though this will affect all systems not just AMD.
We can always add a X86_FEATURE flag but we need to agree on what you
guys are actually trying to change and why?
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2017-06-27 18:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 6:40 [PATCH 0/2] x86/CPU/AMD: Fix multi-die processor topology info Suravee Suthikulpanit
2017-06-27 6:40 ` [PATCH 1/2] x86/CPU/AMD: Present package as die instead of socket Suravee Suthikulpanit
2017-06-27 10:48 ` Borislav Petkov
2017-06-27 13:07 ` Suravee Suthikulpanit
2017-06-27 13:42 ` Borislav Petkov
2017-06-27 16:54 ` Suravee Suthikulpanit
2017-06-27 17:44 ` Borislav Petkov
2017-06-27 18:32 ` Ghannam, Yazen
2017-06-27 18:44 ` Borislav Petkov [this message]
2017-06-27 20:26 ` Suravee Suthikulpanit
2017-06-28 9:12 ` Borislav Petkov
2017-06-27 14:21 ` Thomas Gleixner
2017-06-27 14:54 ` Brice Goglin
2017-06-27 15:48 ` Duran, Leo
2017-06-27 16:11 ` Borislav Petkov
2017-06-27 16:23 ` Duran, Leo
2017-06-27 16:31 ` Borislav Petkov
2017-06-27 16:42 ` Duran, Leo
2017-06-27 16:45 ` Borislav Petkov
2017-06-27 17:04 ` Duran, Leo
2017-06-27 16:19 ` Thomas Gleixner
2017-06-27 16:34 ` Duran, Leo
2017-06-27 15:55 ` Suravee Suthikulpanit
2017-06-27 16:16 ` Borislav Petkov
2017-07-05 15:50 ` Peter Zijlstra
2017-06-27 6:40 ` [PATCH 2/2] x86/CPU/AMD: Use L3 Cache info from CPUID to determine LLC ID Suravee Suthikulpanit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170627184435.kf2dx4wvp2ojvupw@pd.tnic \
--to=bp@alien8.de \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=Yazen.Ghannam@amd.com \
--cc=leo.duran@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).