* [PATCH] Replace the literal function name "visorbus_create_instance" with the format specifier "%s" so it can be dynamically filled by the __func__ macro.
@ 2017-06-27 21:17 Quytelda Kahja
2017-06-28 2:33 ` Kershner, David A
0 siblings, 1 reply; 2+ messages in thread
From: Quytelda Kahja @ 2017-06-27 21:17 UTC (permalink / raw)
To: david.kershner, gregkh; +Cc: devel, linux-kernel, Quytelda Kahja
Signed-off-by: Quytelda Kahja <quytelda@tamalin.org>
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c
index 1c785dd19ddd..1c6dc3a3e64a 100644
--- a/drivers/staging/unisys/visorbus/visorbus_main.c
+++ b/drivers/staging/unisys/visorbus/visorbus_main.c
@@ -1030,7 +1030,7 @@ visorbus_create_instance(struct visor_device *dev)
err_debugfs_dir:
debugfs_remove_recursive(dev->debugfs_dir);
kfree(hdr_info);
- dev_err(&dev->device, "visorbus_create_instance failed: %d\n", err);
+ dev_err(&dev->device, "%s failed: %d\n", __func__, err);
return err;
}
--
2.13.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] Replace the literal function name "visorbus_create_instance" with the format specifier "%s" so it can be dynamically filled by the __func__ macro.
2017-06-27 21:17 [PATCH] Replace the literal function name "visorbus_create_instance" with the format specifier "%s" so it can be dynamically filled by the __func__ macro Quytelda Kahja
@ 2017-06-28 2:33 ` Kershner, David A
0 siblings, 0 replies; 2+ messages in thread
From: Kershner, David A @ 2017-06-28 2:33 UTC (permalink / raw)
To: Quytelda Kahja, gregkh; +Cc: devel, linux-kernel
> -----Original Message-----
> From: Quytelda Kahja [mailto:quytelda@tamalin.org]
> Sent: Tuesday, June 27, 2017 5:18 PM
> To: Kershner, David A <David.Kershner@unisys.com>;
> gregkh@linuxfoundation.org
> Cc: devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org; Quytelda
> Kahja <quytelda@tamalin.org>
> Subject: [PATCH] Replace the literal function name
> "visorbus_create_instance" with the format specifier "%s" so it can be
> dynamically filled by the __func__ macro.
I think the subject line got lost somehow, and should this have been a v2?
Subject line should start with staging: unisys: visorbus: preferably.
David Kershner
>
> Signed-off-by: Quytelda Kahja <quytelda@tamalin.org>
> ---
> drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
> b/drivers/staging/unisys/visorbus/visorbus_main.c
> index 1c785dd19ddd..1c6dc3a3e64a 100644
> --- a/drivers/staging/unisys/visorbus/visorbus_main.c
> +++ b/drivers/staging/unisys/visorbus/visorbus_main.c
> @@ -1030,7 +1030,7 @@ visorbus_create_instance(struct visor_device
> *dev)
> err_debugfs_dir:
> debugfs_remove_recursive(dev->debugfs_dir);
> kfree(hdr_info);
> - dev_err(&dev->device, "visorbus_create_instance failed: %d\n",
> err);
> + dev_err(&dev->device, "%s failed: %d\n", __func__, err);
> return err;
> }
>
> --
> 2.13.2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-28 2:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-27 21:17 [PATCH] Replace the literal function name "visorbus_create_instance" with the format specifier "%s" so it can be dynamically filled by the __func__ macro Quytelda Kahja
2017-06-28 2:33 ` Kershner, David A
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).