From: Johan Hovold <johan@kernel.org>
To: Anatolij Gustschin <agust@denx.de>
Cc: Lee Jones <lee.jones@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Alan Tull <atull@kernel.org>,
Moritz Fischer <moritz.fischer@ettus.com>,
linux-gpio@vger.kernel.org, linux-fpga@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
David Laight <David.Laight@aculab.com>
Subject: Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices
Date: Mon, 10 Jul 2017 14:52:10 +0200 [thread overview]
Message-ID: <20170710125210.GK29638@localhost> (raw)
In-Reply-To: <1499374158-12388-2-git-send-email-agust@denx.de>
On Thu, Jul 06, 2017 at 10:49:16PM +0200, Anatolij Gustschin wrote:
> Add USB part with common functions for USB-GPIO/I2C/SPI master
> adapters. These allow communication with chip's control, transmit
> and receive endpoints and will be used by various FT232H drivers.
> +static const struct mfd_cell ftdi_cells[] = {
> + { .name = "ftdi-cbus-gpio", },
> + { .name = "ftdi-mpsse-i2c", },
> + { .name = "ftdi-mpsse-spi", },
> + { .name = "ftdi-fifo-fpp-mgr", },
> +};
Correct me if I'm wrong, but aren't these modes really mutually
exclusive, possibly with exception of cbus-gpio (some pins are at least
available as GPIOs in MPSSE mode)? Then MFD is not is not the right fit
here either.
And as David Laight already pointed out, your ftdi-fifo-fpp-mgr driver
seems too application specific for a generic chip like this.
Johan
next prev parent reply other threads:[~2017-07-10 12:52 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 20:49 [PATCH 0/3] FPGA Manager support for FPP via FT232H FT245-FIFO Anatolij Gustschin
2017-07-06 20:49 ` [PATCH 1/3] mfd: Add support for FTDI FT232H devices Anatolij Gustschin
2017-07-07 7:48 ` Bjørn Mork
2017-07-07 9:53 ` Anatolij Gustschin
2017-07-10 12:34 ` Johan Hovold
2017-07-11 6:52 ` Anatolij Gustschin
2017-07-12 8:50 ` Johan Hovold
2017-07-12 9:11 ` Bjørn Mork
2017-07-19 13:29 ` Anatolij Gustschin
2017-07-19 13:39 ` David Laight
2017-07-19 15:03 ` Anatolij Gustschin
2017-07-13 16:32 ` Anatolij Gustschin
2017-07-10 12:52 ` Johan Hovold [this message]
2017-07-19 8:59 ` Johan Hovold
2017-07-19 12:59 ` Anatolij Gustschin
2017-07-25 11:52 ` Johan Hovold
2017-07-25 12:14 ` Anatolij Gustschin
2017-07-19 11:58 ` Anatolij Gustschin
2017-07-25 11:49 ` Johan Hovold
2017-07-25 12:34 ` Anatolij Gustschin
2017-07-06 20:49 ` [PATCH 2/3] gpio: Add FT232H CBUS GPIO driver Anatolij Gustschin
2017-08-01 6:49 ` Linus Walleij
2017-08-01 9:24 ` Johan Hovold
2017-08-07 9:24 ` Linus Walleij
2017-07-06 20:49 ` [PATCH 3/3] fpga manager: Add FT232H driver for Altera FPP Anatolij Gustschin
2017-07-07 9:34 ` David Laight
2017-08-02 11:36 ` [PATCH 0/3] FPGA Manager support for FPP via FT232H FT245-FIFO Eric Schwarz
2017-08-02 14:16 ` Alan Tull
2017-08-02 15:30 ` Eric Schwarz
2017-08-02 16:06 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170710125210.GK29638@localhost \
--to=johan@kernel.org \
--cc=David.Laight@aculab.com \
--cc=agust@denx.de \
--cc=atull@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=moritz.fischer@ettus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).