From: Linus Walleij <linus.walleij@linaro.org>
To: Anatolij Gustschin <agust@denx.de>
Cc: Lee Jones <lee.jones@linaro.org>, Alan Tull <atull@kernel.org>,
Moritz Fischer <moritz.fischer@ettus.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
linux-fpga@vger.kernel.org,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] gpio: Add FT232H CBUS GPIO driver
Date: Tue, 1 Aug 2017 08:49:02 +0200 [thread overview]
Message-ID: <CACRpkdb7jOtNscyJPJYXL+VmvwBtHmBH1hhwZ75rBquWpSUVMQ@mail.gmail.com> (raw)
In-Reply-To: <1499374158-12388-3-git-send-email-agust@denx.de>
On Thu, Jul 6, 2017 at 10:49 PM, Anatolij Gustschin <agust@denx.de> wrote:
> Add driver for CBUS pins on FT232H. The driver supports setting
> GPIO direction and getting/setting CBUS 0-3 pin value. The CBUS
> pins have to be enabled by configuring I/O mode in the FTDI EEPROM.
>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
(...)
> + select GPIO_GENERIC
You do not seem to be using this.
> +#include <linux/gpio.h>
This include should not be needed. If it is, something is wrong.
> +#include <linux/gpio/driver.h>
Drivers should only include this.
> +#include <linux/platform_device.h>
> +#include <linux/slab.h>
> +#include <linux/types.h>
> +#include <linux/usb.h>
Why is this needed if the device is abstracted behind an MFD interface?
> +#include <linux/mfd/ftdi/ftdi.h>
I.e. this?
Apart from these small things it looks like a solid and nice driver,
do you plan to merge this into MFD or should I merge it? Since it depends
on the Kconfig symbol I guess I can merge it orthogonally if I am sure
Lee will pick the MFD part.
Yours,
Linus Walleij
next prev parent reply other threads:[~2017-08-01 6:49 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 20:49 [PATCH 0/3] FPGA Manager support for FPP via FT232H FT245-FIFO Anatolij Gustschin
2017-07-06 20:49 ` [PATCH 1/3] mfd: Add support for FTDI FT232H devices Anatolij Gustschin
2017-07-07 7:48 ` Bjørn Mork
2017-07-07 9:53 ` Anatolij Gustschin
2017-07-10 12:34 ` Johan Hovold
2017-07-11 6:52 ` Anatolij Gustschin
2017-07-12 8:50 ` Johan Hovold
2017-07-12 9:11 ` Bjørn Mork
2017-07-19 13:29 ` Anatolij Gustschin
2017-07-19 13:39 ` David Laight
2017-07-19 15:03 ` Anatolij Gustschin
2017-07-13 16:32 ` Anatolij Gustschin
2017-07-10 12:52 ` Johan Hovold
2017-07-19 8:59 ` Johan Hovold
2017-07-19 12:59 ` Anatolij Gustschin
2017-07-25 11:52 ` Johan Hovold
2017-07-25 12:14 ` Anatolij Gustschin
2017-07-19 11:58 ` Anatolij Gustschin
2017-07-25 11:49 ` Johan Hovold
2017-07-25 12:34 ` Anatolij Gustschin
2017-07-06 20:49 ` [PATCH 2/3] gpio: Add FT232H CBUS GPIO driver Anatolij Gustschin
2017-08-01 6:49 ` Linus Walleij [this message]
2017-08-01 9:24 ` Johan Hovold
2017-08-07 9:24 ` Linus Walleij
2017-07-06 20:49 ` [PATCH 3/3] fpga manager: Add FT232H driver for Altera FPP Anatolij Gustschin
2017-07-07 9:34 ` David Laight
2017-08-02 11:36 ` [PATCH 0/3] FPGA Manager support for FPP via FT232H FT245-FIFO Eric Schwarz
2017-08-02 14:16 ` Alan Tull
2017-08-02 15:30 ` Eric Schwarz
2017-08-02 16:06 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdb7jOtNscyJPJYXL+VmvwBtHmBH1hhwZ75rBquWpSUVMQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=agust@denx.de \
--cc=atull@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=moritz.fischer@ettus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).