* [PATCH 0/2] i2c: move include files out of include/linux/i2c
@ 2017-05-21 20:37 Wolfram Sang
2017-05-21 20:37 ` [PATCH 1/2] i2c: mux: pca954x: move header file out of I2C realm Wolfram Sang
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Wolfram Sang @ 2017-05-21 20:37 UTC (permalink / raw)
To: linux-i2c; +Cc: Wolfram Sang, linux-kernel
It doesn't make sense to use include/linux/i2c for client drivers which may in
fact rather be hwmon or input or whatever devices. As a result, I want to
deprecate include/linux/i2c for good. This series moves the include files to a
better location, largely include/platform_data because that is what most of the
moved include files contain. Note that some files don't seem to have upstream
users in board code, so they maybe could even be removed? I didn't check for
that now, but I did it for one i2c master driver recently. So, it may be
possible.
And while i2c muxes might be a corner case, I still want to deprecate
include/linux/i2c for good ;)
No runtime testing because of no HW, but buildbot is happy with this series at
least. A branch can be found here:
git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/platform_data
Thanks and kind regards,
Wolfram
Wolfram Sang (2):
i2c: mux: pca954x: move header file out of I2C realm
i2c: mux: mlxcpld: move header file out of I2C realm
drivers/i2c/muxes/i2c-mux-mlxcpld.c | 2 +-
drivers/i2c/muxes/i2c-mux-pca9541.c | 2 +-
drivers/i2c/muxes/i2c-mux-pca954x.c | 2 +-
include/linux/{i2c => platform_data}/pca954x.h | 0
include/linux/{i2c => platform_data/x86}/mlxcpld.h | 0
5 files changed, 3 insertions(+), 3 deletions(-)
rename include/linux/{i2c => platform_data}/pca954x.h (100%)
rename include/linux/{i2c => platform_data/x86}/mlxcpld.h (100%)
--
2.11.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] i2c: mux: pca954x: move header file out of I2C realm
2017-05-21 20:37 [PATCH 0/2] i2c: move include files out of include/linux/i2c Wolfram Sang
@ 2017-05-21 20:37 ` Wolfram Sang
2017-05-21 20:37 ` [PATCH 2/2] i2c: mux: mlxcpld: " Wolfram Sang
2017-07-13 9:46 ` [PATCH 0/2] i2c: move include files out of include/linux/i2c Wolfram Sang
2 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2017-05-21 20:37 UTC (permalink / raw)
To: linux-i2c; +Cc: Wolfram Sang, Guenter Roeck, Peter Rosin, linux-kernel
include/linux/i2c is not for client devices. Move the header file to a
more appropriate location.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
drivers/i2c/muxes/i2c-mux-pca9541.c | 2 +-
drivers/i2c/muxes/i2c-mux-pca954x.c | 2 +-
include/linux/{i2c => platform_data}/pca954x.h | 0
3 files changed, 2 insertions(+), 2 deletions(-)
rename include/linux/{i2c => platform_data}/pca954x.h (100%)
diff --git a/drivers/i2c/muxes/i2c-mux-pca9541.c b/drivers/i2c/muxes/i2c-mux-pca9541.c
index 9e318c9516c767..e6da060af88d27 100644
--- a/drivers/i2c/muxes/i2c-mux-pca9541.c
+++ b/drivers/i2c/muxes/i2c-mux-pca9541.c
@@ -24,7 +24,7 @@
#include <linux/i2c.h>
#include <linux/i2c-mux.h>
-#include <linux/i2c/pca954x.h>
+#include <linux/platform_data/pca954x.h>
/*
* The PCA9541 is a bus master selector. It supports two I2C masters connected
diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c b/drivers/i2c/muxes/i2c-mux-pca954x.c
index f1751c290af67c..8de13d1ad223b2 100644
--- a/drivers/i2c/muxes/i2c-mux-pca954x.c
+++ b/drivers/i2c/muxes/i2c-mux-pca954x.c
@@ -39,7 +39,7 @@
#include <linux/gpio/consumer.h>
#include <linux/i2c.h>
#include <linux/i2c-mux.h>
-#include <linux/i2c/pca954x.h>
+#include <linux/platform_data/pca954x.h>
#include <linux/interrupt.h>
#include <linux/irq.h>
#include <linux/module.h>
diff --git a/include/linux/i2c/pca954x.h b/include/linux/platform_data/pca954x.h
similarity index 100%
rename from include/linux/i2c/pca954x.h
rename to include/linux/platform_data/pca954x.h
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] i2c: mux: mlxcpld: move header file out of I2C realm
2017-05-21 20:37 [PATCH 0/2] i2c: move include files out of include/linux/i2c Wolfram Sang
2017-05-21 20:37 ` [PATCH 1/2] i2c: mux: pca954x: move header file out of I2C realm Wolfram Sang
@ 2017-05-21 20:37 ` Wolfram Sang
2017-07-13 9:46 ` [PATCH 0/2] i2c: move include files out of include/linux/i2c Wolfram Sang
2 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2017-05-21 20:37 UTC (permalink / raw)
To: linux-i2c
Cc: Wolfram Sang, Vadim Pasternak, Michael Shych, Peter Rosin, linux-kernel
include/linux/i2c is not for client devices. Move the header file to a
more appropriate location.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
drivers/i2c/muxes/i2c-mux-mlxcpld.c | 2 +-
include/linux/{i2c => platform_data/x86}/mlxcpld.h | 0
2 files changed, 1 insertion(+), 1 deletion(-)
rename include/linux/{i2c => platform_data/x86}/mlxcpld.h (100%)
diff --git a/drivers/i2c/muxes/i2c-mux-mlxcpld.c b/drivers/i2c/muxes/i2c-mux-mlxcpld.c
index e53f2abd135070..63458b025ef904 100644
--- a/drivers/i2c/muxes/i2c-mux-mlxcpld.c
+++ b/drivers/i2c/muxes/i2c-mux-mlxcpld.c
@@ -40,7 +40,7 @@
#include <linux/module.h>
#include <linux/platform_device.h>
#include <linux/slab.h>
-#include <linux/i2c/mlxcpld.h>
+#include <linux/platform_data/x86/mlxcpld.h>
#define CPLD_MUX_MAX_NCHANS 8
diff --git a/include/linux/i2c/mlxcpld.h b/include/linux/platform_data/x86/mlxcpld.h
similarity index 100%
rename from include/linux/i2c/mlxcpld.h
rename to include/linux/platform_data/x86/mlxcpld.h
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] i2c: move include files out of include/linux/i2c
2017-05-21 20:37 [PATCH 0/2] i2c: move include files out of include/linux/i2c Wolfram Sang
2017-05-21 20:37 ` [PATCH 1/2] i2c: mux: pca954x: move header file out of I2C realm Wolfram Sang
2017-05-21 20:37 ` [PATCH 2/2] i2c: mux: mlxcpld: " Wolfram Sang
@ 2017-07-13 9:46 ` Wolfram Sang
2017-07-14 5:10 ` Peter Rosin
2 siblings, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2017-07-13 9:46 UTC (permalink / raw)
To: linux-i2c; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1211 bytes --]
Hi peda,
On Sun, May 21, 2017 at 10:37:41PM +0200, Wolfram Sang wrote:
> It doesn't make sense to use include/linux/i2c for client drivers which may in
> fact rather be hwmon or input or whatever devices. As a result, I want to
> deprecate include/linux/i2c for good. This series moves the include files to a
> better location, largely include/platform_data because that is what most of the
> moved include files contain. Note that some files don't seem to have upstream
> users in board code, so they maybe could even be removed? I didn't check for
> that now, but I did it for one i2c master driver recently. So, it may be
> possible.
>
> And while i2c muxes might be a corner case, I still want to deprecate
> include/linux/i2c for good ;)
>
> No runtime testing because of no HW, but buildbot is happy with this series at
> least. A branch can be found here:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/platform_data
Since there were no other i2c-mux patches this merge window and thus no
pull request, do you mind if I pick these two patches for my second pull
request this merge window to have them included in 4.13 already?
Regards,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] i2c: move include files out of include/linux/i2c
2017-07-13 9:46 ` [PATCH 0/2] i2c: move include files out of include/linux/i2c Wolfram Sang
@ 2017-07-14 5:10 ` Peter Rosin
2017-07-14 7:58 ` Wolfram Sang
0 siblings, 1 reply; 6+ messages in thread
From: Peter Rosin @ 2017-07-14 5:10 UTC (permalink / raw)
To: Wolfram Sang, linux-i2c; +Cc: linux-kernel
On 2017-07-13 11:46, Wolfram Sang wrote:
> Hi peda,
>
> On Sun, May 21, 2017 at 10:37:41PM +0200, Wolfram Sang wrote:
>> It doesn't make sense to use include/linux/i2c for client drivers which may in
>> fact rather be hwmon or input or whatever devices. As a result, I want to
>> deprecate include/linux/i2c for good. This series moves the include files to a
>> better location, largely include/platform_data because that is what most of the
>> moved include files contain. Note that some files don't seem to have upstream
>> users in board code, so they maybe could even be removed? I didn't check for
>> that now, but I did it for one i2c master driver recently. So, it may be
>> possible.
>>
>> And while i2c muxes might be a corner case, I still want to deprecate
>> include/linux/i2c for good ;)
>>
>> No runtime testing because of no HW, but buildbot is happy with this series at
>> least. A branch can be found here:
>>
>> git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/platform_data
>
> Since there were no other i2c-mux patches this merge window and thus no
> pull request, do you mind if I pick these two patches for my second pull
> request this merge window to have them included in 4.13 already?
I don't seem to have this series in my inbox and not in my i2c folder either?
(and I don't remember having seen the patches, but this was a while ago so I
could easily have forgotten everything about it)
Anyway, I had to lookup the branch to see what this was about. And in that
branch, I find b7f1e84715a1 ("i2c: pca954x: move header file out of I2C realm"),
but I initially didn't find the mlxcpld patch. That was because it had an
"x86: " prefix that I didn't react to. I first found the mlxcpld patch in
patchwork and then I found it in the branch too, but in patchwork it has the
expected "i2c: mux: " prefix so I'm not sure what you are talking about
*exactly*.
But I'm sure you'll do something sensible, just go ahead.
Cheers,
Peter
PS. Please Cc me if you want a faster reaction, I didn't notice this
yesterday.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] i2c: move include files out of include/linux/i2c
2017-07-14 5:10 ` Peter Rosin
@ 2017-07-14 7:58 ` Wolfram Sang
0 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2017-07-14 7:58 UTC (permalink / raw)
To: Peter Rosin; +Cc: linux-i2c, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 829 bytes --]
Hi peda,
> I don't seem to have this series in my inbox and not in my i2c folder either?
You have been CCed on the patches, but not on the cover-letter. Sorry
about that.
> patchwork and then I found it in the branch too, but in patchwork it has the
> expected "i2c: mux: " prefix so I'm not sure what you are talking about
> *exactly*.
Hmm, looks like I forgot to push out the updated branch. Sorry again.
But it is the same patch which originally got an imperfect prefix from
my automated script.
> But I'm sure you'll do something sensible, just go ahead.
I hope so :) Thanks!
> PS. Please Cc me if you want a faster reaction, I didn't notice this
> yesterday.
Yup, same issue as above. I was wrong in that I assumed you have been on
CC for the cover-letter as well. I should have checked again.
Thanks,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-07-14 7:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-21 20:37 [PATCH 0/2] i2c: move include files out of include/linux/i2c Wolfram Sang
2017-05-21 20:37 ` [PATCH 1/2] i2c: mux: pca954x: move header file out of I2C realm Wolfram Sang
2017-05-21 20:37 ` [PATCH 2/2] i2c: mux: mlxcpld: " Wolfram Sang
2017-07-13 9:46 ` [PATCH 0/2] i2c: move include files out of include/linux/i2c Wolfram Sang
2017-07-14 5:10 ` Peter Rosin
2017-07-14 7:58 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).