From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Stephan Müller" <smueller@chronox.de>
Cc: "Jason A. Donenfeld" <jason@zx2c4.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v12 1/4] crypto: make Jitter RNG directly accessible
Date: Tue, 18 Jul 2017 10:49:59 +0200 [thread overview]
Message-ID: <20170718084959.GA25267@kroah.com> (raw)
In-Reply-To: <5020806.nso7MErEBx@positron.chronox.de>
On Tue, Jul 18, 2017 at 10:40:07AM +0200, Stephan Müller wrote:
> Am Dienstag, 18. Juli 2017, 10:30:14 CEST schrieb Greg Kroah-Hartman:
>
> Hi Greg,
>
> > > +typedef unsigned long long __u64;
> > > +typedef long long __s64;
> >
> > types.h already has these defines, don't re-typedef them again...
>
> The issue is that the C code is compiled without optimizations. Thus, the C
> code shall not depend on any other header file.
That is very strange for a kernel file, I don't know what to say...
> This issue was discussed during the inclusion of the Jitter RNG C code into
> the kernel.
Ok, that was then, this is now, why not change it now? How does
including types.h change anything?
thanks,
greg k-h
next prev parent reply other threads:[~2017-07-18 8:50 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 7:57 [RFC PATCH v12 0/4] /dev/random - a new approach Stephan Müller
2017-07-18 7:57 ` [RFC PATCH v12 1/4] crypto: make Jitter RNG directly accessible Stephan Müller
2017-07-18 8:30 ` Greg Kroah-Hartman
2017-07-18 8:40 ` Stephan Müller
2017-07-18 8:49 ` Greg Kroah-Hartman [this message]
2017-07-18 8:53 ` Stephan Müller
2017-07-18 9:02 ` Arnd Bergmann
2017-07-18 9:10 ` Stephan Müller
2017-07-18 9:16 ` Arnd Bergmann
2017-07-18 9:17 ` Stephan Müller
2017-07-18 7:58 ` [RFC PATCH v12 2/4] random: conditionally compile code depending on LRNG Stephan Müller
2017-07-18 8:13 ` Arnd Bergmann
2017-07-18 8:37 ` Stephan Müller
2017-07-18 8:47 ` Arnd Bergmann
2017-07-18 8:50 ` Stephan Müller
2017-07-18 7:59 ` [RFC PATCH v12 3/4] Linux Random Number Generator Stephan Müller
2017-07-18 8:32 ` Greg Kroah-Hartman
2017-07-18 8:45 ` Stephan Müller
2017-07-18 8:52 ` Greg Kroah-Hartman
2017-07-18 14:37 ` Stephan Müller
2017-07-18 21:08 ` Theodore Ts'o
2017-07-19 1:00 ` Sandy Harris
2017-07-19 1:51 ` Theodore Ts'o
2017-07-19 6:25 ` Stephan Müller
2017-07-30 10:44 ` Pavel Machek
2017-07-23 18:05 ` Sandy Harris
2017-07-23 21:47 ` Theodore Ts'o
2017-07-19 6:22 ` Stephan Müller
2017-07-19 6:34 ` Greg Kroah-Hartman
2017-07-19 17:26 ` Theodore Ts'o
2017-07-20 19:00 ` Stephan Müller
2017-07-21 3:08 ` Theodore Ts'o
2017-07-21 8:57 ` Stephan Müller
2017-07-21 15:09 ` Arnd Bergmann
2017-07-21 15:17 ` Stephan Müller
2017-07-18 8:52 ` Greg Kroah-Hartman
2017-07-18 7:59 ` [RFC PATCH v12 4/4] LRNG - enable compile Stephan Müller
2017-07-18 8:51 ` Arnd Bergmann
2017-07-18 8:56 ` Stephan Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170718084959.GA25267@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=jason@zx2c4.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).