linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: "Stephan Müller" <smueller@chronox.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Jason A. Donenfeld" <jason@zx2c4.com>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v12 3/4] Linux Random Number Generator
Date: Tue, 18 Jul 2017 17:08:16 -0400	[thread overview]
Message-ID: <20170718210816.o6c4iziaqj5dnnd3@thunk.org> (raw)
In-Reply-To: <1780567.qGdv4EjEMp@positron.chronox.de>

On Tue, Jul 18, 2017 at 04:37:11PM +0200, Stephan Müller wrote:
> > 
> > > I have stated the core concerns I have with random.c in [1]. To remedy
> > > these core concerns, major changes to random.c are needed. With the past
> > > experience, I would doubt that I get the changes into random.c.
> > > 
> > > [1] https://www.spinics.net/lists/linux-crypto/msg26316.html
> > 
> > Evolution is the correct way to do this, kernel development relies on
> > that.  We don't do the "use this totally different and untested file
> > instead!" method.
> 
> I am not sure I understand your reply. The offered patch set does not rip out 
> existing code. It adds a replacement implementation which can be enabled 
> during compile time. Yet it is even disabled per default (and thus the legacy 
> code is compiled).

I've been trying to take the best features and suggestions from your
proposal and integrating them into /dev/random already.  Things that
I've chosen not take is basically because I disbelieve that the Jitter
RNG is valid.  And that's mostly becuase I trust Peter Anvin (who has
access to Intel chip architects, who has expressed unease) more than
you.  (No hard feelings).

So I have been trying to do the evolution thing already.  

> I see such a development approach in numerous different kernel core areas: 
> memory allocators (SLAB, SLOB, SLUB), process schedulers, IRQ schedulers.

But we don't have two VFS layers or two MM layers.  We also don't have
two implementations of printk.

I'm obviously biased, but I don't see I see the Raison d'Etre for
merging LRNG into the kernel.

						- Ted

  reply	other threads:[~2017-07-18 21:08 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-18  7:57 [RFC PATCH v12 0/4] /dev/random - a new approach Stephan Müller
2017-07-18  7:57 ` [RFC PATCH v12 1/4] crypto: make Jitter RNG directly accessible Stephan Müller
2017-07-18  8:30   ` Greg Kroah-Hartman
2017-07-18  8:40     ` Stephan Müller
2017-07-18  8:49       ` Greg Kroah-Hartman
2017-07-18  8:53         ` Stephan Müller
2017-07-18  9:02         ` Arnd Bergmann
2017-07-18  9:10           ` Stephan Müller
2017-07-18  9:16             ` Arnd Bergmann
2017-07-18  9:17               ` Stephan Müller
2017-07-18  7:58 ` [RFC PATCH v12 2/4] random: conditionally compile code depending on LRNG Stephan Müller
2017-07-18  8:13   ` Arnd Bergmann
2017-07-18  8:37     ` Stephan Müller
2017-07-18  8:47       ` Arnd Bergmann
2017-07-18  8:50         ` Stephan Müller
2017-07-18  7:59 ` [RFC PATCH v12 3/4] Linux Random Number Generator Stephan Müller
2017-07-18  8:32   ` Greg Kroah-Hartman
2017-07-18  8:45     ` Stephan Müller
2017-07-18  8:52       ` Greg Kroah-Hartman
2017-07-18 14:37         ` Stephan Müller
2017-07-18 21:08           ` Theodore Ts'o [this message]
2017-07-19  1:00             ` Sandy Harris
2017-07-19  1:51               ` Theodore Ts'o
2017-07-19  6:25                 ` Stephan Müller
2017-07-30 10:44                 ` Pavel Machek
2017-07-23 18:05               ` Sandy Harris
2017-07-23 21:47                 ` Theodore Ts'o
2017-07-19  6:22             ` Stephan Müller
2017-07-19  6:34               ` Greg Kroah-Hartman
2017-07-19 17:26               ` Theodore Ts'o
2017-07-20 19:00                 ` Stephan Müller
2017-07-21  3:08                   ` Theodore Ts'o
2017-07-21  8:57                     ` Stephan Müller
2017-07-21 15:09                       ` Arnd Bergmann
2017-07-21 15:17                         ` Stephan Müller
2017-07-18  8:52       ` Greg Kroah-Hartman
2017-07-18  7:59 ` [RFC PATCH v12 4/4] LRNG - enable compile Stephan Müller
2017-07-18  8:51   ` Arnd Bergmann
2017-07-18  8:56     ` Stephan Müller
2017-07-21 11:30 [RFC PATCH v12 3/4] Linux Random Number Generator Jeffrey Walton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170718210816.o6c4iziaqj5dnnd3@thunk.org \
    --to=tytso@mit.edu \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jason@zx2c4.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=smueller@chronox.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).