* [PATCH] ASoC: pxa: don't select SSP for COMPILE_TESTing
@ 2017-08-07 10:40 Arnd Bergmann
2017-08-07 11:20 ` Mark Brown
2017-08-07 15:39 ` Arnd Bergmann
0 siblings, 2 replies; 7+ messages in thread
From: Arnd Bergmann @ 2017-08-07 10:40 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown
Cc: Arnd Bergmann, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
Jaroslav Kysela, Takashi Iwai, Kuninori Morimoto,
linux-arm-kernel, alsa-devel, linux-kernel
When the audio driver selects CONFIG_PXA_SSP to be a loadable
module on a platform other than PXA, and the PXA SPI driver
is built-in, we get a link error in the SPI driver:
drivers/spi/spi-pxa2xx.o: In function `pxa2xx_spi_remove':
spi-pxa2xx.c:(.text+0x5f0): undefined reference to `pxa_ssp_free'
drivers/spi/spi-pxa2xx.o: In function `pxa2xx_spi_probe':
spi-pxa2xx.c:(.text+0xeac): undefined reference to `pxa_ssp_request'
spi-pxa2xx.c:(.text+0x1468): undefined reference to `pxa_ssp_free'
spi-pxa2xx.c:(.text+0x15bc): undefined reference to `pxa_ssp_free'
Fixes: 73d7ee2e831f ("ASoC: pxa: add COMPILE_TEST on SND_PXA2XX_SOC")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
sound/soc/pxa/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/sound/soc/pxa/Kconfig b/sound/soc/pxa/Kconfig
index 484ab3c2ad67..1d392582559d 100644
--- a/sound/soc/pxa/Kconfig
+++ b/sound/soc/pxa/Kconfig
@@ -33,7 +33,7 @@ config SND_PXA2XX_SOC_I2S
config SND_PXA_SOC_SSP
tristate
- select PXA_SSP
+ select PXA_SSP if ARCH_PXA
config SND_MMP_SOC_SSPA
tristate
@@ -141,7 +141,6 @@ config SND_PXA910_SOC
config SND_SOC_TTC_DKB
tristate "SoC Audio support for TTC DKB"
depends on SND_PXA910_SOC && MACH_TTC_DKB && I2C=y
- select PXA_SSP
select SND_PXA_SOC_SSP
select SND_MMP_SOC
select MFD_88PM860X
--
2.9.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] ASoC: pxa: don't select SSP for COMPILE_TESTing
2017-08-07 10:40 [PATCH] ASoC: pxa: don't select SSP for COMPILE_TESTing Arnd Bergmann
@ 2017-08-07 11:20 ` Mark Brown
2017-08-07 11:36 ` Arnd Bergmann
2017-08-07 15:39 ` Arnd Bergmann
1 sibling, 1 reply; 7+ messages in thread
From: Mark Brown @ 2017-08-07 11:20 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Liam Girdwood, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
Jaroslav Kysela, Takashi Iwai, Kuninori Morimoto,
linux-arm-kernel, alsa-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 284 bytes --]
On Mon, Aug 07, 2017 at 12:40:44PM +0200, Arnd Bergmann wrote:
> When the audio driver selects CONFIG_PXA_SSP to be a loadable
> module on a platform other than PXA, and the PXA SPI driver
> is built-in, we get a link error in the SPI driver:
Why doesn't this cause problems on PXA?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ASoC: pxa: don't select SSP for COMPILE_TESTing
2017-08-07 11:20 ` Mark Brown
@ 2017-08-07 11:36 ` Arnd Bergmann
2017-08-07 11:48 ` Mark Brown
0 siblings, 1 reply; 7+ messages in thread
From: Arnd Bergmann @ 2017-08-07 11:36 UTC (permalink / raw)
To: Mark Brown
Cc: Liam Girdwood, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
Jaroslav Kysela, Takashi Iwai, Kuninori Morimoto, Linux ARM,
alsa-devel, Linux Kernel Mailing List
On Mon, Aug 7, 2017 at 1:20 PM, Mark Brown <broonie@kernel.org> wrote:
> On Mon, Aug 07, 2017 at 12:40:44PM +0200, Arnd Bergmann wrote:
>> When the audio driver selects CONFIG_PXA_SSP to be a loadable
>> module on a platform other than PXA, and the PXA SPI driver
>> is built-in, we get a link error in the SPI driver:
>
> Why doesn't this cause problems on PXA?
On PXA, we 'make' descends into arch/arm/plat-pxa/, where ssp.o
is located. On other ARM platforms (I guess except for MMP),
PLAT_PXA is not set, and on non-ARM architectures, we can't
get there anyway.
Arnd
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ASoC: pxa: don't select SSP for COMPILE_TESTing
2017-08-07 11:36 ` Arnd Bergmann
@ 2017-08-07 11:48 ` Mark Brown
2017-08-07 11:58 ` Arnd Bergmann
0 siblings, 1 reply; 7+ messages in thread
From: Mark Brown @ 2017-08-07 11:48 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Liam Girdwood, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
Jaroslav Kysela, Takashi Iwai, Kuninori Morimoto, Linux ARM,
alsa-devel, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 697 bytes --]
On Mon, Aug 07, 2017 at 01:36:09PM +0200, Arnd Bergmann wrote:
> On Mon, Aug 7, 2017 at 1:20 PM, Mark Brown <broonie@kernel.org> wrote:
> > On Mon, Aug 07, 2017 at 12:40:44PM +0200, Arnd Bergmann wrote:
> >> When the audio driver selects CONFIG_PXA_SSP to be a loadable
> >> module on a platform other than PXA, and the PXA SPI driver
> >> is built-in, we get a link error in the SPI driver:
> > Why doesn't this cause problems on PXA?
> On PXA, we 'make' descends into arch/arm/plat-pxa/, where ssp.o
> is located. On other ARM platforms (I guess except for MMP),
> PLAT_PXA is not set, and on non-ARM architectures, we can't
> get there anyway.
Still missing a few steps of reasoning here...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ASoC: pxa: don't select SSP for COMPILE_TESTing
2017-08-07 11:48 ` Mark Brown
@ 2017-08-07 11:58 ` Arnd Bergmann
2017-08-07 12:00 ` Mark Brown
0 siblings, 1 reply; 7+ messages in thread
From: Arnd Bergmann @ 2017-08-07 11:58 UTC (permalink / raw)
To: Mark Brown
Cc: Liam Girdwood, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
Jaroslav Kysela, Takashi Iwai, Kuninori Morimoto, Linux ARM,
alsa-devel, Linux Kernel Mailing List
On Mon, Aug 7, 2017 at 1:48 PM, Mark Brown <broonie@kernel.org> wrote:
> On Mon, Aug 07, 2017 at 01:36:09PM +0200, Arnd Bergmann wrote:
>> On Mon, Aug 7, 2017 at 1:20 PM, Mark Brown <broonie@kernel.org> wrote:
>> > On Mon, Aug 07, 2017 at 12:40:44PM +0200, Arnd Bergmann wrote:
>> >> When the audio driver selects CONFIG_PXA_SSP to be a loadable
>> >> module on a platform other than PXA, and the PXA SPI driver
>> >> is built-in, we get a link error in the SPI driver:
>
>> > Why doesn't this cause problems on PXA?
>
>> On PXA, we 'make' descends into arch/arm/plat-pxa/, where ssp.o
>> is located. On other ARM platforms (I guess except for MMP),
>> PLAT_PXA is not set, and on non-ARM architectures, we can't
>> get there anyway.
>
> Still missing a few steps of reasoning here...
Sorry, I just realized that you were trying to point out the incomplete
changelog. I must have accidentally closed the editor while working on
it, and then sent it out today after getting no regressions.
I'll resend with a proper changelog.
Arnd
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ASoC: pxa: don't select SSP for COMPILE_TESTing
2017-08-07 11:58 ` Arnd Bergmann
@ 2017-08-07 12:00 ` Mark Brown
0 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2017-08-07 12:00 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Liam Girdwood, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
Jaroslav Kysela, Takashi Iwai, Kuninori Morimoto, Linux ARM,
alsa-devel, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 448 bytes --]
On Mon, Aug 07, 2017 at 01:58:29PM +0200, Arnd Bergmann wrote:
> On Mon, Aug 7, 2017 at 1:48 PM, Mark Brown <broonie@kernel.org> wrote:
> > Still missing a few steps of reasoning here...
> Sorry, I just realized that you were trying to point out the incomplete
> changelog. I must have accidentally closed the editor while working on
> it, and then sent it out today after getting no regressions.
> I'll resend with a proper changelog.
Thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ASoC: pxa: don't select SSP for COMPILE_TESTing
2017-08-07 10:40 [PATCH] ASoC: pxa: don't select SSP for COMPILE_TESTing Arnd Bergmann
2017-08-07 11:20 ` Mark Brown
@ 2017-08-07 15:39 ` Arnd Bergmann
1 sibling, 0 replies; 7+ messages in thread
From: Arnd Bergmann @ 2017-08-07 15:39 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown
Cc: Arnd Bergmann, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
Jaroslav Kysela, Takashi Iwai, Kuninori Morimoto, Linux ARM,
alsa-devel, Linux Kernel Mailing List
On Mon, Aug 7, 2017 at 12:40 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> When the audio driver selects CONFIG_PXA_SSP to be a loadable
> module on a platform other than PXA, and the PXA SPI driver
> is built-in, we get a link error in the SPI driver:
>
> drivers/spi/spi-pxa2xx.o: In function `pxa2xx_spi_remove':
> spi-pxa2xx.c:(.text+0x5f0): undefined reference to `pxa_ssp_free'
> drivers/spi/spi-pxa2xx.o: In function `pxa2xx_spi_probe':
> spi-pxa2xx.c:(.text+0xeac): undefined reference to `pxa_ssp_request'
> spi-pxa2xx.c:(.text+0x1468): undefined reference to `pxa_ssp_free'
> spi-pxa2xx.c:(.text+0x15bc): undefined reference to `pxa_ssp_free'
>
> Fixes: 73d7ee2e831f ("ASoC: pxa: add COMPILE_TEST on SND_PXA2XX_SOC")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
While trying to write up a better changelog, I found that I had run into this
before and attempted a different fix, see
https://patchwork.kernel.org/patch/8879921/
The commit I referred to in "Fixes:" did not introduce a new problem at
all, but it appears to have made it more likely to run into this situation.
Sending a third patch now, again different.
Mark, let me know if you want something else instead.
Arnd
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-08-07 15:39 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-07 10:40 [PATCH] ASoC: pxa: don't select SSP for COMPILE_TESTing Arnd Bergmann
2017-08-07 11:20 ` Mark Brown
2017-08-07 11:36 ` Arnd Bergmann
2017-08-07 11:48 ` Mark Brown
2017-08-07 11:58 ` Arnd Bergmann
2017-08-07 12:00 ` Mark Brown
2017-08-07 15:39 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).