From: Will Deacon <will.deacon@arm.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Andy Lutomirski <luto@kernel.org>,
Matt Fleming <matt@codeblueprint.co.uk>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
joeyli <jlee@suse.com>, Borislav Petkov <bp@alien8.de>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Neri, Ricardo" <ricardo.neri@intel.com>,
"Ravi V. Shankar" <ravi.v.shankar@intel.com>
Subject: Re: [PATCH 3/3] x86/efi: Use efi_switch_mm() rather than manually twiddling with cr3
Date: Thu, 17 Aug 2017 11:35:15 +0100 [thread overview]
Message-ID: <20170817103514.GC27872@arm.com> (raw)
In-Reply-To: <20170815223541.GA25778@remoulade>
On Tue, Aug 15, 2017 at 11:35:41PM +0100, Mark Rutland wrote:
> On Wed, Aug 16, 2017 at 09:14:41AM -0700, Andy Lutomirski wrote:
> > On Wed, Aug 16, 2017 at 5:57 AM, Matt Fleming <matt@codeblueprint.co.uk> wrote:
> > > On Wed, 16 Aug, at 12:03:22PM, Mark Rutland wrote:
> > >>
> > >> I'd expect we'd abort at a higher level, not taking any sample. i.e.
> > >> we'd have the core overflow handler check in_funny_mm(), and if so, skip
> > >> the sample, as with the skid case.
> > >
> > > FYI, this is my preferred solution for x86 too.
> >
> > One option for the "funny mm" flag would be literally the condition
> > current->mm != current->active_mm. I *think* this gets all the cases
> > right as long as efi_switch_mm is careful with its ordering and that
> > the arch switch_mm() code can handle the resulting ordering. (x86's
> > can now, I think, or at least will be able to in 4.14 -- not sure
> > about other arches).
>
> For arm64 we'd have to rework things a bit to get the ordering right
> (especially when we flip to/from the idmap), but otherwise this sounds sane to
> me.
>
> > That being said, there's a totally different solution: run EFI
> > callbacks in a kernel thread. This has other benefits: we could run
> > those callbacks in user mode some day, and doing *that* in a user
> > thread seems like a mistake.
>
> I think that wouldn't work for CPU-bound perf events (which are not
> ctx-switched with the task).
>
> It might be desireable to do that anyway, though.
I'm still concerned that we're treating perf specially here -- are we
absolutely sure that nobody else is going to attempt user accesses off the
back of an interrupt? If not, then I'd much prefer a solution that catches
anybody doing that with the EFI page table installed, rather than trying
to play whack-a-mole like this.
Will
next prev parent reply other threads:[~2017-08-17 10:35 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 19:18 [PATCH 0/3] Use mm_struct and switch_mm() instead of manually Sai Praneeth Prakhya
2017-08-15 19:18 ` [PATCH 1/3] efi: Use efi_mm in x86 as well as ARM Sai Praneeth Prakhya
2017-08-15 19:18 ` [PATCH 2/3] x86/efi: Replace efi_pgd with efi_mm.pgd Sai Praneeth Prakhya
2017-08-15 19:18 ` [PATCH 3/3] x86/efi: Use efi_switch_mm() rather than manually twiddling with cr3 Sai Praneeth Prakhya
2017-08-15 21:46 ` Andy Lutomirski
2017-08-16 0:23 ` Sai Praneeth Prakhya
2017-08-16 0:47 ` Andy Lutomirski
2017-08-16 9:31 ` Ard Biesheuvel
2017-08-16 9:53 ` Mark Rutland
2017-08-16 10:07 ` Will Deacon
2017-08-16 11:03 ` Mark Rutland
2017-08-16 12:57 ` Matt Fleming
2017-08-16 16:14 ` Andy Lutomirski
2017-08-15 22:35 ` Mark Rutland
2017-08-17 10:35 ` Will Deacon [this message]
2017-08-17 15:52 ` Andy Lutomirski
2017-08-21 10:33 ` Peter Zijlstra
2017-08-21 13:56 ` Andy Lutomirski
2017-08-21 14:08 ` Peter Zijlstra
2017-08-21 15:23 ` Andy Lutomirski
2017-08-21 15:59 ` Peter Zijlstra
2017-08-21 16:08 ` Ard Biesheuvel
2017-08-23 22:52 ` Sai Praneeth Prakhya
2017-08-25 15:13 ` Andy Lutomirski
2017-08-21 17:24 ` Peter Zijlstra
2017-08-25 2:36 ` Sai Praneeth Prakhya
2017-08-25 15:13 ` Andy Lutomirski
2017-12-17 0:06 [PATCH 3/3] x86/efi: Use efi_switch_mm() rather than manually twiddling with %cr3 Sai Praneeth Prakhya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170817103514.GC27872@arm.com \
--to=will.deacon@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=bp@alien8.de \
--cc=jlee@suse.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=matt@codeblueprint.co.uk \
--cc=mst@redhat.com \
--cc=peterz@infradead.org \
--cc=ravi.v.shankar@intel.com \
--cc=ricardo.neri@intel.com \
--cc=sai.praneeth.prakhya@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).