linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Antoine Tenart <antoine.tenart@free-electrons.com>
To: davem@davemloft.net, kishon@ti.com, andrew@lunn.ch,
	jason@lakedaemon.net, sebastian.hesselbarth@gmail.com,
	gregory.clement@free-electrons.com
Cc: Antoine Tenart <antoine.tenart@free-electrons.com>,
	thomas.petazzoni@free-electrons.com, nadavh@marvell.com,
	linux@armlinux.org.uk, linux-kernel@vger.kernel.org,
	mw@semihalf.com, stefanc@marvell.com,
	miquel.raynal@free-electrons.com, netdev@vger.kernel.org
Subject: [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode
Date: Fri, 25 Aug 2017 16:48:12 +0200	[thread overview]
Message-ID: <20170825144821.31129-6-antoine.tenart@free-electrons.com> (raw)
In-Reply-To: <20170825144821.31129-1-antoine.tenart@free-electrons.com>

The link mode (speed, duplex) was forced based on what the phylib
returns. This should not be the case, and only forced by ethtool
functions manually. This patch removes the link mode enforcement from
the phylib link_event callback.

Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
---
 drivers/net/ethernet/marvell/mvpp2.c | 24 ------------------------
 1 file changed, 24 deletions(-)

diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c
index fab231858a41..498a4969dc58 100644
--- a/drivers/net/ethernet/marvell/mvpp2.c
+++ b/drivers/net/ethernet/marvell/mvpp2.c
@@ -5741,30 +5741,10 @@ static void mvpp2_link_event(struct net_device *dev)
 	struct mvpp2_port *port = netdev_priv(dev);
 	struct phy_device *phydev = dev->phydev;
 	int status_change = 0;
-	u32 val;
 
 	if (phydev->link) {
 		if ((port->speed != phydev->speed) ||
 		    (port->duplex != phydev->duplex)) {
-			u32 val;
-
-			val = readl(port->base + MVPP2_GMAC_AUTONEG_CONFIG);
-			val &= ~(MVPP2_GMAC_CONFIG_MII_SPEED |
-				 MVPP2_GMAC_CONFIG_GMII_SPEED |
-				 MVPP2_GMAC_CONFIG_FULL_DUPLEX |
-				 MVPP2_GMAC_AN_SPEED_EN |
-				 MVPP2_GMAC_AN_DUPLEX_EN);
-
-			if (phydev->duplex)
-				val |= MVPP2_GMAC_CONFIG_FULL_DUPLEX;
-
-			if (phydev->speed == SPEED_1000)
-				val |= MVPP2_GMAC_CONFIG_GMII_SPEED;
-			else if (phydev->speed == SPEED_100)
-				val |= MVPP2_GMAC_CONFIG_MII_SPEED;
-
-			writel(val, port->base + MVPP2_GMAC_AUTONEG_CONFIG);
-
 			port->duplex = phydev->duplex;
 			port->speed  = phydev->speed;
 		}
@@ -5782,10 +5762,6 @@ static void mvpp2_link_event(struct net_device *dev)
 
 	if (status_change) {
 		if (phydev->link) {
-			val = readl(port->base + MVPP2_GMAC_AUTONEG_CONFIG);
-			val |= (MVPP2_GMAC_FORCE_LINK_PASS |
-				MVPP2_GMAC_FORCE_LINK_DOWN);
-			writel(val, port->base + MVPP2_GMAC_AUTONEG_CONFIG);
 			mvpp2_egress_enable(port);
 			mvpp2_ingress_enable(port);
 		} else {
-- 
2.13.5

  parent reply	other threads:[~2017-08-25 14:50 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-25 14:48 [PATCH net-next v2 00/14] net: mvpp2: comphy configuration Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 01/14] phy: add sgmii and 10gkr modes to the phy_mode enum Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 02/14] phy: add the mvebu cp110 comphy driver Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 03/14] Documentation/bindings: phy: document the Marvell " Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 04/14] net: mvpp2: initialize the comphy Antoine Tenart
2017-08-25 14:48 ` Antoine Tenart [this message]
2017-08-25 22:43   ` [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode Russell King - ARM Linux
2017-08-28  6:55     ` Antoine Tenart
2017-08-28  8:38       ` Marcin Wojtas
2017-08-28  8:51         ` Russell King - ARM Linux
2017-08-28  9:40           ` Antoine Tenart
2017-08-28 11:06             ` Russell King - ARM Linux
2017-08-28 11:32               ` Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 06/14] net: mvpp2: simplify the link_event function Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 07/14] net: mvpp2: improve the link management function Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 08/14] net: mvpp2: check the netif is running in the link_event function Antoine Tenart
2017-08-25 16:49   ` Florian Fainelli
2017-08-25 17:09     ` Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 09/14] net: mvpp2: dynamic reconfiguration of the PHY mode Antoine Tenart
2017-08-25 22:46   ` Russell King - ARM Linux
2017-08-28  6:52     ` Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 10/14] arm64: dts: marvell: extend the cp110 syscon register area length Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 11/14] arm64: dts: marvell: add comphy nodes on cp110 master and slave Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 12/14] arm64: dts: marvell: mcbin: add comphy references to Ethernet ports Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 13/14] arm64: dts: marvell: 7040-db: " Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 14/14] arm64: defconfig: enable Marvell CP110 comphy Antoine Tenart
2017-08-25 15:51 ` [PATCH net-next v2 00/14] net: mvpp2: comphy configuration Andrew Lunn
2017-08-25 15:56   ` Antoine Tenart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170825144821.31129-6-antoine.tenart@free-electrons.com \
    --to=antoine.tenart@free-electrons.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=gregory.clement@free-electrons.com \
    --cc=jason@lakedaemon.net \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=miquel.raynal@free-electrons.com \
    --cc=mw@semihalf.com \
    --cc=nadavh@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=stefanc@marvell.com \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).