From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Antoine Tenart <antoine.tenart@free-electrons.com>
Cc: davem@davemloft.net, kishon@ti.com, andrew@lunn.ch,
jason@lakedaemon.net, sebastian.hesselbarth@gmail.com,
gregory.clement@free-electrons.com,
thomas.petazzoni@free-electrons.com, nadavh@marvell.com,
linux-kernel@vger.kernel.org, mw@semihalf.com,
stefanc@marvell.com, miquel.raynal@free-electrons.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 09/14] net: mvpp2: dynamic reconfiguration of the PHY mode
Date: Fri, 25 Aug 2017 23:46:16 +0100 [thread overview]
Message-ID: <20170825224616.GE20805@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20170825144821.31129-10-antoine.tenart@free-electrons.com>
On Fri, Aug 25, 2017 at 04:48:16PM +0200, Antoine Tenart wrote:
> This patch adds logic to reconfigure the comphy/gop when the link status
> change at runtime. This is very useful on boards such as the mcbin which
> have SFP and Ethernet ports connected to the same MAC port: depending on
> what the user connects the driver will automatically reconfigure the
> link mode.
This commit commentry needs updating - as I've already pointed out in
the previous round, the need to reconfigure things has *nothing* to do
with there being SFP and "Ethernet" ports present. Hence, your commit
message is entirely misleading.
>
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> ---
> drivers/net/ethernet/marvell/mvpp2.c | 21 ++++++++++++++++++++-
> 1 file changed, 20 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c
> index 49a6789a4142..04e0c8ab7b51 100644
> --- a/drivers/net/ethernet/marvell/mvpp2.c
> +++ b/drivers/net/ethernet/marvell/mvpp2.c
> @@ -5740,6 +5740,7 @@ static void mvpp2_link_event(struct net_device *dev)
> {
> struct mvpp2_port *port = netdev_priv(dev);
> struct phy_device *phydev = dev->phydev;
> + bool link_reconfigured = false;
>
> if (!netif_running(dev))
> return;
> @@ -5750,9 +5751,27 @@ static void mvpp2_link_event(struct net_device *dev)
> port->duplex = phydev->duplex;
> port->speed = phydev->speed;
> }
> +
> + if (port->phy_interface != phydev->interface && port->comphy) {
> + /* disable current port for reconfiguration */
> + mvpp2_interrupts_disable(port);
> + netif_carrier_off(port->dev);
> + mvpp2_port_disable(port);
> + phy_power_off(port->comphy);
> +
> + /* comphy reconfiguration */
> + port->phy_interface = phydev->interface;
> + mvpp22_comphy_init(port);
> +
> + /* gop/mac reconfiguration */
> + mvpp22_gop_init(port);
> + mvpp2_port_mii_set(port);
> +
> + link_reconfigured = true;
> + }
> }
>
> - if (phydev->link != port->link) {
> + if (phydev->link != port->link || link_reconfigured) {
> port->link = phydev->link;
>
> if (phydev->link) {
> --
> 2.13.5
>
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up
next prev parent reply other threads:[~2017-08-25 22:46 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 14:48 [PATCH net-next v2 00/14] net: mvpp2: comphy configuration Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 01/14] phy: add sgmii and 10gkr modes to the phy_mode enum Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 02/14] phy: add the mvebu cp110 comphy driver Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 03/14] Documentation/bindings: phy: document the Marvell " Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 04/14] net: mvpp2: initialize the comphy Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode Antoine Tenart
2017-08-25 22:43 ` Russell King - ARM Linux
2017-08-28 6:55 ` Antoine Tenart
2017-08-28 8:38 ` Marcin Wojtas
2017-08-28 8:51 ` Russell King - ARM Linux
2017-08-28 9:40 ` Antoine Tenart
2017-08-28 11:06 ` Russell King - ARM Linux
2017-08-28 11:32 ` Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 06/14] net: mvpp2: simplify the link_event function Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 07/14] net: mvpp2: improve the link management function Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 08/14] net: mvpp2: check the netif is running in the link_event function Antoine Tenart
2017-08-25 16:49 ` Florian Fainelli
2017-08-25 17:09 ` Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 09/14] net: mvpp2: dynamic reconfiguration of the PHY mode Antoine Tenart
2017-08-25 22:46 ` Russell King - ARM Linux [this message]
2017-08-28 6:52 ` Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 10/14] arm64: dts: marvell: extend the cp110 syscon register area length Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 11/14] arm64: dts: marvell: add comphy nodes on cp110 master and slave Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 12/14] arm64: dts: marvell: mcbin: add comphy references to Ethernet ports Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 13/14] arm64: dts: marvell: 7040-db: " Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 14/14] arm64: defconfig: enable Marvell CP110 comphy Antoine Tenart
2017-08-25 15:51 ` [PATCH net-next v2 00/14] net: mvpp2: comphy configuration Andrew Lunn
2017-08-25 15:56 ` Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170825224616.GE20805@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@free-electrons.com \
--cc=davem@davemloft.net \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@free-electrons.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).