From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Marcin Wojtas <mw@semihalf.com>
Cc: "Antoine Tenart" <antoine.tenart@free-electrons.com>,
"David S. Miller" <davem@davemloft.net>,
kishon@ti.com, "Andrew Lunn" <andrew@lunn.ch>,
"Jason Cooper" <jason@lakedaemon.net>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Gregory Clément" <gregory.clement@free-electrons.com>,
"Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>,
nadavh@marvell.com, linux-kernel@vger.kernel.org,
"Stefan Chulski" <stefanc@marvell.com>,
"Miquèl Raynal" <miquel.raynal@free-electrons.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode
Date: Mon, 28 Aug 2017 09:51:52 +0100 [thread overview]
Message-ID: <20170828085152.GF20805@n2100.armlinux.org.uk> (raw)
In-Reply-To: <CAPv3WKfSGfSAfade163-Q29SR5mxkV19LmYRxVdRBbfW-e-xfg@mail.gmail.com>
On Mon, Aug 28, 2017 at 10:38:37AM +0200, Marcin Wojtas wrote:
> Hi Antoine,
>
> Can you be 100% sure that when using SGMII with PHY's (like Marvell
> Alaska 88E1xxx series), is in-band link information always available?
> I'd be very cautious with such assumption and use in-band management
> only when set in the DT, like mvneta. I think phylib can properly can
> do its work when MDIO connection is provided on the board.
There is another issue to be aware of: if you're wanting to use flow
control autonegotiation, that is not carried across SGMII's in-band
signalling. If you want to use SGMII's in-band signalling for the
duplex and speed information, you still need phylib's notification
to properly set the flow control.
<plug>
Switching mvpp2 to use phylink (which is needed for the 1G SFP slot on
mcbin) will handle all this for you - dealing with both in-band and
out-of-band negotiation methods, and combining them in the appropriate
manner for the selected operation mode.
</plug>
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up
next prev parent reply other threads:[~2017-08-28 8:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 14:48 [PATCH net-next v2 00/14] net: mvpp2: comphy configuration Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 01/14] phy: add sgmii and 10gkr modes to the phy_mode enum Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 02/14] phy: add the mvebu cp110 comphy driver Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 03/14] Documentation/bindings: phy: document the Marvell " Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 04/14] net: mvpp2: initialize the comphy Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode Antoine Tenart
2017-08-25 22:43 ` Russell King - ARM Linux
2017-08-28 6:55 ` Antoine Tenart
2017-08-28 8:38 ` Marcin Wojtas
2017-08-28 8:51 ` Russell King - ARM Linux [this message]
2017-08-28 9:40 ` Antoine Tenart
2017-08-28 11:06 ` Russell King - ARM Linux
2017-08-28 11:32 ` Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 06/14] net: mvpp2: simplify the link_event function Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 07/14] net: mvpp2: improve the link management function Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 08/14] net: mvpp2: check the netif is running in the link_event function Antoine Tenart
2017-08-25 16:49 ` Florian Fainelli
2017-08-25 17:09 ` Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 09/14] net: mvpp2: dynamic reconfiguration of the PHY mode Antoine Tenart
2017-08-25 22:46 ` Russell King - ARM Linux
2017-08-28 6:52 ` Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 10/14] arm64: dts: marvell: extend the cp110 syscon register area length Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 11/14] arm64: dts: marvell: add comphy nodes on cp110 master and slave Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 12/14] arm64: dts: marvell: mcbin: add comphy references to Ethernet ports Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 13/14] arm64: dts: marvell: 7040-db: " Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 14/14] arm64: defconfig: enable Marvell CP110 comphy Antoine Tenart
2017-08-25 15:51 ` [PATCH net-next v2 00/14] net: mvpp2: comphy configuration Andrew Lunn
2017-08-25 15:56 ` Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170828085152.GF20805@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@free-electrons.com \
--cc=davem@davemloft.net \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@free-electrons.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).