[PATCH 1/2] pinctrl: sprd: add missing Kconfig dependency

[PATCH 1/2] pinctrl: sprd: add missing Kconfig dependency

[Arnd Bergmann]

The chip-specific driver fails to build when the common
part is not enabled first:

drivers/pinctrl/sprd/pinctrl-sprd-sc9860.o:(.data+0x8): undefined reference to `sprd_pinctrl_remove'
drivers/pinctrl/sprd/pinctrl-sprd-sc9860.o:(.data+0x10): undefined reference to `sprd_pinctrl_shutdown'

This adds a Kconfig dependency to ensure this is always
the case.

Fixes: 41d32cfce1ae ("pinctrl: sprd: Add Spreadtrum pin control driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/pinctrl/sprd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/sprd/Kconfig b/drivers/pinctrl/sprd/Kconfig
index 6f4a7f9ac6fd..ec21b8bae487 100644
--- a/drivers/pinctrl/sprd/Kconfig
+++ b/drivers/pinctrl/sprd/Kconfig
@@ -13,5 +13,6 @@ config PINCTRL_SPRD
 
 config PINCTRL_SPRD_SC9860
 	bool "Spreadtrum SC9860 pinctrl driver"
+	depends on PINCTRL_SPRD
 	help
 	  Say Y here to enable Spreadtrum SC9860 pinctrl driver
-- 
2.9.0

[PATCH 2/2] pinctrl: sprd: add CONFIG_OF dependency

[Arnd Bergmann]

Without CONFIG_OF, we run into a build error:

drivers/pinctrl/sprd/pinctrl-sprd.c: In function 'sprd_dt_node_to_map':
drivers/pinctrl/sprd/pinctrl-sprd.c:290:8: error: implicit declaration of function 'pinconf_generic_parse_dt_config'; did you mean 'pinconf_generic_dump_config'? [-Werror=implicit-function-declaration]

This adds a Kconfig dependency for it.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/pinctrl/sprd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/sprd/Kconfig b/drivers/pinctrl/sprd/Kconfig
index ec21b8bae487..e75cde2e1b46 100644
--- a/drivers/pinctrl/sprd/Kconfig
+++ b/drivers/pinctrl/sprd/Kconfig
@@ -4,6 +4,7 @@
 
 config PINCTRL_SPRD
 	bool "Spreadtrum pinctrl driver"
+	depends on OF
 	select PINMUX
 	select PINCONF
 	select GENERIC_PINCONF
-- 
2.9.0

Re: [PATCH 1/2] pinctrl: sprd: add missing Kconfig dependency

[Linus Walleij]

On Tue, Sep 5, 2017 at 9:58 AM, Arnd Bergmann <arnd@arndb.de> wrote:

> The chip-specific driver fails to build when the common
> part is not enabled first:
>
> drivers/pinctrl/sprd/pinctrl-sprd-sc9860.o:(.data+0x8): undefined reference to `sprd_pinctrl_remove'
> drivers/pinctrl/sprd/pinctrl-sprd-sc9860.o:(.data+0x10): undefined reference to `sprd_pinctrl_shutdown'
>
> This adds a Kconfig dependency to ensure this is always
> the case.
>
> Fixes: 41d32cfce1ae ("pinctrl: sprd: Add Spreadtrum pin control driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

I got a fix for this and the other problem from Randy Dunlap already.
Thanks anyway!

Yours,
Linus Walleij