* [PATCH] tools: objtool: fix memory leak in elf_create_rela_section()
@ 2017-09-13 22:41 Josh Poimboeuf
2017-09-14 5:31 ` Ingo Molnar
0 siblings, 1 reply; 8+ messages in thread
From: Josh Poimboeuf @ 2017-09-13 22:41 UTC (permalink / raw)
To: Ingo Molnar; +Cc: linux-kernel, Martin Kepplinger
From: Martin Kepplinger <martink@posteo.de>
Let's free the allocated char array relaname before returning
in order to avoid leaking memory.
Signed-off-by: Martin Kepplinger <martink@posteo.de>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
---
tools/objtool/elf.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c
index 6e9f980a7d26..6aacbc31316d 100644
--- a/tools/objtool/elf.c
+++ b/tools/objtool/elf.c
@@ -508,8 +508,12 @@ struct section *elf_create_rela_section(struct elf *elf, struct section *base)
strcat(relaname, base->name);
sec = elf_create_section(elf, relaname, sizeof(GElf_Rela), 0);
- if (!sec)
+ if (!sec) {
+ free(relaname);
return NULL;
+ }
+
+ free(relaname);
base->rela = sec;
sec->base = base;
--
2.13.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] tools: objtool: fix memory leak in elf_create_rela_section()
2017-09-13 22:41 [PATCH] tools: objtool: fix memory leak in elf_create_rela_section() Josh Poimboeuf
@ 2017-09-14 5:31 ` Ingo Molnar
2017-09-14 6:01 ` [PATCH v2] " Martin Kepplinger
0 siblings, 1 reply; 8+ messages in thread
From: Ingo Molnar @ 2017-09-14 5:31 UTC (permalink / raw)
To: Josh Poimboeuf; +Cc: linux-kernel, Martin Kepplinger
* Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> From: Martin Kepplinger <martink@posteo.de>
>
> Let's free the allocated char array relaname before returning
> in order to avoid leaking memory.
>
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
> ---
> tools/objtool/elf.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c
> index 6e9f980a7d26..6aacbc31316d 100644
> --- a/tools/objtool/elf.c
> +++ b/tools/objtool/elf.c
> @@ -508,8 +508,12 @@ struct section *elf_create_rela_section(struct elf *elf, struct section *base)
> strcat(relaname, base->name);
>
> sec = elf_create_section(elf, relaname, sizeof(GElf_Rela), 0);
> - if (!sec)
> + if (!sec) {
> + free(relaname);
> return NULL;
> + }
> +
> + free(relaname);
Erm, I'm quite sure if you read this code a second time you'll see how this
pattern could be improved! ;-)
Thanks,
Ingo
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] tools: objtool: fix memory leak in elf_create_rela_section()
2017-09-14 5:31 ` Ingo Molnar
@ 2017-09-14 6:01 ` Martin Kepplinger
2017-09-14 12:50 ` Josh Poimboeuf
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Martin Kepplinger @ 2017-09-14 6:01 UTC (permalink / raw)
To: mingo.kernel.org, jpoimboe; +Cc: linux-kernel, Martin Kepplinger
Let's free the allocated char array relaname before returning
in order to avoid leaking memory.
Signed-off-by: Martin Kepplinger <martink@posteo.de>
---
I should've allocated some brain resources before freeing some computer's.
tools/objtool/elf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c
index 6e9f980a7d26..1e89a5f8bfc9 100644
--- a/tools/objtool/elf.c
+++ b/tools/objtool/elf.c
@@ -508,6 +508,7 @@ struct section *elf_create_rela_section(struct elf *elf, struct section *base)
strcat(relaname, base->name);
sec = elf_create_section(elf, relaname, sizeof(GElf_Rela), 0);
+ free(relaname);
if (!sec)
return NULL;
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] tools: objtool: fix memory leak in elf_create_rela_section()
2017-09-14 6:01 ` [PATCH v2] " Martin Kepplinger
@ 2017-09-14 12:50 ` Josh Poimboeuf
2017-09-14 14:06 ` [tip:core/urgent] tools/objtool: Fix " tip-bot for Martin Kepplinger
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Josh Poimboeuf @ 2017-09-14 12:50 UTC (permalink / raw)
To: Martin Kepplinger; +Cc: mingo.kernel.org, linux-kernel
On Thu, Sep 14, 2017 at 08:01:38AM +0200, Martin Kepplinger wrote:
> Let's free the allocated char array relaname before returning
> in order to avoid leaking memory.
>
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
> ---
>
> I should've allocated some brain resources before freeing some computer's.
Oops. I also failed to engage the brain. Sometimes the simplest
patches are the most deceptive. ;-)
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
--
Josh
^ permalink raw reply [flat|nested] 8+ messages in thread
* [tip:core/urgent] tools/objtool: Fix memory leak in elf_create_rela_section()
2017-09-14 6:01 ` [PATCH v2] " Martin Kepplinger
2017-09-14 12:50 ` Josh Poimboeuf
@ 2017-09-14 14:06 ` tip-bot for Martin Kepplinger
2017-09-15 8:43 ` tip-bot for Martin Kepplinger
2017-09-15 9:36 ` [tip:core/urgent] objtool: " tip-bot for Martin Kepplinger
3 siblings, 0 replies; 8+ messages in thread
From: tip-bot for Martin Kepplinger @ 2017-09-14 14:06 UTC (permalink / raw)
To: linux-tip-commits
Cc: peterz, martink, tglx, hpa, torvalds, linux-kernel, dzickus,
mingo, jpoimboe
Commit-ID: 5d0be52d44e32ae98b1345e9ecfa6a97783ca2c9
Gitweb: http://git.kernel.org/tip/5d0be52d44e32ae98b1345e9ecfa6a97783ca2c9
Author: Martin Kepplinger <martink@posteo.de>
AuthorDate: Thu, 14 Sep 2017 08:01:38 +0200
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 14 Sep 2017 16:02:30 +0200
tools/objtool: Fix memory leak in elf_create_rela_section()
Let's free the allocated char array 'relaname' before returning,
in order to avoid leaking memory.
Signed-off-by: Martin Kepplinger <martink@posteo.de>
Reviewed-by: Don Zickus <dzickus@redhat.com>
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: mingo.kernel.org@gmail.com
Link: http://lkml.kernel.org/r/20170914060138.26472-1-martink@posteo.de
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
tools/objtool/elf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c
index 6e9f980..1e89a5f 100644
--- a/tools/objtool/elf.c
+++ b/tools/objtool/elf.c
@@ -508,6 +508,7 @@ struct section *elf_create_rela_section(struct elf *elf, struct section *base)
strcat(relaname, base->name);
sec = elf_create_section(elf, relaname, sizeof(GElf_Rela), 0);
+ free(relaname);
if (!sec)
return NULL;
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [tip:core/urgent] tools/objtool: Fix memory leak in elf_create_rela_section()
2017-09-14 6:01 ` [PATCH v2] " Martin Kepplinger
2017-09-14 12:50 ` Josh Poimboeuf
2017-09-14 14:06 ` [tip:core/urgent] tools/objtool: Fix " tip-bot for Martin Kepplinger
@ 2017-09-15 8:43 ` tip-bot for Martin Kepplinger
2017-09-15 9:36 ` [tip:core/urgent] objtool: " tip-bot for Martin Kepplinger
3 siblings, 0 replies; 8+ messages in thread
From: tip-bot for Martin Kepplinger @ 2017-09-15 8:43 UTC (permalink / raw)
To: linux-tip-commits
Cc: dzickus, linux-kernel, jpoimboe, tglx, mingo, hpa, peterz,
torvalds, martink
Commit-ID: 5b1972d74446bed79df5ddc9674bc3f2a0b6c444
Gitweb: http://git.kernel.org/tip/5b1972d74446bed79df5ddc9674bc3f2a0b6c444
Author: Martin Kepplinger <martink@posteo.de>
AuthorDate: Thu, 14 Sep 2017 08:01:38 +0200
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Fri, 15 Sep 2017 10:30:30 +0200
tools/objtool: Fix memory leak in elf_create_rela_section()
Let's free the allocated char array 'relaname' before returning,
in order to avoid leaking memory.
Signed-off-by: Martin Kepplinger <martink@posteo.de>
Reviewed-by: Don Zickus <dzickus@redhat.com>
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: mingo.kernel.org@gmail.com
Link: http://lkml.kernel.org/r/20170914060138.26472-1-martink@posteo.de
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
tools/objtool/elf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c
index 6e9f980..1e89a5f 100644
--- a/tools/objtool/elf.c
+++ b/tools/objtool/elf.c
@@ -508,6 +508,7 @@ struct section *elf_create_rela_section(struct elf *elf, struct section *base)
strcat(relaname, base->name);
sec = elf_create_section(elf, relaname, sizeof(GElf_Rela), 0);
+ free(relaname);
if (!sec)
return NULL;
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [tip:core/urgent] objtool: Fix memory leak in elf_create_rela_section()
2017-09-14 6:01 ` [PATCH v2] " Martin Kepplinger
` (2 preceding siblings ...)
2017-09-15 8:43 ` tip-bot for Martin Kepplinger
@ 2017-09-15 9:36 ` tip-bot for Martin Kepplinger
3 siblings, 0 replies; 8+ messages in thread
From: tip-bot for Martin Kepplinger @ 2017-09-15 9:36 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, martink, torvalds, tglx, peterz, jpoimboe, mingo
Commit-ID: 0998b7a0befdf6e734032895ee639a5e6f88cc3f
Gitweb: http://git.kernel.org/tip/0998b7a0befdf6e734032895ee639a5e6f88cc3f
Author: Martin Kepplinger <martink@posteo.de>
AuthorDate: Thu, 14 Sep 2017 08:01:38 +0200
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Fri, 15 Sep 2017 11:31:43 +0200
objtool: Fix memory leak in elf_create_rela_section()
Let's free the allocated char array 'relaname' before returning,
in order to avoid leaking memory.
Signed-off-by: Martin Kepplinger <martink@posteo.de>
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: mingo.kernel.org@gmail.com
Link: http://lkml.kernel.org/r/20170914060138.26472-1-martink@posteo.de
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
tools/objtool/elf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c
index 6e9f980..1e89a5f 100644
--- a/tools/objtool/elf.c
+++ b/tools/objtool/elf.c
@@ -508,6 +508,7 @@ struct section *elf_create_rela_section(struct elf *elf, struct section *base)
strcat(relaname, base->name);
sec = elf_create_section(elf, relaname, sizeof(GElf_Rela), 0);
+ free(relaname);
if (!sec)
return NULL;
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] tools: objtool: fix memory leak in elf_create_rela_section()
@ 2017-09-13 18:52 Martin Kepplinger
0 siblings, 0 replies; 8+ messages in thread
From: Martin Kepplinger @ 2017-09-13 18:52 UTC (permalink / raw)
To: jpoimboe; +Cc: linux-kernel, Martin Kepplinger
Let's free the allocated char array relaname before returning
in order to avoid leaking memory.
Signed-off-by: Martin Kepplinger <martink@posteo.de>
---
tools/objtool/elf.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c
index 6e9f980a7d26..6aacbc31316d 100644
--- a/tools/objtool/elf.c
+++ b/tools/objtool/elf.c
@@ -508,8 +508,12 @@ struct section *elf_create_rela_section(struct elf *elf, struct section *base)
strcat(relaname, base->name);
sec = elf_create_section(elf, relaname, sizeof(GElf_Rela), 0);
- if (!sec)
+ if (!sec) {
+ free(relaname);
return NULL;
+ }
+
+ free(relaname);
base->rela = sec;
sec->base = base;
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-09-15 9:40 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-13 22:41 [PATCH] tools: objtool: fix memory leak in elf_create_rela_section() Josh Poimboeuf
2017-09-14 5:31 ` Ingo Molnar
2017-09-14 6:01 ` [PATCH v2] " Martin Kepplinger
2017-09-14 12:50 ` Josh Poimboeuf
2017-09-14 14:06 ` [tip:core/urgent] tools/objtool: Fix " tip-bot for Martin Kepplinger
2017-09-15 8:43 ` tip-bot for Martin Kepplinger
2017-09-15 9:36 ` [tip:core/urgent] objtool: " tip-bot for Martin Kepplinger
-- strict thread matches above, loose matches on Subject: below --
2017-09-13 18:52 [PATCH] tools: objtool: fix " Martin Kepplinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).