* [PATCH] net: phy: Fix mask value write on gmii2rgmii converter speed register.
@ 2017-09-14 7:16 Fahad Kunnathadi
2017-09-14 14:34 ` Andrew Lunn
0 siblings, 1 reply; 5+ messages in thread
From: Fahad Kunnathadi @ 2017-09-14 7:16 UTC (permalink / raw)
To: f.fainelli
Cc: michal.simek, soren.brinkmann, netdev, linux-arm-kernel,
linux-kernel, Fahad Kunnathadi
To clear Speed Selection in MDIO control register(0x10),
ie, clear bits 6 and 13 to zero while keeping other bits same.
Before AND operation,The Mask value has to be perform with bitwise NOT
operation (ie, ~ operator)
This patch clears current speed selection before writing the
new speed settings to gmii2rgmii converter
Signed-off-by: Fahad Kunnathadi <fahad.kunnathadi@dexceldesigns.com>
---
drivers/net/phy/xilinx_gmii2rgmii.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/xilinx_gmii2rgmii.c b/drivers/net/phy/xilinx_gmii2rgmii.c
index d15dd39..2e5150b 100644
--- a/drivers/net/phy/xilinx_gmii2rgmii.c
+++ b/drivers/net/phy/xilinx_gmii2rgmii.c
@@ -44,7 +44,7 @@ static int xgmiitorgmii_read_status(struct phy_device *phydev)
priv->phy_drv->read_status(phydev);
val = mdiobus_read(phydev->mdio.bus, priv->addr, XILINX_GMII2RGMII_REG);
- val &= XILINX_GMII2RGMII_SPEED_MASK;
+ val &= ~XILINX_GMII2RGMII_SPEED_MASK;
if (phydev->speed == SPEED_1000)
val |= BMCR_SPEED1000;
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] net: phy: Fix mask value write on gmii2rgmii converter speed register.
2017-09-14 7:16 [PATCH] net: phy: Fix mask value write on gmii2rgmii converter speed register Fahad Kunnathadi
@ 2017-09-14 14:34 ` Andrew Lunn
2017-09-15 7:16 ` Fahad Kunnathadi
2017-09-15 7:49 ` Michal Simek
0 siblings, 2 replies; 5+ messages in thread
From: Andrew Lunn @ 2017-09-14 14:34 UTC (permalink / raw)
To: Fahad Kunnathadi
Cc: f.fainelli, netdev, michal.simek, linux-kernel, soren.brinkmann,
linux-arm-kernel
On Thu, Sep 14, 2017 at 12:46:31PM +0530, Fahad Kunnathadi wrote:
> To clear Speed Selection in MDIO control register(0x10),
> ie, clear bits 6 and 13 to zero while keeping other bits same.
> Before AND operation,The Mask value has to be perform with bitwise NOT
> operation (ie, ~ operator)
>
> This patch clears current speed selection before writing the
> new speed settings to gmii2rgmii converter
Hi Fahad
I expect you will find other issues with this driver. I pointed some
out at the time it is submitted, but the developers went quiet as soon
as it was accepted.
Anyway, please ensure David Miller <davem@davemloft.net> gets a copy.
The subject line should be:
[PATCH net] net: phy: Fix mask value write on gmii2rgmii converter speed register.
and include a fixes tag:
Fixes: f411a6160bd4 ("net: phy: Add gmiitorgmii converter support")
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: phy: Fix mask value write on gmii2rgmii converter speed register.
2017-09-14 14:34 ` Andrew Lunn
@ 2017-09-15 7:16 ` Fahad Kunnathadi
2017-09-15 7:49 ` Michal Simek
1 sibling, 0 replies; 5+ messages in thread
From: Fahad Kunnathadi @ 2017-09-15 7:16 UTC (permalink / raw)
To: Andrew Lunn
Cc: f fainelli, netdev, Michal Simek, linux-kernel, soren brinkmann,
linux-arm-kernel
Hi Andrew,
Thank you for review and comments.
I will review this driver code with any review comments before, and update you if I could find any..
Best Regards
Fahad K
----- Original Message -----
From: "Andrew Lunn" <andrew@lunn.ch>
To: "Fahad Kunnathadi" <fahad.kunnathadi@dexceldesigns.com>
Cc: "f fainelli" <f.fainelli@gmail.com>, netdev@vger.kernel.org, "Michal Simek" <michal.simek@xilinx.com>, linux-kernel@vger.kernel.org, "soren brinkmann" <soren.brinkmann@xilinx.com>, linux-arm-kernel@lists.infradead.org
Sent: Thursday, September 14, 2017 8:04:54 PM
Subject: Re: [PATCH] net: phy: Fix mask value write on gmii2rgmii converter speed register.
On Thu, Sep 14, 2017 at 12:46:31PM +0530, Fahad Kunnathadi wrote:
> To clear Speed Selection in MDIO control register(0x10),
> ie, clear bits 6 and 13 to zero while keeping other bits same.
> Before AND operation,The Mask value has to be perform with bitwise NOT
> operation (ie, ~ operator)
>
> This patch clears current speed selection before writing the
> new speed settings to gmii2rgmii converter
Hi Fahad
I expect you will find other issues with this driver. I pointed some
out at the time it is submitted, but the developers went quiet as soon
as it was accepted.
Anyway, please ensure David Miller <davem@davemloft.net> gets a copy.
The subject line should be:
[PATCH net] net: phy: Fix mask value write on gmii2rgmii converter speed register.
and include a fixes tag:
Fixes: f411a6160bd4 ("net: phy: Add gmiitorgmii converter support")
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: phy: Fix mask value write on gmii2rgmii converter speed register.
2017-09-14 14:34 ` Andrew Lunn
2017-09-15 7:16 ` Fahad Kunnathadi
@ 2017-09-15 7:49 ` Michal Simek
2017-09-15 14:10 ` Andrew Lunn
1 sibling, 1 reply; 5+ messages in thread
From: Michal Simek @ 2017-09-15 7:49 UTC (permalink / raw)
To: Andrew Lunn, Fahad Kunnathadi
Cc: f.fainelli, netdev, michal.simek, linux-kernel, soren.brinkmann,
linux-arm-kernel
On 14.9.2017 16:34, Andrew Lunn wrote:
> On Thu, Sep 14, 2017 at 12:46:31PM +0530, Fahad Kunnathadi wrote:
>> To clear Speed Selection in MDIO control register(0x10),
>> ie, clear bits 6 and 13 to zero while keeping other bits same.
>> Before AND operation,The Mask value has to be perform with bitwise NOT
>> operation (ie, ~ operator)
>>
>> This patch clears current speed selection before writing the
>> new speed settings to gmii2rgmii converter
>
> Hi Fahad
>
> I expect you will find other issues with this driver. I pointed some
> out at the time it is submitted, but the developers went quiet as soon
> as it was accepted.
Can you please point me to that email?
I will create ticket about it in our system to get them resolved.
Thanks,
Michal
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: phy: Fix mask value write on gmii2rgmii converter speed register.
2017-09-15 7:49 ` Michal Simek
@ 2017-09-15 14:10 ` Andrew Lunn
0 siblings, 0 replies; 5+ messages in thread
From: Andrew Lunn @ 2017-09-15 14:10 UTC (permalink / raw)
To: Michal Simek
Cc: Fahad Kunnathadi, f.fainelli, netdev, linux-kernel,
soren.brinkmann, linux-arm-kernel
> Can you please point me to that email?
I assume you can search the email lists just as well as i can.
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-09-15 14:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-14 7:16 [PATCH] net: phy: Fix mask value write on gmii2rgmii converter speed register Fahad Kunnathadi
2017-09-14 14:34 ` Andrew Lunn
2017-09-15 7:16 ` Fahad Kunnathadi
2017-09-15 7:49 ` Michal Simek
2017-09-15 14:10 ` Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).