From: Pavel Machek <pavel@ucw.cz>
To: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org, rdunlap@infradead.org,
tglx@linutronix.de, tixxdz@gmail.com, gladkov.alexey@gmail.com,
Aliaksandr Patseyenak <Aliaksandr_Patseyenak1@epam.com>
Subject: Re: [PATCH 1/2 v2] fdmap(2)
Date: Mon, 23 Oct 2017 11:29:39 +0200 [thread overview]
Message-ID: <20171023092938.GC32228@amd> (raw)
In-Reply-To: <9bc11ace-d111-cdef-5280-8cdda027ae9a@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1651 bytes --]
Hi!
> > From: Aliaksandr Patseyenak <Aliaksandr_Patseyenak1@epam.com>
> >
> > Implement system call for bulk retrieveing of opened descriptors
> > in binary form.
> >
> > Some daemons could use it to reliably close file descriptors
> > before starting. Currently they close everything upto some number
> > which formally is not reliable. Other natural users are lsof(1) and CRIU
> > (although lsof does so much in /proc that the effect is thoroughly buried).
> >
> > /proc, the only way to learn anything about file descriptors may not be
> > available. There is unavoidable overhead associated with instantiating
> > 3 dentries and 3 inodes and converting integers to strings and back.
> >
> > Benchmark:
> >
> > N=1<<22 times
> > 4 opened descriptors (0, 1, 2, 3)
> > opendir+readdir+closedir /proc/self/fd vs fdmap
> >
> > /proc 8.31 ± 0.37%
> > fdmap 0.32 ± 0.72%
>
> >From the text above, I'm still trying to understand: whose problem
> does this solve? I mean, we've lived with the daemon-close-all-files
> technique forever (and I'm not sure that performance is really an
> important issue for the daemon case) . And you say that the effect
Binary fdmap looks... quite ugly to me. But close_all(from, to)
syscall kindof makes sense to me... and is not that ugly.
Given that openbsd has something similar... perhaps we can take that?
Except during startup, application should have good idea what fds it
has open, so maybe that's enough?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2017-10-23 9:29 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-24 20:06 [PATCH 1/2 v2] fdmap(2) Alexey Dobriyan
2017-09-24 20:08 ` [PATCH v2 2/2] pidmap(2) Alexey Dobriyan
2017-09-24 21:27 ` Andy Lutomirski
2017-09-26 18:46 ` Alexey Dobriyan
2017-09-27 15:04 ` Andy Lutomirski
2017-09-25 7:43 ` Michael Kerrisk (man-pages)
2017-09-25 10:47 ` Djalal Harouni
2017-09-26 5:44 ` kbuild test robot
2017-09-24 21:31 ` [PATCH 1/2 v2] fdmap(2) Andy Lutomirski
2017-09-26 18:43 ` Alexey Dobriyan
2017-09-25 7:42 ` Michael Kerrisk (man-pages)
2017-09-26 19:00 ` Alexey Dobriyan
2017-09-27 15:03 ` Andy Lutomirski
2017-09-28 7:26 ` Michael Kerrisk (man-pages)
2017-09-28 10:55 ` Alexey Dobriyan
2017-09-28 15:02 ` Andy Lutomirski
2017-10-11 17:37 ` Alexey Dobriyan
2017-09-28 10:10 ` Alexey Dobriyan
2017-10-23 9:29 ` Pavel Machek [this message]
2017-10-25 12:45 ` Alexey Dobriyan
2017-10-25 13:48 ` Pavel Machek
2017-09-26 4:25 ` kbuild test robot
2017-10-10 22:08 ` [1/2,v2] fdmap(2) Andrei Vagin
2017-10-11 18:12 ` Alexey Dobriyan
2017-10-12 8:06 ` Andrei Vagin
2017-10-18 11:35 ` Alexey Dobriyan
2017-10-18 17:47 ` Andy Lutomirski
2017-10-19 15:34 ` Alexey Dobriyan
2017-10-20 7:48 ` Greg KH
2017-10-25 13:11 ` Alexey Dobriyan
2017-10-26 7:53 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171023092938.GC32228@amd \
--to=pavel@ucw.cz \
--cc=Aliaksandr_Patseyenak1@epam.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gladkov.alexey@gmail.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
--cc=tixxdz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).