From: Alexey Dobriyan <adobriyan@gmail.com>
To: Andrei Vagin <avagin@virtuozzo.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org, rdunlap@infradead.org,
tglx@linutronix.de, tixxdz@gmail.com, gladkov.alexey@gmail.com
Subject: Re: [1/2,v2] fdmap(2)
Date: Wed, 18 Oct 2017 13:35:00 +0200 [thread overview]
Message-ID: <CACVxJT_ZP=VAJQ_=D1JV0yt3bT_RZjtWTW61KcV5gCbhF8ixBw@mail.gmail.com> (raw)
In-Reply-To: <20171012080608.GA23077@outlook.office365.com>
On 10/12/17, Andrei Vagin <avagin@virtuozzo.com> wrote:
> I'm agree with your points, but I think you choose a wrong set of data
> to make an example of a new approach.
>
> You are talking a lot about statx, but for me it is unclear how fdmap
> follows the idea of statx. Let's imagine that I want to extend fdmap to
> return mnt_id for each file descriptor?
fdmap() is standalone thing.
Next step is to design fdinfo(2) (?) which uses descriptors from fdmap(2).
Extending structures is done as usual: but version, add new fields to the end.
> Or it may be more complex case, when we decided to provide all data
> from /proc/pid/fdinfo/X for each descriptor. A set of fields in fdinfo
> depends on a type of a file descriptor, it is different for epoll,
> signalfd, inotify, sockets, etc.
>
> For inotify file descriptors, there are information about all watches,
> so it is not possible to use a fixed size struture to present this data.
Now I didn't look closely at inotify watches but this is done with unions,
zero-length trailing arrays, and other usual stuff. If OpenVZ/Virtuozzo is
doing C/R of inotify then you already have all serializing code.
next prev parent reply other threads:[~2017-10-18 11:35 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-24 20:06 [PATCH 1/2 v2] fdmap(2) Alexey Dobriyan
2017-09-24 20:08 ` [PATCH v2 2/2] pidmap(2) Alexey Dobriyan
2017-09-24 21:27 ` Andy Lutomirski
2017-09-26 18:46 ` Alexey Dobriyan
2017-09-27 15:04 ` Andy Lutomirski
2017-09-25 7:43 ` Michael Kerrisk (man-pages)
2017-09-25 10:47 ` Djalal Harouni
2017-09-26 5:44 ` kbuild test robot
2017-09-24 21:31 ` [PATCH 1/2 v2] fdmap(2) Andy Lutomirski
2017-09-26 18:43 ` Alexey Dobriyan
2017-09-25 7:42 ` Michael Kerrisk (man-pages)
2017-09-26 19:00 ` Alexey Dobriyan
2017-09-27 15:03 ` Andy Lutomirski
2017-09-28 7:26 ` Michael Kerrisk (man-pages)
2017-09-28 10:55 ` Alexey Dobriyan
2017-09-28 15:02 ` Andy Lutomirski
2017-10-11 17:37 ` Alexey Dobriyan
2017-09-28 10:10 ` Alexey Dobriyan
2017-10-23 9:29 ` Pavel Machek
2017-10-25 12:45 ` Alexey Dobriyan
2017-10-25 13:48 ` Pavel Machek
2017-09-26 4:25 ` kbuild test robot
2017-10-10 22:08 ` [1/2,v2] fdmap(2) Andrei Vagin
2017-10-11 18:12 ` Alexey Dobriyan
2017-10-12 8:06 ` Andrei Vagin
2017-10-18 11:35 ` Alexey Dobriyan [this message]
2017-10-18 17:47 ` Andy Lutomirski
2017-10-19 15:34 ` Alexey Dobriyan
2017-10-20 7:48 ` Greg KH
2017-10-25 13:11 ` Alexey Dobriyan
2017-10-26 7:53 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACVxJT_ZP=VAJQ_=D1JV0yt3bT_RZjtWTW61KcV5gCbhF8ixBw@mail.gmail.com' \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=avagin@virtuozzo.com \
--cc=gladkov.alexey@gmail.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
--cc=tixxdz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).