From: Andy Lutomirski <luto@amacapital.net>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux API <linux-api@vger.kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Djalal Harouni <tixxdz@gmail.com>,
Alexey Gladkov <gladkov.alexey@gmail.com>,
Aliaksandr Patseyenak <Aliaksandr_Patseyenak1@epam.com>,
Tatsiana Brouka <Tatsiana_Brouka@epam.com>
Subject: Re: [PATCH 1/2 v2] fdmap(2)
Date: Wed, 27 Sep 2017 08:03:42 -0700 [thread overview]
Message-ID: <CALCETrWTTe2X6O5HQMWJC84yXNBJ+eERJoDZMowq8X1L0q7pEQ@mail.gmail.com> (raw)
In-Reply-To: <20170926190018.GA30898@avx2>
On Tue, Sep 26, 2017 at 12:00 PM, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> On Mon, Sep 25, 2017 at 09:42:58AM +0200, Michael Kerrisk (man-pages) wrote:
>> [Not sure why original author is not in CC; added]
>>
>> Hello Alexey,
>>
>> On 09/24/2017 10:06 PM, Alexey Dobriyan wrote:
>> > From: Aliaksandr Patseyenak <Aliaksandr_Patseyenak1@epam.com>
>> >
>> > Implement system call for bulk retrieveing of opened descriptors
>> > in binary form.
>> >
>> > Some daemons could use it to reliably close file descriptors
>> > before starting. Currently they close everything upto some number
>> > which formally is not reliable. Other natural users are lsof(1) and CRIU
>> > (although lsof does so much in /proc that the effect is thoroughly buried).
>> >
>> > /proc, the only way to learn anything about file descriptors may not be
>> > available. There is unavoidable overhead associated with instantiating
>> > 3 dentries and 3 inodes and converting integers to strings and back.
>> >
>> > Benchmark:
>> >
>> > N=1<<22 times
>> > 4 opened descriptors (0, 1, 2, 3)
>> > opendir+readdir+closedir /proc/self/fd vs fdmap
>> >
>> > /proc 8.31 ą 0.37%
>> > fdmap 0.32 ą 0.72%
>>
>> From the text above, I'm still trying to understand: whose problem
>> does this solve? I mean, we've lived with the daemon-close-all-files
>> technique forever (and I'm not sure that performance is really an
>> important issue for the daemon case) .
>
>> And you say that the effect for lsof(1) will be buried.
>
> If only fdmap(2) is added, then effect will be negligible for lsof
> because it has to go through /proc anyway.
>
> The idea is to start process. In ideal world, only bynary system calls
> would exist and shells could emulate /proc/* same way bash implement
> /dev/tcp
Then start the process by doing it for real and making it obviously
useful. We should not add a pair of vaguely useful, rather weak
syscalls just to start a process of modernizing /proc.
>
>> So, who does this new system call
>> really help? (Note: I'm not saying don't add the syscall, but from
>> explanation given here, it's not clear why we should.)
>
> For fdmap(2) natural users are lsof(), CRIU.
lsof does:
int
main(argc, argv)
int argc;
char *argv[];
{
...
if ((MaxFd = (int) GET_MAX_FD()) < 53)
MaxFd = 53;
for (i = 3; i < MaxFd; i++)
(void) close(i);
The solution isn't to wrangle fdmap(2) into this code. The solution
is to remove the code entirely.
next prev parent reply other threads:[~2017-09-27 15:04 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-24 20:06 [PATCH 1/2 v2] fdmap(2) Alexey Dobriyan
2017-09-24 20:08 ` [PATCH v2 2/2] pidmap(2) Alexey Dobriyan
2017-09-24 21:27 ` Andy Lutomirski
2017-09-26 18:46 ` Alexey Dobriyan
2017-09-27 15:04 ` Andy Lutomirski
2017-09-25 7:43 ` Michael Kerrisk (man-pages)
2017-09-25 10:47 ` Djalal Harouni
2017-09-26 5:44 ` kbuild test robot
2017-09-24 21:31 ` [PATCH 1/2 v2] fdmap(2) Andy Lutomirski
2017-09-26 18:43 ` Alexey Dobriyan
2017-09-25 7:42 ` Michael Kerrisk (man-pages)
2017-09-26 19:00 ` Alexey Dobriyan
2017-09-27 15:03 ` Andy Lutomirski [this message]
2017-09-28 7:26 ` Michael Kerrisk (man-pages)
2017-09-28 10:55 ` Alexey Dobriyan
2017-09-28 15:02 ` Andy Lutomirski
2017-10-11 17:37 ` Alexey Dobriyan
2017-09-28 10:10 ` Alexey Dobriyan
2017-10-23 9:29 ` Pavel Machek
2017-10-25 12:45 ` Alexey Dobriyan
2017-10-25 13:48 ` Pavel Machek
2017-09-26 4:25 ` kbuild test robot
2017-10-10 22:08 ` [1/2,v2] fdmap(2) Andrei Vagin
2017-10-11 18:12 ` Alexey Dobriyan
2017-10-12 8:06 ` Andrei Vagin
2017-10-18 11:35 ` Alexey Dobriyan
2017-10-18 17:47 ` Andy Lutomirski
2017-10-19 15:34 ` Alexey Dobriyan
2017-10-20 7:48 ` Greg KH
2017-10-25 13:11 ` Alexey Dobriyan
2017-10-26 7:53 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALCETrWTTe2X6O5HQMWJC84yXNBJ+eERJoDZMowq8X1L0q7pEQ@mail.gmail.com \
--to=luto@amacapital.net \
--cc=Aliaksandr_Patseyenak1@epam.com \
--cc=Tatsiana_Brouka@epam.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gladkov.alexey@gmail.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
--cc=tixxdz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).