* [PATCH] staging: android: ion: remove redundant variable table
@ 2017-10-31 14:02 Colin King
2017-11-01 23:08 ` Laura Abbott
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-10-31 14:02 UTC (permalink / raw)
To: Laura Abbott, Sumit Semwal, Greg Kroah-Hartman,
Arve Hjønnevåg, Riley Andrews, devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable table is being set but is never read, it is therefore
redundant and can be removed. Cleans up clang warning:
drivers/staging/android/ion/ion.c:112:2: warning: Value stored to 'table' is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/staging/android/ion/ion.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
index 93e2c90fa77d..a7d9b0e98572 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -81,7 +81,6 @@ static struct ion_buffer *ion_buffer_create(struct ion_heap *heap,
unsigned long flags)
{
struct ion_buffer *buffer;
- struct sg_table *table;
int ret;
buffer = kzalloc(sizeof(*buffer), GFP_KERNEL);
@@ -109,7 +108,6 @@ static struct ion_buffer *ion_buffer_create(struct ion_heap *heap,
goto err1;
}
- table = buffer->sg_table;
buffer->dev = dev;
buffer->size = len;
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: android: ion: remove redundant variable table
2017-10-31 14:02 [PATCH] staging: android: ion: remove redundant variable table Colin King
@ 2017-11-01 23:08 ` Laura Abbott
0 siblings, 0 replies; 2+ messages in thread
From: Laura Abbott @ 2017-11-01 23:08 UTC (permalink / raw)
To: Colin King, Sumit Semwal, Greg Kroah-Hartman,
Arve Hjønnevåg, Riley Andrews, devel
Cc: kernel-janitors, linux-kernel
On 10/31/2017 07:02 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable table is being set but is never read, it is therefore
> redundant and can be removed. Cleans up clang warning:
>
> drivers/staging/android/ion/ion.c:112:2: warning: Value stored to 'table' is never read
>
Acked-by: Laura Abbott <labbott@redhat.com>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/staging/android/ion/ion.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> index 93e2c90fa77d..a7d9b0e98572 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -81,7 +81,6 @@ static struct ion_buffer *ion_buffer_create(struct ion_heap *heap,
> unsigned long flags)
> {
> struct ion_buffer *buffer;
> - struct sg_table *table;
> int ret;
>
> buffer = kzalloc(sizeof(*buffer), GFP_KERNEL);
> @@ -109,7 +108,6 @@ static struct ion_buffer *ion_buffer_create(struct ion_heap *heap,
> goto err1;
> }
>
> - table = buffer->sg_table;
> buffer->dev = dev;
> buffer->size = len;
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-01 23:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-31 14:02 [PATCH] staging: android: ion: remove redundant variable table Colin King
2017-11-01 23:08 ` Laura Abbott
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).