From: Peter Zijlstra <peterz@infradead.org>
To: Alexei Starovoitov <ast@fb.com>
Cc: Josef Bacik <josef@toxicpanda.com>,
rostedt@goodmis.org, mingo@redhat.com, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
ast@kernel.org, kernel-team@fb.com, daniel@iogearbox.net
Subject: Re: [PATCH 0/2][v5] Add the ability to do BPF directed error injection
Date: Fri, 10 Nov 2017 10:20:46 +0100 [thread overview]
Message-ID: <20171110092046.2mfewtmt6gjzzjs7@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <04fd674a-6921-d2ea-8e89-856397ab297d@fb.com>
On Wed, Nov 08, 2017 at 06:43:25AM +0900, Alexei Starovoitov wrote:
> On 11/8/17 5:28 AM, Josef Bacik wrote:
> > I'm sending this through Dave since it'll conflict with other BPF changes in his
> > tree, but since it touches tracing as well Dave would like a review from
> > somebody on the tracing side.
> >
> > v4->v5:
> > - disallow kprobe_override programs from being put in the prog map array so we
> > don't tail call into something we didn't check. This allows us to make the
> > normal path still fast without a bunch of percpu operations.
>
> looks great to me.
> Peter,
> could you please review x86 bits?
I did not in fact get the patch... But after digging it out of LKML I
don't immediately see something broken, but this is not stuff I
typically know well.
next prev parent reply other threads:[~2017-11-10 9:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 20:28 [PATCH 0/2][v5] Add the ability to do BPF directed error injection Josef Bacik
2017-11-07 20:28 ` [PATCH 1/2] bpf: add a bpf_override_function helper Josef Bacik
2017-11-08 2:28 ` Daniel Borkmann
2017-11-10 9:34 ` Ingo Molnar
2017-11-10 17:14 ` Josef Bacik
2017-11-11 8:14 ` Ingo Molnar
2017-11-11 11:51 ` Josef Bacik
2017-11-12 6:49 ` Alexei Starovoitov
2017-11-12 10:38 ` Ingo Molnar
2017-11-13 15:57 ` Josef Bacik
2017-11-15 7:34 ` Ingo Molnar
2017-11-07 20:28 ` [PATCH 2/2] samples/bpf: add a test for bpf_override_return Josef Bacik
2017-11-08 2:29 ` Daniel Borkmann
2017-11-07 21:43 ` [PATCH 0/2][v5] Add the ability to do BPF directed error injection Alexei Starovoitov
2017-11-10 9:06 ` David Miller
2017-11-10 9:20 ` Peter Zijlstra [this message]
2017-11-11 3:18 ` David Miller
2017-11-11 8:16 ` Ingo Molnar
2017-11-11 9:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171110092046.2mfewtmt6gjzzjs7@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ast@fb.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).