From: Steven Rostedt <rostedt@goodmis.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org,
tglx@linutronix.de, Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH RT] crypto: limit more FPU-enabled sections
Date: Thu, 30 Nov 2017 10:19:43 -0500 [thread overview]
Message-ID: <20171130101943.15f7ade4@gandalf.local.home> (raw)
In-Reply-To: <20171130142216.GB12606@linutronix.de>
On Thu, 30 Nov 2017 15:22:17 +0100
Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> diff --git a/arch/x86/crypto/camellia_aesni_avx2_glue.c b/arch/x86/crypto/camellia_aesni_avx2_glue.c
> index 60907c139c4e..d7502c023475 100644
> --- a/arch/x86/crypto/camellia_aesni_avx2_glue.c
> +++ b/arch/x86/crypto/camellia_aesni_avx2_glue.c
> @@ -206,6 +206,32 @@ struct crypt_priv {
> bool fpu_enabled;
> };
>
> +static void camellia_fpu_end_rt(struct crypt_priv *ctx)
> +{
> +#if CONFIG_PREEMPT_RT_FULL
> + bool fpu_enabled = ctx->fpu_enabled;
> +
> + if (!fpu_enabled)
> + return;
> + camellia_fpu_end(fpu_enabled);
> + ctx->fpu_enabled = false;
> +#endif
> +}
> +
> +static void camellia_fpu_sched_rt(struct crypt_priv *ctx)
> +{
> +#if CONFIG_PREEMPT_RT_FULL
> + bool fpu_enabled = ctx->fpu_enabled;
> +
> + if (!fpu_enabled || !tif_need_resched_now())
> + return;
> + camellia_fpu_end(fpu_enabled);
> + kernel_fpu_end();
> + /* schedule due to preemptible */
> + kernel_fpu_begin();
> +#endif
> +}
I think it would be cleaner to do:
#ifdef CONFIG_PREEMPT_RT_FULL
static void camellia_fpu_end_rt(struct crypt_priv *ctx)
{
bool fpu_enabled = ctx->fpu_enabled;
if (!fpu_enabled)
return;
camellia_fpu_end(fpu_enabled);
ctx->fpu_enabled = false;
}
static void camellia_fpu_sched_rt(struct crypt_priv *ctx)
{
bool fpu_enabled = ctx->fpu_enabled;
if (!fpu_enabled || !tif_need_resched_now())
return;
camellia_fpu_end(fpu_enabled);
kernel_fpu_end();
/* schedule due to preemptible */
kernel_fpu_begin();
}
#else
static inline void camellia_fpu_end_rt(struct crypt_priv *ctx) { }
static void camellia_fpu_sched_rt(struct crypt_priv *ctx) { }
#endif
It really shows that these functions are only used by RT. IMO it's bad
taste to have functions with the entire body encapsulated in #ifdefs.
And the same goes for the other functions in this patch.
-- Steve
next prev parent reply other threads:[~2017-11-30 15:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 14:22 [PATCH RT] crypto: limit more FPU-enabled sections Sebastian Andrzej Siewior
2017-11-30 14:30 ` Sebastian Andrzej Siewior
2017-12-01 10:43 ` [PATCH RT] arm*: disable NEON in kernel mode Sebastian Andrzej Siewior
2017-12-01 13:45 ` Sebastian Andrzej Siewior
2017-12-01 14:18 ` Mark Rutland
2017-12-01 14:36 ` Sebastian Andrzej Siewior
2017-12-01 15:03 ` Ard Biesheuvel
2017-12-01 17:58 ` Dave Martin
2017-12-01 18:08 ` Russell King - ARM Linux
2017-12-01 18:24 ` Dave Martin
2017-12-01 19:20 ` Ard Biesheuvel
2017-12-04 9:21 ` Sebastian Andrzej Siewior
2017-12-01 17:14 ` Peter Zijlstra
2017-12-01 17:31 ` Russell King - ARM Linux
2017-12-01 17:39 ` Peter Zijlstra
2017-11-30 15:19 ` Steven Rostedt [this message]
2017-11-30 15:22 ` [PATCH RT] crypto: limit more FPU-enabled sections Sebastian Andrzej Siewior
2017-12-01 10:44 ` [PATCH RT v2] " Sebastian Andrzej Siewior
2017-12-01 11:32 ` Peter Zijlstra
2017-12-01 13:32 ` Sebastian Andrzej Siewior
2017-12-01 13:44 ` Peter Zijlstra
2017-12-01 13:50 ` Sebastian Andrzej Siewior
2017-12-01 14:03 ` [PATCH RT v3] " Sebastian Andrzej Siewior
2017-11-30 15:29 ` [PATCH RT] " Steven Rostedt
2017-11-30 15:41 ` Sebastian Andrzej Siewior
2017-11-30 16:18 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171130101943.15f7ade4@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).