From: Mark Rutland <mark.rutland@arm.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-rt-users@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
tglx@linutronix.de, linux-arm-kernel@lists.infradead.org,
ard.biesheuvel@linaro.org
Subject: Re: [PATCH RT] arm*: disable NEON in kernel mode
Date: Fri, 1 Dec 2017 14:18:28 +0000 [thread overview]
Message-ID: <20171201141827.yip6pl3tt7kxzek7@lakrids.cambridge.arm.com> (raw)
In-Reply-To: <20171201134506.GF1612@linutronix.de>
[Adding Ard, who wrote the NEON crypto code]
On Fri, Dec 01, 2017 at 02:45:06PM +0100, Sebastian Andrzej Siewior wrote:
> +arm folks, to let you know
>
> On 2017-12-01 11:43:32 [+0100], To linux-rt-users@vger.kernel.org wrote:
> > NEON in kernel mode is used by the crypto algorithms and raid6 code.
> > While the raid6 code looks okay, the crypto algorithms do not: NEON
> > is enabled on first invocation and may allocate/free/map memory before
> > the NEON mode is disabled again.
Could you elaborate on why this is a problem?
I guess this is because kernel_neon_{begin,end}() disable preemption?
... is this specific to RT?
Thanks,
Mark.
> > This needs to be changed until it can be enabled.
> > On ARM NEON in kernel mode can be simply disabled. on ARM64 it needs to
> > stay on due to possible EFI callbacks so here I disable each algorithm.
> >
> > Cc: stable-rt@vger.kernel.org
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> > ---
> > arch/arm/Kconfig | 2 +-
> > arch/arm64/crypto/Kconfig | 20 ++++++++++----------
> > arch/arm64/crypto/crc32-ce-glue.c | 3 ++-
> > 3 files changed, 13 insertions(+), 12 deletions(-)
> >
> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > index d1346a160760..914fecb088a8 100644
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -2164,7 +2164,7 @@ config NEON
> >
> > config KERNEL_MODE_NEON
> > bool "Support for NEON in kernel mode"
> > - depends on NEON && AEABI
> > + depends on NEON && AEABI && !PREEMPT_RT_BASE
> > help
> > Say Y to include support for NEON in kernel mode.
> >
> > diff --git a/arch/arm64/crypto/Kconfig b/arch/arm64/crypto/Kconfig
> > index 70c517aa4501..2a5f05b5a19a 100644
> > --- a/arch/arm64/crypto/Kconfig
> > +++ b/arch/arm64/crypto/Kconfig
> > @@ -19,19 +19,19 @@ config CRYPTO_SHA512_ARM64
> >
> > config CRYPTO_SHA1_ARM64_CE
> > tristate "SHA-1 digest algorithm (ARMv8 Crypto Extensions)"
> > - depends on KERNEL_MODE_NEON
> > + depends on KERNEL_MODE_NEON && !PREEMPT_RT_BASE
> > select CRYPTO_HASH
> > select CRYPTO_SHA1
> >
> > config CRYPTO_SHA2_ARM64_CE
> > tristate "SHA-224/SHA-256 digest algorithm (ARMv8 Crypto Extensions)"
> > - depends on KERNEL_MODE_NEON
> > + depends on KERNEL_MODE_NEON && !PREEMPT_RT_BASE
> > select CRYPTO_HASH
> > select CRYPTO_SHA256_ARM64
> >
> > config CRYPTO_GHASH_ARM64_CE
> > tristate "GHASH/AES-GCM using ARMv8 Crypto Extensions"
> > - depends on KERNEL_MODE_NEON
> > + depends on KERNEL_MODE_NEON && !PREEMPT_RT_BASE
> > select CRYPTO_HASH
> > select CRYPTO_GF128MUL
> > select CRYPTO_AES
> > @@ -39,7 +39,7 @@ config CRYPTO_GHASH_ARM64_CE
> >
> > config CRYPTO_CRCT10DIF_ARM64_CE
> > tristate "CRCT10DIF digest algorithm using PMULL instructions"
> > - depends on KERNEL_MODE_NEON && CRC_T10DIF
> > + depends on KERNEL_MODE_NEON && CRC_T10DIF && !PREEMPT_RT_BASE
> > select CRYPTO_HASH
> >
> > config CRYPTO_CRC32_ARM64_CE
> > @@ -53,13 +53,13 @@ config CRYPTO_AES_ARM64
> >
> > config CRYPTO_AES_ARM64_CE
> > tristate "AES core cipher using ARMv8 Crypto Extensions"
> > - depends on ARM64 && KERNEL_MODE_NEON
> > + depends on ARM64 && KERNEL_MODE_NEON && !PREEMPT_RT_BASE
> > select CRYPTO_ALGAPI
> > select CRYPTO_AES_ARM64
> >
> > config CRYPTO_AES_ARM64_CE_CCM
> > tristate "AES in CCM mode using ARMv8 Crypto Extensions"
> > - depends on ARM64 && KERNEL_MODE_NEON
> > + depends on ARM64 && KERNEL_MODE_NEON && !PREEMPT_RT_BASE
> > select CRYPTO_ALGAPI
> > select CRYPTO_AES_ARM64_CE
> > select CRYPTO_AES_ARM64
> > @@ -67,7 +67,7 @@ config CRYPTO_AES_ARM64_CE_CCM
> >
> > config CRYPTO_AES_ARM64_CE_BLK
> > tristate "AES in ECB/CBC/CTR/XTS modes using ARMv8 Crypto Extensions"
> > - depends on KERNEL_MODE_NEON
> > + depends on KERNEL_MODE_NEON && !PREEMPT_RT_BASE
> > select CRYPTO_BLKCIPHER
> > select CRYPTO_AES_ARM64_CE
> > select CRYPTO_AES_ARM64
> > @@ -75,7 +75,7 @@ config CRYPTO_AES_ARM64_CE_BLK
> >
> > config CRYPTO_AES_ARM64_NEON_BLK
> > tristate "AES in ECB/CBC/CTR/XTS modes using NEON instructions"
> > - depends on KERNEL_MODE_NEON
> > + depends on KERNEL_MODE_NEON && !PREEMPT_RT_BASE
> > select CRYPTO_BLKCIPHER
> > select CRYPTO_AES_ARM64
> > select CRYPTO_AES
> > @@ -83,13 +83,13 @@ config CRYPTO_AES_ARM64_NEON_BLK
> >
> > config CRYPTO_CHACHA20_NEON
> > tristate "NEON accelerated ChaCha20 symmetric cipher"
> > - depends on KERNEL_MODE_NEON
> > + depends on KERNEL_MODE_NEON && !PREEMPT_RT_BASE
> > select CRYPTO_BLKCIPHER
> > select CRYPTO_CHACHA20
> >
> > config CRYPTO_AES_ARM64_BS
> > tristate "AES in ECB/CBC/CTR/XTS modes using bit-sliced NEON algorithm"
> > - depends on KERNEL_MODE_NEON
> > + depends on KERNEL_MODE_NEON && !PREEMPT_RT_BASE
> > select CRYPTO_BLKCIPHER
> > select CRYPTO_AES_ARM64_NEON_BLK
> > select CRYPTO_AES_ARM64
> > diff --git a/arch/arm64/crypto/crc32-ce-glue.c b/arch/arm64/crypto/crc32-ce-glue.c
> > index 624f4137918c..599de95cd86d 100644
> > --- a/arch/arm64/crypto/crc32-ce-glue.c
> > +++ b/arch/arm64/crypto/crc32-ce-glue.c
> > @@ -206,7 +206,8 @@ static struct shash_alg crc32_pmull_algs[] = { {
> >
> > static int __init crc32_pmull_mod_init(void)
> > {
> > - if (IS_ENABLED(CONFIG_KERNEL_MODE_NEON) && (elf_hwcap & HWCAP_PMULL)) {
> > + if (IS_ENABLED(CONFIG_KERNEL_MODE_NEON) &&
> > + !IS_ENABLED(CONFIG_PREEMPT_RT_BASE) && (elf_hwcap & HWCAP_PMULL)) {
> > crc32_pmull_algs[0].update = crc32_pmull_update;
> > crc32_pmull_algs[1].update = crc32c_pmull_update;
> >
> > --
> > 2.15.0
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2017-12-01 14:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 14:22 [PATCH RT] crypto: limit more FPU-enabled sections Sebastian Andrzej Siewior
2017-11-30 14:30 ` Sebastian Andrzej Siewior
2017-12-01 10:43 ` [PATCH RT] arm*: disable NEON in kernel mode Sebastian Andrzej Siewior
2017-12-01 13:45 ` Sebastian Andrzej Siewior
2017-12-01 14:18 ` Mark Rutland [this message]
2017-12-01 14:36 ` Sebastian Andrzej Siewior
2017-12-01 15:03 ` Ard Biesheuvel
2017-12-01 17:58 ` Dave Martin
2017-12-01 18:08 ` Russell King - ARM Linux
2017-12-01 18:24 ` Dave Martin
2017-12-01 19:20 ` Ard Biesheuvel
2017-12-04 9:21 ` Sebastian Andrzej Siewior
2017-12-01 17:14 ` Peter Zijlstra
2017-12-01 17:31 ` Russell King - ARM Linux
2017-12-01 17:39 ` Peter Zijlstra
2017-11-30 15:19 ` [PATCH RT] crypto: limit more FPU-enabled sections Steven Rostedt
2017-11-30 15:22 ` Sebastian Andrzej Siewior
2017-12-01 10:44 ` [PATCH RT v2] " Sebastian Andrzej Siewior
2017-12-01 11:32 ` Peter Zijlstra
2017-12-01 13:32 ` Sebastian Andrzej Siewior
2017-12-01 13:44 ` Peter Zijlstra
2017-12-01 13:50 ` Sebastian Andrzej Siewior
2017-12-01 14:03 ` [PATCH RT v3] " Sebastian Andrzej Siewior
2017-11-30 15:29 ` [PATCH RT] " Steven Rostedt
2017-11-30 15:41 ` Sebastian Andrzej Siewior
2017-11-30 16:18 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171201141827.yip6pl3tt7kxzek7@lakrids.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=bigeasy@linutronix.de \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).