linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@ziepe.ca>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org,
	jiangshanlai@gmail.com, dipankar@in.ibm.com,
	akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
	josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org,
	rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com,
	fweisbec@gmail.com, oleg@redhat.com,
	Doug Ledford <dledford@redhat.com>,
	Richard Henderson <rth@twiddle.net>,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	Matt Turner <mattst88@gmail.com>,
	Michael Cree <mcree@orcon.net.nz>,
	Andrea Parri <parri.andrea@gmail.com>,
	linux-rdma@vger.kernel.org, linux-alpha@vger.kernel.org
Subject: Re: [PATCH tip/core/rcu 16/21] drivers/infiniband: Remove now-redundant smp_read_barrier_depends()
Date: Fri, 1 Dec 2017 17:11:09 -0700	[thread overview]
Message-ID: <20171202001109.GQ7754@ziepe.ca> (raw)
In-Reply-To: <1512157876-24665-16-git-send-email-paulmck@linux.vnet.ibm.com>

On Fri, Dec 01, 2017 at 11:51:11AM -0800, Paul E. McKenney wrote:
> The smp_read_barrier_depends() does nothing at all except on DEC Alpha,
> and no current DEC Alpha systems use Infiniband:
> 
> 	lkml.kernel.org/r/20171023085921.jwbntptn6ictbnvj@tower

I understand DEC Alpha has PCI, and we continue to support several
RDMA devices that used the PCI bus.

However, the hif1, rdma vt and qib drivers modified in this patch are
PCI-Express ONLY. So I think this idea is fine, but would revise the
commit message to focus on PCI-E not Infiniband.

>  drivers/dma/ioat/dma.c              | 2 --
>  drivers/infiniband/Kconfig          | 1 +

Did you mean to have ioat/dma.c in this patch?

Jason

  reply	other threads:[~2017-12-02  0:11 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-01 19:50 [PATCH tip/core/rcu 0/21] De-emphasize {smp_,}read_barrier_depends Paul E. McKenney
2017-12-01 19:50 ` [PATCH tip/core/rcu 01/21] doc: READ_ONCE() now implies smp_barrier_depends() Paul E. McKenney
2017-12-01 19:50 ` [PATCH tip/core/rcu 02/21] mn10300: READ_ONCE() now implies smp_read_barrier_depends() Paul E. McKenney
2017-12-01 19:50 ` [PATCH tip/core/rcu 03/21] drivers/net/ethernet/qlogic/qed: Fix __qed_spq_block() ordering Paul E. McKenney
2017-12-01 19:50 ` [PATCH tip/core/rcu 04/21] fs/dcache: Use release-acquire for name/length update Paul E. McKenney
2017-12-01 19:51 ` [PATCH tip/core/rcu 05/21] percpu: READ_ONCE() now implies smp_read_barrier_depends() Paul E. McKenney
2017-12-01 19:51 ` [PATCH tip/core/rcu 06/21] rcu: Adjust read-side accessor comments for READ_ONCE() Paul E. McKenney
2017-12-01 19:51 ` [PATCH tip/core/rcu 07/21] rtnetlink: Update now-misleading smp_read_barrier_depends() comment Paul E. McKenney
2017-12-01 19:51 ` [PATCH tip/core/rcu 08/21] seqlock: Remove now-redundant smp_read_barrier_depends() Paul E. McKenney
2017-12-01 19:51 ` [PATCH tip/core/rcu 09/21] uprobes: " Paul E. McKenney
2017-12-01 19:51 ` [PATCH tip/core/rcu 10/21] locking: Remove smp_read_barrier_depends() from queued_spin_lock_slowpath() Paul E. McKenney
2017-12-01 19:51 ` [PATCH tip/core/rcu 11/21] tracepoint: Remove smp_read_barrier_depends() from comment Paul E. McKenney
2017-12-01 19:51 ` [PATCH tip/core/rcu 12/21] lib/assoc_array: Remove smp_read_barrier_depends() Paul E. McKenney
2017-12-01 19:51 ` [PATCH tip/core/rcu 13/21] mm/ksm: Remove now-redundant smp_read_barrier_depends() Paul E. McKenney
2017-12-01 19:51 ` [PATCH tip/core/rcu 14/21] netfilter: " Paul E. McKenney
2017-12-01 19:51 ` [PATCH tip/core/rcu 15/21] keyring: " Paul E. McKenney
2017-12-04  0:59   ` James Morris
2017-12-04 18:54     ` Paul E. McKenney
2017-12-01 19:51 ` [PATCH tip/core/rcu 16/21] drivers/infiniband: " Paul E. McKenney
2017-12-02  0:11   ` Jason Gunthorpe [this message]
2017-12-02  1:08     ` Paul E. McKenney
2017-12-05 15:08       ` Jason Gunthorpe
2017-12-05 20:06         ` Paul E. McKenney
2017-12-01 19:51 ` [PATCH tip/core/rcu 17/21] doc: De-emphasize smp_read_barrier_depends Paul E. McKenney
2017-12-01 19:51 ` [PATCH tip/core/rcu 18/21] genetlink: Remove smp_read_barrier_depends() from comment Paul E. McKenney
2017-12-01 19:51 ` [PATCH tip/core/rcu 19/21] netlink: " Paul E. McKenney
2017-12-01 19:51 ` [PATCH tip/core/rcu 20/21] checkpatch: Add warnings for {smp_,}read_barrier_depends() Paul E. McKenney
2017-12-01 20:14   ` Joe Perches
2017-12-01 21:44     ` Paul E. McKenney
2017-12-02  4:45       ` Joe Perches
2017-12-04 19:06         ` Paul E. McKenney
2017-12-04 19:12           ` Joe Perches
2017-12-01 19:51 ` [PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends() Paul E. McKenney
2017-12-05 18:31   ` Michael S. Tsirkin
2017-12-05 18:39     ` Peter Zijlstra
2017-12-05 18:57       ` Michael S. Tsirkin
2017-12-05 19:17         ` Peter Zijlstra
2017-12-05 19:24           ` Michael S. Tsirkin
2017-12-05 19:33             ` Paul E. McKenney
2017-12-05 19:51               ` Michael S. Tsirkin
2017-12-05 19:57                 ` Peter Zijlstra
2017-12-05 20:28                   ` Michael S. Tsirkin
2017-12-05 21:17                     ` Peter Zijlstra
2017-12-05 21:42                       ` Michael S. Tsirkin
2017-12-05 20:08                 ` Paul E. McKenney
2017-12-05 21:24                   ` Michael S. Tsirkin
2017-12-05 21:36                     ` Paul E. McKenney
2017-12-05 21:43                       ` Michael S. Tsirkin
2017-12-05 22:02                         ` Paul E. McKenney
2017-12-05 22:09                       ` Peter Zijlstra
2017-12-05 21:57                     ` Peter Zijlstra
2017-12-05 22:09                       ` Michael S. Tsirkin
2017-12-05 23:39                         ` Paul E. McKenney
2017-12-05 19:55             ` Peter Zijlstra
2017-12-04 15:38 ` [PATCH tip/core/rcu 01/21] doc: READ_ONCE() now implies smp_barrier_depends() David Howells
2017-12-04 18:52   ` Paul E. McKenney
2017-12-04 21:54     ` Peter Zijlstra
2017-12-04 22:15       ` Paul E. McKenney
2017-12-04 22:39     ` David Howells
2017-12-04 22:57       ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171202001109.GQ7754@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=dipankar@in.ibm.com \
    --cc=dledford@redhat.com \
    --cc=edumazet@google.com \
    --cc=fweisbec@gmail.com \
    --cc=ink@jurassic.park.msu.ru \
    --cc=jiangshanlai@gmail.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mattst88@gmail.com \
    --cc=mcree@orcon.net.nz \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    --cc=parri.andrea@gmail.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=rth@twiddle.net \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).