* [PATCH] asus-wireless: send an EV_SYN/SYN_REPORT between state changes
@ 2017-12-04 0:26 Peter Hutterer
2017-12-09 0:10 ` Darren Hart
0 siblings, 1 reply; 2+ messages in thread
From: Peter Hutterer @ 2017-12-04 0:26 UTC (permalink / raw)
To: Corentin Chary, João Paulo Rechi Vita, Darren Hart,
Andy Shevchenko, acpi4asus-user, platform-driver-x86
Cc: linux-kernel
Sending the switch state change twice within the same frame is invalid evdev
protocol and only works if the client handles keys immediately as well.
Processing events immediately is incorrect, it forces a fake order of events
that does not exist on the device.
Recent versions of libinput changed to only process the device state and
SYN_REPORT time, so now the key event is lost.
https://bugs.freedesktop.org/show_bug.cgi?id=104041
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
---
drivers/platform/x86/asus-wireless.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c
index f3796164329e..d4aeac3477f5 100644
--- a/drivers/platform/x86/asus-wireless.c
+++ b/drivers/platform/x86/asus-wireless.c
@@ -118,6 +118,7 @@ static void asus_wireless_notify(struct acpi_device *adev, u32 event)
return;
}
input_report_key(data->idev, KEY_RFKILL, 1);
+ input_sync(data->idev);
input_report_key(data->idev, KEY_RFKILL, 0);
input_sync(data->idev);
}
--
2.13.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] asus-wireless: send an EV_SYN/SYN_REPORT between state changes
2017-12-04 0:26 [PATCH] asus-wireless: send an EV_SYN/SYN_REPORT between state changes Peter Hutterer
@ 2017-12-09 0:10 ` Darren Hart
0 siblings, 0 replies; 2+ messages in thread
From: Darren Hart @ 2017-12-09 0:10 UTC (permalink / raw)
To: Peter Hutterer
Cc: Corentin Chary, João Paulo Rechi Vita, Andy Shevchenko,
acpi4asus-user, platform-driver-x86, linux-kernel
On Mon, Dec 04, 2017 at 10:26:17AM +1000, Peter Hutterer wrote:
> Sending the switch state change twice within the same frame is invalid evdev
> protocol and only works if the client handles keys immediately as well.
> Processing events immediately is incorrect, it forces a fake order of events
> that does not exist on the device.
>
> Recent versions of libinput changed to only process the device state and
> SYN_REPORT time, so now the key event is lost.
>
> https://bugs.freedesktop.org/show_bug.cgi?id=104041
>
> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Thanks Peter, queued.
--
Darren Hart
VMware Open Source Technology Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-09 0:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-04 0:26 [PATCH] asus-wireless: send an EV_SYN/SYN_REPORT between state changes Peter Hutterer
2017-12-09 0:10 ` Darren Hart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).