From: Mark Rutland <mark.rutland@arm.com>
To: Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
Lee@lakrids.cambridge.arm.com, Chun-Yi <jlee@suse.com>,
Borislav Petkov <bp@alien8.de>, Tony Luck <tony.luck@intel.com>,
Will Deacon <will.deacon@arm.com>,
Dave Hansen <dave.hansen@intel.com>,
Bhupesh Sharma <bhsharma@redhat.com>,
Ricardo Neri <ricardo.neri@intel.com>,
Ravi Shankar <ravi.v.shankar@intel.com>,
Matt Fleming <matt@codeblueprint.co.uk>,
Peter Zijlstra <peter.zijlstra@intel.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH V2 2/3] efi: Introduce efi_rts_workqueue and some infrastructure to invoke all efi_runtime_services()
Date: Tue, 6 Mar 2018 11:13:41 +0000 [thread overview]
Message-ID: <20180306111339.xjrugce553f2egzh@lakrids.cambridge.arm.com> (raw)
In-Reply-To: <1520292190-5027-3-git-send-email-sai.praneeth.prakhya@intel.com>
On Mon, Mar 05, 2018 at 03:23:09PM -0800, Sai Praneeth Prakhya wrote:
> @@ -329,6 +331,19 @@ static int __init efisubsys_init(void)
> return 0;
>
> /*
> + * Since we process only one efi_runtime_service() at a time, an
> + * ordered workqueue (which creates only one execution context)
> + * should suffice all our needs.
> + */
> + efi_rts_wq = alloc_ordered_workqueue("efi_rts_workqueue", 0);
> + if (!efi_rts_wq) {
> + pr_err("Failed to create efi_rts_workqueue, EFI runtime services "
> + "disabled.\n");
> + clear_bit(EFI_RUNTIME_SERVICES, &efi.flags);
> + return 0;
> + }
I'm a little worried that something might sample this flag between it
being set in an early_initcall (arm_enable_runtime_services), and
cleared in a subsys_initcall here.
However, nothing seems to do that so far, so maybe that's ok...
[...]
> +/* efi_runtime_service() function identifiers */
> +enum {
> + GET_TIME,
> + SET_TIME,
> + GET_WAKEUP_TIME,
> + SET_WAKEUP_TIME,
> + GET_VARIABLE,
> + GET_NEXT_VARIABLE,
> + SET_VARIABLE,
> + SET_VARIABLE_NONBLOCKING,
> + QUERY_VARIABLE_INFO,
> + QUERY_VARIABLE_INFO_NONBLOCKING,
> + GET_NEXT_HIGH_MONO_COUNT,
> + RESET_SYSTEM,
> + UPDATE_CAPSULE,
> + QUERY_CAPSULE_CAPS,
> +};
Can we please give this enum a name....
[...]
> +/*
> + * efi_runtime_work: Details of EFI Runtime Service work
> + * @func: EFI Runtime Service function identifier
> + * @arg<1-5>: EFI Runtime Service function arguments
> + * @status: Status of executing EFI Runtime Service
> + */
> +struct efi_runtime_work {
> + u8 func;
... and use it here rather than an opaque u8? I realise that means
placing the enum in <linux/efi.h>.
> + void *arg1;
> + void *arg2;
> + void *arg3;
> + void *arg4;
> + void *arg5;
> + efi_status_t status;
> + struct work_struct work;
> +};
Thanks,
Mark.
next prev parent reply other threads:[~2018-03-06 11:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 23:23 [PATCH V2 0/3] Use efi_rts_workqueue to invoke EFI Runtime Services Sai Praneeth Prakhya
2018-03-05 23:23 ` [PATCH V2 1/3] x86/efi: Call efi_delete_dummy_variable() during efi subsystem initialization Sai Praneeth Prakhya
2018-03-08 7:43 ` Ard Biesheuvel
2018-03-08 18:06 ` Prakhya, Sai Praneeth
2018-03-05 23:23 ` [PATCH V2 2/3] efi: Introduce efi_rts_workqueue and some infrastructure to invoke all efi_runtime_services() Sai Praneeth Prakhya
2018-03-06 11:13 ` Mark Rutland [this message]
2018-03-08 4:00 ` Prakhya, Sai Praneeth
2018-03-07 11:55 ` Miguel Ojeda
2018-03-08 4:22 ` Prakhya, Sai Praneeth
2018-03-08 9:12 ` Miguel Ojeda
2018-03-08 18:09 ` Prakhya, Sai Praneeth
2018-03-07 12:11 ` Borislav Petkov
2018-03-08 5:31 ` Prakhya, Sai Praneeth
2018-03-08 14:08 ` Borislav Petkov
2018-03-08 17:05 ` Luck, Tony
2018-03-09 10:57 ` Borislav Petkov
2018-03-09 2:37 ` Prakhya, Sai Praneeth
2018-03-09 11:11 ` Borislav Petkov
2018-03-10 0:33 ` Prakhya, Sai Praneeth
2018-03-14 17:40 ` Borislav Petkov
2018-03-08 5:38 ` Prakhya, Sai Praneeth
2018-03-05 23:23 ` [PATCH V2 3/3] efi: Use efi_rts_workqueue to invoke EFI Runtime Services Sai Praneeth Prakhya
2018-03-06 0:05 ` Dan Williams
2018-03-06 0:56 ` Prakhya, Sai Praneeth
2018-03-06 11:26 ` Mark Rutland
2018-03-08 4:11 ` Prakhya, Sai Praneeth
2018-03-08 4:33 ` Dan Williams
2018-03-08 5:06 ` Prakhya, Sai Praneeth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180306111339.xjrugce553f2egzh@lakrids.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=Lee@lakrids.cambridge.arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=bhsharma@redhat.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=jlee@suse.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=peter.zijlstra@intel.com \
--cc=ravi.v.shankar@intel.com \
--cc=ricardo.neri@intel.com \
--cc=sai.praneeth.prakhya@intel.com \
--cc=tony.luck@intel.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).