From: Borislav Petkov <bp@alien8.de>
To: "Prakhya, Sai Praneeth" <sai.praneeth.prakhya@intel.com>
Cc: "linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Chun-Yi Lee <jlee@suse.com>, "Luck, Tony" <tony.luck@intel.com>,
Will Deacon <will.deacon@arm.com>,
"Hansen, Dave" <dave.hansen@intel.com>,
Mark Rutland <mark.rutland@arm.com>,
Bhupesh Sharma <bhsharma@redhat.com>,
"Neri, Ricardo" <ricardo.neri@intel.com>,
"Shankar, Ravi V" <ravi.v.shankar@intel.com>,
Matt Fleming <matt@codeblueprint.co.uk>,
"Zijlstra, Peter" <peter.zijlstra@intel.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"Williams, Dan J" <dan.j.williams@intel.com>
Subject: Re: [PATCH V2 2/3] efi: Introduce efi_rts_workqueue and some infrastructure to invoke all efi_runtime_services()
Date: Wed, 14 Mar 2018 18:40:27 +0100 [thread overview]
Message-ID: <20180314174027.GF16605@pd.tnic> (raw)
In-Reply-To: <FFF73D592F13FD46B8700F0A279B802F2E5821F9@ORSMSX114.amr.corp.intel.com>
On Sat, Mar 10, 2018 at 12:33:35AM +0000, Prakhya, Sai Praneeth wrote:
> Although the discussions were off my understanding, the present issue
> I see is, (and also the motivation for me to do the patch is) when a
> thread tries to execute any efi_runtime_service() we switch to efi_pgd
> (which doesn't have user space mappings) and all other subsystems in
> kernel aren't aware of this switch. This looks like a perfect case for
> kthread.
That's all fine and good but you need to be prepared and handle properly
an NMI while EFI is running.
I have no clue whether the platform delays delivery of NMIs during EFI
runtime services or whatever happens but you need to have all those
cases covered so that no monkey business happens.
Thx.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2018-03-14 17:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 23:23 [PATCH V2 0/3] Use efi_rts_workqueue to invoke EFI Runtime Services Sai Praneeth Prakhya
2018-03-05 23:23 ` [PATCH V2 1/3] x86/efi: Call efi_delete_dummy_variable() during efi subsystem initialization Sai Praneeth Prakhya
2018-03-08 7:43 ` Ard Biesheuvel
2018-03-08 18:06 ` Prakhya, Sai Praneeth
2018-03-05 23:23 ` [PATCH V2 2/3] efi: Introduce efi_rts_workqueue and some infrastructure to invoke all efi_runtime_services() Sai Praneeth Prakhya
2018-03-06 11:13 ` Mark Rutland
2018-03-08 4:00 ` Prakhya, Sai Praneeth
2018-03-07 11:55 ` Miguel Ojeda
2018-03-08 4:22 ` Prakhya, Sai Praneeth
2018-03-08 9:12 ` Miguel Ojeda
2018-03-08 18:09 ` Prakhya, Sai Praneeth
2018-03-07 12:11 ` Borislav Petkov
2018-03-08 5:31 ` Prakhya, Sai Praneeth
2018-03-08 14:08 ` Borislav Petkov
2018-03-08 17:05 ` Luck, Tony
2018-03-09 10:57 ` Borislav Petkov
2018-03-09 2:37 ` Prakhya, Sai Praneeth
2018-03-09 11:11 ` Borislav Petkov
2018-03-10 0:33 ` Prakhya, Sai Praneeth
2018-03-14 17:40 ` Borislav Petkov [this message]
2018-03-08 5:38 ` Prakhya, Sai Praneeth
2018-03-05 23:23 ` [PATCH V2 3/3] efi: Use efi_rts_workqueue to invoke EFI Runtime Services Sai Praneeth Prakhya
2018-03-06 0:05 ` Dan Williams
2018-03-06 0:56 ` Prakhya, Sai Praneeth
2018-03-06 11:26 ` Mark Rutland
2018-03-08 4:11 ` Prakhya, Sai Praneeth
2018-03-08 4:33 ` Dan Williams
2018-03-08 5:06 ` Prakhya, Sai Praneeth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180314174027.GF16605@pd.tnic \
--to=bp@alien8.de \
--cc=ard.biesheuvel@linaro.org \
--cc=bhsharma@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=jlee@suse.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matt@codeblueprint.co.uk \
--cc=peter.zijlstra@intel.com \
--cc=ravi.v.shankar@intel.com \
--cc=ricardo.neri@intel.com \
--cc=sai.praneeth.prakhya@intel.com \
--cc=tony.luck@intel.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).