From: Christian Brauner <christian.brauner@mailbox.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Andy Lutomirski <luto@kernel.org>,
Tycho Andersen <tycho@tycho.ws>,
Kees Cook <keescook@chromium.org>,
Linux Containers <containers@lists.linux-foundation.org>,
Akihiro Suda <suda.akihiro@lab.ntt.co.jp>,
LKML <linux-kernel@vger.kernel.org>,
Oleg Nesterov <oleg@redhat.com>,
Christian Brauner <christian.brauner@canonical.com>,
"Eric W . Biederman" <ebiederm@xmission.com>,
Christian Brauner <christian.brauner@ubuntu.com>,
Tyler Hicks <tyhicks@canonical.com>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>
Subject: Re: [RFC 0/3] seccomp trap to userspace
Date: Fri, 16 Mar 2018 17:40:48 +0100 [thread overview]
Message-ID: <20180316164048.GA30454@mailbox.org> (raw)
In-Reply-To: <D73E5C37-DC92-4D58-A163-0B20143AAEEB@amacapital.net>
On Fri, Mar 16, 2018 at 09:01:47AM -0700, Andy Lutomirski wrote:
>
>
> > On Mar 16, 2018, at 7:47 AM, Christian Brauner <christian.brauner@mailbox.org> wrote:
> >
> >> On Fri, Mar 16, 2018 at 12:46:55AM +0000, Andy Lutomirski wrote:
>
>
> I bet I confused everyone with a blatant typo:
>
> >>
> >> Hmm, I think we have to be very careful to avoid nasty races. I think
> >> the correct approach is to notice the signal and send a message to the
> >> listener that a signal is pending but to take no additional action.
> >> If the handler ends up completing the syscall with a successful
> >> return, we don't want to replace it with -EINTR. IOW the code looks
> >> kind of like:
> >>
> >> send_to_listener("hey I got a signal");
>
> That should be “hey I got a syscall”. D’oh!
Ha ok, that's what led me to believe that listener != handler and I was
trying to make sense of thise. :)
Thanks!
Christian
>
> >> wait_ret = wait_interruptible for the listener to reply;
> >> if (wait_ret == -EINTR) {
> >
> > Hm, so from the pseudo-code it looks like: The handler would inform the
> > listener that it received a signal (either from the syscall requester or
> > from somewhere else) and then wait for the listener to reply to that
> > message. This would allow the listener to decide what action it wants
> > the handler to take based on the signal, i.e. either cancel the request
> > or retry? The comment makes it sound like that the handler doesn't
> > really wait on the listener when it receives a signal it simply moves
> > on.
>
> It keeps waiting killably but not interruptibly.
>
> > So no "taking no additional action" here means not have the handler
> > decide to abort but the listener?
>
> If by “handler” you mean kernel, then yes.
>
> There’s no userspace syscall handler involved. From the kernel’s perspective, a syscall is never still in progress when a signal handler is invoked — we only actually invoke syscall handlers in prepare_exit_to_usermode() or the non-x86 equivalent and the functions it calls. While a syscall is running, the kernel might notice that a signal is pending and do one of a few things:
>
> 1. Just keep going. Not all syscalls can be interrupted.
>
> 2. Try to finish early. If a send() call has already sent some but not all data, it can stop waiting and return the number of bytes sent.
>
> 3. Abort with -EINTR.
>
> 4. Abort with -ERESTARTSYS or one of its relatives. These fiddle with user registers in a somewhat unpleasant way to pretend that the syscall never actually happened. This works for syscalls that wait with an absolute timeout, for example.
>
> 5. Set up restart_syscall() magic, rewrite regs so it looks like the user was about to call restart_syscall() when the signal happened, and abort.
>
> In all cases, the signal is dealt with afterwards. This could result in changing regs to call the handler or in simply returning.
>
> 1-3 should work fully in seccomp. The only issue is that the kernel doesn’t know *which* to do, nor can the kernel force the listener to abort cleanly, so I think we have no real choice but to let the listener decide.
>
> 4 could be supported just like 1-3. 5 is awful, and I don’t think we should support it for user listeners.
prev parent reply other threads:[~2018-03-16 16:40 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-04 10:49 [RFC 0/3] seccomp trap to userspace Tycho Andersen
2018-02-04 10:49 ` [RFC 1/3] seccomp: add a return code to " Tycho Andersen
2018-02-04 17:36 ` Andy Lutomirski
2018-02-04 20:01 ` Tycho Andersen
2018-02-04 20:33 ` Andy Lutomirski
2018-02-05 8:47 ` Tycho Andersen
2018-02-13 21:09 ` Kees Cook
2018-02-14 15:29 ` Tycho Andersen
2018-02-14 17:19 ` Andy Lutomirski
2018-02-14 17:23 ` Tycho Andersen
2018-02-15 14:48 ` Christian Brauner
2018-02-27 0:49 ` Kees Cook
2018-02-27 3:27 ` Andy Lutomirski
2018-02-04 10:49 ` [RFC 2/3] seccomp: hoist out filter resolving logic Tycho Andersen
2018-02-13 21:29 ` Kees Cook
2018-02-14 15:33 ` Tycho Andersen
2018-02-04 10:49 ` [RFC 3/3] seccomp: add a way to get a listener fd from ptrace Tycho Andersen
2018-02-13 21:32 ` Kees Cook
2018-02-14 15:33 ` Tycho Andersen
2018-03-15 16:09 ` [RFC 0/3] seccomp trap to userspace Christian Brauner
2018-03-15 16:56 ` Andy Lutomirski
2018-03-15 17:05 ` Serge E. Hallyn
2018-03-15 17:11 ` Andy Lutomirski
2018-03-15 17:25 ` Christian Brauner
2018-03-15 17:30 ` Andy Lutomirski
2018-03-15 17:35 ` Tycho Andersen
2018-03-16 0:46 ` Andy Lutomirski
2018-03-16 14:47 ` Christian Brauner
2018-03-16 16:01 ` Andy Lutomirski
2018-03-16 16:40 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180316164048.GA30454@mailbox.org \
--to=christian.brauner@mailbox.org \
--cc=alexei.starovoitov@gmail.com \
--cc=christian.brauner@canonical.com \
--cc=christian.brauner@ubuntu.com \
--cc=containers@lists.linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=oleg@redhat.com \
--cc=suda.akihiro@lab.ntt.co.jp \
--cc=tycho@tycho.ws \
--cc=tyhicks@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).