* [PATCH] mtd: Replace typedef with struct
@ 2018-03-18 17:51 Arushi Singhal
2018-03-27 19:32 ` Richard Weinberger
0 siblings, 1 reply; 3+ messages in thread
From: Arushi Singhal @ 2018-03-18 17:51 UTC (permalink / raw)
To: dwmw2
Cc: Brian Norris, Boris Brezillon, Marek Vasut, Richard Weinberger,
Cyrille Pitchen, linux-mtd, linux-kernel
Using typedef for a structure type is not suggested in Linux kernel
coding style guidelines. Hence, occurrence of typedefs has been
removed.
Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
drivers/mtd/ssfdc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mtd/ssfdc.c b/drivers/mtd/ssfdc.c
index 95f0bf9..8bae672 100644
--- a/drivers/mtd/ssfdc.c
+++ b/drivers/mtd/ssfdc.c
@@ -54,15 +54,15 @@ SumSector 2,000 4,000 8,000 16,000 32,000 64,000 128,000 256,000
SectorSize 512 512 512 512 512 512 512 512
**/
-typedef struct {
+struct chs_entry {
unsigned long size;
unsigned short cyl;
unsigned char head;
unsigned char sec;
-} chs_entry_t;
+};
/* Must be ordered by size */
-static const chs_entry_t chs_table[] = {
+static const struct chs_entry chs_table[] = {
{ MiB( 1), 125, 4, 4 },
{ MiB( 2), 125, 4, 8 },
{ MiB( 4), 250, 4, 8 },
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: Replace typedef with struct
2018-03-18 17:51 [PATCH] mtd: Replace typedef with struct Arushi Singhal
@ 2018-03-27 19:32 ` Richard Weinberger
2018-03-28 7:16 ` Boris Brezillon
0 siblings, 1 reply; 3+ messages in thread
From: Richard Weinberger @ 2018-03-27 19:32 UTC (permalink / raw)
To: Arushi Singhal
Cc: dwmw2, Brian Norris, Boris Brezillon, Marek Vasut,
Cyrille Pitchen, linux-mtd, linux-kernel
Am Sonntag, 18. März 2018, 18:51:23 CEST schrieb Arushi Singhal:
> Using typedef for a structure type is not suggested in Linux kernel
> coding style guidelines. Hence, occurrence of typedefs has been
> removed.
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
> drivers/mtd/ssfdc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/ssfdc.c b/drivers/mtd/ssfdc.c
> index 95f0bf9..8bae672 100644
> --- a/drivers/mtd/ssfdc.c
> +++ b/drivers/mtd/ssfdc.c
> @@ -54,15 +54,15 @@ SumSector 2,000 4,000 8,000 16,000 32,000 64,000 128,000 256,000
> SectorSize 512 512 512 512 512 512 512 512
> **/
>
> -typedef struct {
> +struct chs_entry {
> unsigned long size;
> unsigned short cyl;
> unsigned char head;
> unsigned char sec;
> -} chs_entry_t;
> +};
>
> /* Must be ordered by size */
> -static const chs_entry_t chs_table[] = {
> +static const struct chs_entry chs_table[] = {
> { MiB( 1), 125, 4, 4 },
> { MiB( 2), 125, 4, 8 },
> { MiB( 4), 250, 4, 8 },
>
Didn't we already talk about coding style fixes on existing code? ;-)
Thanks,
//richard
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: Replace typedef with struct
2018-03-27 19:32 ` Richard Weinberger
@ 2018-03-28 7:16 ` Boris Brezillon
0 siblings, 0 replies; 3+ messages in thread
From: Boris Brezillon @ 2018-03-28 7:16 UTC (permalink / raw)
To: Arushi Singhal
Cc: Richard Weinberger, dwmw2, Brian Norris, Boris Brezillon,
Marek Vasut, Cyrille Pitchen, linux-mtd, linux-kernel
On Tue, 27 Mar 2018 21:32:19 +0200
Richard Weinberger <richard@nod.at> wrote:
> Am Sonntag, 18. März 2018, 18:51:23 CEST schrieb Arushi Singhal:
> > Using typedef for a structure type is not suggested in Linux kernel
> > coding style guidelines. Hence, occurrence of typedefs has been
> > removed.
> >
> > Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> > ---
> > drivers/mtd/ssfdc.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/mtd/ssfdc.c b/drivers/mtd/ssfdc.c
> > index 95f0bf9..8bae672 100644
> > --- a/drivers/mtd/ssfdc.c
> > +++ b/drivers/mtd/ssfdc.c
> > @@ -54,15 +54,15 @@ SumSector 2,000 4,000 8,000 16,000 32,000 64,000 128,000 256,000
> > SectorSize 512 512 512 512 512 512 512 512
> > **/
> >
> > -typedef struct {
> > +struct chs_entry {
> > unsigned long size;
> > unsigned short cyl;
> > unsigned char head;
> > unsigned char sec;
> > -} chs_entry_t;
> > +};
> >
> > /* Must be ordered by size */
> > -static const chs_entry_t chs_table[] = {
> > +static const struct chs_entry chs_table[] = {
> > { MiB( 1), 125, 4, 4 },
> > { MiB( 2), 125, 4, 8 },
> > { MiB( 4), 250, 4, 8 },
> >
>
> Didn't we already talk about coding style fixes on existing code? ;-)
I'll add one thing to Richard's complaint: please stop sending new
coding style or cosmetic changes until the previous ones have been
accepted.
There's a reason I don't apply those patches right away even though
they are simple. Those patches have a low priority in my review list
and improvements or fixes usually get reviewed before them. The reason
I do that is:
1/ I want to reward contributors who submit things that actually matter
to the subsystem
2/ It tends to discourage drive-by contributors whose only interest is
to get a lot of trivial patches in the kernel
Note that I'm not saying never, but you have to accept to wait longer
for this kind of patches, and more importantly, if you keep sending
only coding style patches, we might decide to ignore your contributions
at some point.
Regards,
Boris
--
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-28 7:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-18 17:51 [PATCH] mtd: Replace typedef with struct Arushi Singhal
2018-03-27 19:32 ` Richard Weinberger
2018-03-28 7:16 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).