From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Sergey Suloev <ssuloev@orpaltech.com>
Cc: Mark Brown <broonie@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/6] spi: sun6i: introduce register set/unset helpers
Date: Wed, 4 Apr 2018 09:02:15 +0200 [thread overview]
Message-ID: <20180404070215.matr7snuyxjd7syu@flea> (raw)
In-Reply-To: <20180403154449.2443-6-ssuloev@orpaltech.com>
[-- Attachment #1: Type: text/plain, Size: 484 bytes --]
On Tue, Apr 03, 2018 at 06:44:48PM +0300, Sergey Suloev wrote:
> Two helper functions were added in order to set/unset
> specified flags in registers.
>
> Signed-off-by: Sergey Suloev <ssuloev@orpaltech.com>
Again, I'm not really sure what the benefit of that is. Your diffstat
is pretty much identical, so it's basically just moving code around.
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-04-04 7:02 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 15:44 [PATCH v3 0/6] spi: Add support for DMA transfers in sun6i SPI driver Sergey Suloev
2018-04-03 15:44 ` [PATCH v3 1/6] spi: sun6i: coding style/readability improvements Sergey Suloev
2018-04-04 6:45 ` Maxime Ripard
2018-04-03 15:44 ` [PATCH v3 2/6] spi: sun6i: handle chip select polarity flag Sergey Suloev
2018-04-03 15:44 ` [PATCH v3 3/6] spi: sun6i: restrict transfer length in PIO-mode Sergey Suloev
2018-04-04 6:50 ` Maxime Ripard
2018-04-04 11:35 ` Sergey Suloev
2018-04-05 9:19 ` Maxime Ripard
2018-04-05 9:59 ` Sergey Suloev
2018-04-05 13:17 ` Mark Brown
2018-04-05 13:44 ` Sergey Suloev
2018-04-06 7:34 ` Maxime Ripard
2018-04-06 15:48 ` Sergey Suloev
2018-04-09 9:27 ` Maxime Ripard
2018-04-09 10:26 ` Sergey Suloev
2018-04-09 10:50 ` Mark Brown
2018-04-09 11:10 ` Sergey Suloev
2018-04-09 11:27 ` Mark Brown
2018-04-09 11:36 ` Maxime Ripard
2018-04-09 11:59 ` Sergey Suloev
2018-04-10 14:05 ` Maxime Ripard
2018-04-06 15:54 ` Sergey Suloev
2018-04-05 10:07 ` Mark Brown
2018-04-03 15:44 ` [PATCH v3 4/6] spi: sun6i: use completion provided by SPI core Sergey Suloev
2018-04-04 6:53 ` Maxime Ripard
2018-04-03 15:44 ` [PATCH v3 5/6] spi: sun6i: introduce register set/unset helpers Sergey Suloev
2018-04-04 1:32 ` kbuild test robot
2018-04-04 7:02 ` Maxime Ripard [this message]
2018-04-03 15:44 ` [PATCH v3 6/6] spi: sun6i: add DMA transfers support Sergey Suloev
2018-04-04 7:00 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180404070215.matr7snuyxjd7syu@flea \
--to=maxime.ripard@bootlin.com \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=ssuloev@orpaltech.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).