* [PATCH] serial: imx: enable IMX21_UCR3_RXDMUXSEL for non-dte-mode
@ 2018-04-20 1:07 Chris Ruehl
2018-04-20 6:13 ` Uwe Kleine-König
0 siblings, 1 reply; 6+ messages in thread
From: Chris Ruehl @ 2018-04-20 1:07 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, linux-serial, linux-kernel; +Cc: Chris Ruehl
Fix a problem introduced with
commit e61c38d85b73 ("serial: imx: setup DCEDTE early and ensure DCD and RI irqs to be off")
result in non dte-mode imx-uart fail receive data.
By add back IMX21_UCR3_RXDMUXSEL the serial port works as expected.
Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
---
drivers/tty/serial/imx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index 91f3a1a..3d09933 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -1391,7 +1391,7 @@ static int imx_uart_startup(struct uart_port *port)
ucr3 = imx_uart_readl(sport, UCR3);
- ucr3 |= UCR3_DTRDEN | UCR3_RI | UCR3_DCD;
+ ucr3 |= IMX21_UCR3_RXDMUXSEL | UCR3_DTRDEN | UCR3_RI | UCR3_DCD;
if (sport->dte_mode)
/* disable broken interrupts */
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] serial: imx: enable IMX21_UCR3_RXDMUXSEL for non-dte-mode
2018-04-20 1:07 [PATCH] serial: imx: enable IMX21_UCR3_RXDMUXSEL for non-dte-mode Chris Ruehl
@ 2018-04-20 6:13 ` Uwe Kleine-König
2018-04-20 8:56 ` Chris Ruehl
2018-05-03 6:13 ` Chris Ruehl
0 siblings, 2 replies; 6+ messages in thread
From: Uwe Kleine-König @ 2018-04-20 6:13 UTC (permalink / raw)
To: Chris Ruehl; +Cc: Greg Kroah-Hartman, Jiri Slaby, linux-serial, linux-kernel
Hello Chris,
On Fri, Apr 20, 2018 at 09:07:59AM +0800, Chris Ruehl wrote:
> Fix a problem introduced with
> commit e61c38d85b73 ("serial: imx: setup DCEDTE early and ensure DCD and RI irqs to be off")
> result in non dte-mode imx-uart fail receive data.
> By add back IMX21_UCR3_RXDMUXSEL the serial port works as expected.
>
> Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
> ---
> drivers/tty/serial/imx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
> index 91f3a1a..3d09933 100644
> --- a/drivers/tty/serial/imx.c
> +++ b/drivers/tty/serial/imx.c
> @@ -1391,7 +1391,7 @@ static int imx_uart_startup(struct uart_port *port)
>
> ucr3 = imx_uart_readl(sport, UCR3);
>
> - ucr3 |= UCR3_DTRDEN | UCR3_RI | UCR3_DCD;
> + ucr3 |= IMX21_UCR3_RXDMUXSEL | UCR3_DTRDEN | UCR3_RI | UCR3_DCD;
>
> if (sport->dte_mode)
> /* disable broken interrupts */
Doesn't 6df765dca378bddf994cfd2044acafa501bd800f fix this for you?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] serial: imx: enable IMX21_UCR3_RXDMUXSEL for non-dte-mode
2018-04-20 6:13 ` Uwe Kleine-König
@ 2018-04-20 8:56 ` Chris Ruehl
2018-05-03 6:13 ` Chris Ruehl
1 sibling, 0 replies; 6+ messages in thread
From: Chris Ruehl @ 2018-04-20 8:56 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Greg Kroah-Hartman, Jiri Slaby, linux-serial, linux-kernel
On Friday, April 20, 2018 02:13 PM, Uwe Kleine-König wrote:
> Hello Chris,
>
> On Fri, Apr 20, 2018 at 09:07:59AM +0800, Chris Ruehl wrote:
>> Fix a problem introduced with
>> commit e61c38d85b73 ("serial: imx: setup DCEDTE early and ensure DCD and RI irqs to be off")
>> result in non dte-mode imx-uart fail receive data.
>> By add back IMX21_UCR3_RXDMUXSEL the serial port works as expected.
>>
>> Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
>> ---
>> drivers/tty/serial/imx.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
>> index 91f3a1a..3d09933 100644
>> --- a/drivers/tty/serial/imx.c
>> +++ b/drivers/tty/serial/imx.c
>> @@ -1391,7 +1391,7 @@ static int imx_uart_startup(struct uart_port *port)
>>
>> ucr3 = imx_uart_readl(sport, UCR3);
>>
>> - ucr3 |= UCR3_DTRDEN | UCR3_RI | UCR3_DCD;
>> + ucr3 |= IMX21_UCR3_RXDMUXSEL | UCR3_DTRDEN | UCR3_RI | UCR3_DCD;
>>
>> if (sport->dte_mode)
>> /* disable broken interrupts */
>
> Doesn't 6df765dca378bddf994cfd2044acafa501bd800f fix this for you?
>
> Best regards
> Uwe
>
Uwe,
the patch you point out would fix that problem from what I can see.
But it not yet at the linux-next and since the error persists for 4.9.89
to present I filed a patch simple patch which fix my system.
Let me apply your patch and see if all works well then I fine to drop my
one liner.
Chris
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] serial: imx: enable IMX21_UCR3_RXDMUXSEL for non-dte-mode
2018-04-20 6:13 ` Uwe Kleine-König
2018-04-20 8:56 ` Chris Ruehl
@ 2018-05-03 6:13 ` Chris Ruehl
2018-05-03 20:13 ` Greg Kroah-Hartman
1 sibling, 1 reply; 6+ messages in thread
From: Chris Ruehl @ 2018-05-03 6:13 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Uwe Kleine-König, Jiri Slaby, linux-serial, linux-kernel
Hi Greg,
On Friday, April 20, 2018 02:13 PM, Uwe Kleine-König wrote:
> Hello Chris,
>
> On Fri, Apr 20, 2018 at 09:07:59AM +0800, Chris Ruehl wrote:
>> Fix a problem introduced with
>> commit e61c38d85b73 ("serial: imx: setup DCEDTE early and ensure DCD and RI irqs to be off")
>> result in non dte-mode imx-uart fail receive data.
>> By add back IMX21_UCR3_RXDMUXSEL the serial port works as expected.
>>
>> Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
>> ---
>> drivers/tty/serial/imx.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
>> index 91f3a1a..3d09933 100644
>> --- a/drivers/tty/serial/imx.c
>> +++ b/drivers/tty/serial/imx.c
>> @@ -1391,7 +1391,7 @@ static int imx_uart_startup(struct uart_port *port)
>>
>> ucr3 = imx_uart_readl(sport, UCR3);
>>
>> - ucr3 |= UCR3_DTRDEN | UCR3_RI | UCR3_DCD;
>> + ucr3 |= IMX21_UCR3_RXDMUXSEL | UCR3_DTRDEN | UCR3_RI | UCR3_DCD;
>>
>> if (sport->dte_mode)
>> /* disable broken interrupts */
>
> Doesn't 6df765dca378bddf994cfd2044acafa501bd800f fix this for you?
>
> Best regards
> Uwe
>
The IMX serial driver is broken in the 4.9.x tree since 4.9.89.
Uwe's patch
6df765dca378bddf994cfd2044acafa501bd800f
please apply to clear the situation.
I know you very busy! -
Chris
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] serial: imx: enable IMX21_UCR3_RXDMUXSEL for non-dte-mode
2018-05-03 6:13 ` Chris Ruehl
@ 2018-05-03 20:13 ` Greg Kroah-Hartman
2018-05-04 3:59 ` Chris Ruehl
0 siblings, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2018-05-03 20:13 UTC (permalink / raw)
To: Chris Ruehl; +Cc: Uwe Kleine-König, Jiri Slaby, linux-serial, linux-kernel
On Thu, May 03, 2018 at 02:13:53PM +0800, Chris Ruehl wrote:
> Hi Greg,
>
> On Friday, April 20, 2018 02:13 PM, Uwe Kleine-König wrote:
> > Hello Chris,
> >
> > On Fri, Apr 20, 2018 at 09:07:59AM +0800, Chris Ruehl wrote:
> > > Fix a problem introduced with
> > > commit e61c38d85b73 ("serial: imx: setup DCEDTE early and ensure DCD and RI irqs to be off")
> > > result in non dte-mode imx-uart fail receive data.
> > > By add back IMX21_UCR3_RXDMUXSEL the serial port works as expected.
> > >
> > > Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
> > > ---
> > > drivers/tty/serial/imx.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
> > > index 91f3a1a..3d09933 100644
> > > --- a/drivers/tty/serial/imx.c
> > > +++ b/drivers/tty/serial/imx.c
> > > @@ -1391,7 +1391,7 @@ static int imx_uart_startup(struct uart_port *port)
> > > ucr3 = imx_uart_readl(sport, UCR3);
> > > - ucr3 |= UCR3_DTRDEN | UCR3_RI | UCR3_DCD;
> > > + ucr3 |= IMX21_UCR3_RXDMUXSEL | UCR3_DTRDEN | UCR3_RI | UCR3_DCD;
> > > if (sport->dte_mode)
> > > /* disable broken interrupts */
> >
> > Doesn't 6df765dca378bddf994cfd2044acafa501bd800f fix this for you?
> >
> > Best regards
> > Uwe
> >
>
> The IMX serial driver is broken in the 4.9.x tree since 4.9.89.
> Uwe's patch
>
> 6df765dca378bddf994cfd2044acafa501bd800f
>
> please apply to clear the situation.
>
> I know you very busy! -
It's best to email stable@vger.kernel.org for stuff like this, as I
almost missed it...
Now queued up.
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] serial: imx: enable IMX21_UCR3_RXDMUXSEL for non-dte-mode
2018-05-03 20:13 ` Greg Kroah-Hartman
@ 2018-05-04 3:59 ` Chris Ruehl
0 siblings, 0 replies; 6+ messages in thread
From: Chris Ruehl @ 2018-05-04 3:59 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Uwe Kleine-König, Jiri Slaby, linux-serial, linux-kernel
>>
>> The IMX serial driver is broken in the 4.9.x tree since 4.9.89.
>> Uwe's patch
>>
>> 6df765dca378bddf994cfd2044acafa501bd800f
>>
>> please apply to clear the situation.
>>
>> I know you very busy! -
>
> It's best to email stable@vger.kernel.org for stuff like this, as I
> almost missed it...
>
> Now queued up.
>
> greg k-h
Thanks!
will follow up and cc the stable@ next time.
Chris
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-05-04 3:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-20 1:07 [PATCH] serial: imx: enable IMX21_UCR3_RXDMUXSEL for non-dte-mode Chris Ruehl
2018-04-20 6:13 ` Uwe Kleine-König
2018-04-20 8:56 ` Chris Ruehl
2018-05-03 6:13 ` Chris Ruehl
2018-05-03 20:13 ` Greg Kroah-Hartman
2018-05-04 3:59 ` Chris Ruehl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).