* [PATCH] elf: don't hash userspace addresses
@ 2018-05-04 21:23 Alexey Dobriyan
2018-05-05 0:31 ` Tetsuo Handa
0 siblings, 1 reply; 5+ messages in thread
From: Alexey Dobriyan @ 2018-05-04 21:23 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel, mhocko, penguin-kernel
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
fs/binfmt_elf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/fs/binfmt_elf.c
+++ b/fs/binfmt_elf.c
@@ -379,8 +379,8 @@ static unsigned long elf_map(struct file *filep, unsigned long addr,
if ((type & MAP_FIXED_NOREPLACE) &&
PTR_ERR((void *)map_addr) == -EEXIST)
- pr_info("%d (%s): Uhuuh, elf segment at %px requested but the memory is mapped already\n",
- task_pid_nr(current), current->comm, (void *)addr);
+ pr_info("%d (%s): Uhuuh, elf segment at %lx requested but the memory is mapped already\n",
+ task_pid_nr(current), current->comm, addr);
return(map_addr);
}
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] elf: don't hash userspace addresses
2018-05-04 21:23 [PATCH] elf: don't hash userspace addresses Alexey Dobriyan
@ 2018-05-05 0:31 ` Tetsuo Handa
2018-05-05 12:32 ` Alexey Dobriyan
0 siblings, 1 reply; 5+ messages in thread
From: Tetsuo Handa @ 2018-05-05 0:31 UTC (permalink / raw)
To: adobriyan, akpm; +Cc: linux-kernel, mhocko
Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>
> fs/binfmt_elf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/fs/binfmt_elf.c
> +++ b/fs/binfmt_elf.c
> @@ -379,8 +379,8 @@ static unsigned long elf_map(struct file *filep, unsigned long addr,
>
> if ((type & MAP_FIXED_NOREPLACE) &&
> PTR_ERR((void *)map_addr) == -EEXIST)
> - pr_info("%d (%s): Uhuuh, elf segment at %px requested but the memory is mapped already\n",
> - task_pid_nr(current), current->comm, (void *)addr);
> + pr_info("%d (%s): Uhuuh, elf segment at %lx requested but the memory is mapped already\n",
> + task_pid_nr(current), current->comm, addr);
"%px" does not hash. For what reason you replace %px with %lx ?
>
> return(map_addr);
> }
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] elf: don't hash userspace addresses
2018-05-05 0:31 ` Tetsuo Handa
@ 2018-05-05 12:32 ` Alexey Dobriyan
2018-05-05 13:19 ` Tetsuo Handa
0 siblings, 1 reply; 5+ messages in thread
From: Alexey Dobriyan @ 2018-05-05 12:32 UTC (permalink / raw)
To: Tetsuo Handa; +Cc: akpm, linux-kernel, mhocko
On Sat, May 05, 2018 at 09:31:50AM +0900, Tetsuo Handa wrote:
> Alexey Dobriyan wrote:
> > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> > ---
> >
> > fs/binfmt_elf.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > --- a/fs/binfmt_elf.c
> > +++ b/fs/binfmt_elf.c
> > @@ -379,8 +379,8 @@ static unsigned long elf_map(struct file *filep, unsigned long addr,
> >
> > if ((type & MAP_FIXED_NOREPLACE) &&
> > PTR_ERR((void *)map_addr) == -EEXIST)
> > - pr_info("%d (%s): Uhuuh, elf segment at %px requested but the memory is mapped already\n",
> > - task_pid_nr(current), current->comm, (void *)addr);
> > + pr_info("%d (%s): Uhuuh, elf segment at %lx requested but the memory is mapped already\n",
> > + task_pid_nr(current), current->comm, addr);
>
> "%px" does not hash. For what reason you replace %px with %lx ?
Duh. There is no reason to use non-standard %px.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] elf: don't hash userspace addresses
2018-05-05 12:32 ` Alexey Dobriyan
@ 2018-05-05 13:19 ` Tetsuo Handa
2018-05-09 16:40 ` Alexey Dobriyan
0 siblings, 1 reply; 5+ messages in thread
From: Tetsuo Handa @ 2018-05-05 13:19 UTC (permalink / raw)
To: adobriyan; +Cc: akpm, linux-kernel, mhocko
Alexey Dobriyan wrote:
> On Sat, May 05, 2018 at 09:31:50AM +0900, Tetsuo Handa wrote:
> > Alexey Dobriyan wrote:
> > > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> > > ---
> > >
> > > fs/binfmt_elf.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > --- a/fs/binfmt_elf.c
> > > +++ b/fs/binfmt_elf.c
> > > @@ -379,8 +379,8 @@ static unsigned long elf_map(struct file *filep, unsigned long addr,
> > >
> > > if ((type & MAP_FIXED_NOREPLACE) &&
> > > PTR_ERR((void *)map_addr) == -EEXIST)
> > > - pr_info("%d (%s): Uhuuh, elf segment at %px requested but the memory is mapped already\n",
> > > - task_pid_nr(current), current->comm, (void *)addr);
> > > + pr_info("%d (%s): Uhuuh, elf segment at %lx requested but the memory is mapped already\n",
> > > + task_pid_nr(current), current->comm, addr);
> >
> > "%px" does not hash. For what reason you replace %px with %lx ?
>
> Duh. There is no reason to use non-standard %px.
>
See the comment for pointer() function in lib/vsprintf.c .
In Linux kernel world, various extension for %p is supported.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] elf: don't hash userspace addresses
2018-05-05 13:19 ` Tetsuo Handa
@ 2018-05-09 16:40 ` Alexey Dobriyan
0 siblings, 0 replies; 5+ messages in thread
From: Alexey Dobriyan @ 2018-05-09 16:40 UTC (permalink / raw)
To: Tetsuo Handa; +Cc: akpm, linux-kernel, mhocko
On Sat, May 05, 2018 at 10:19:43PM +0900, Tetsuo Handa wrote:
> Alexey Dobriyan wrote:
> > On Sat, May 05, 2018 at 09:31:50AM +0900, Tetsuo Handa wrote:
> > > Alexey Dobriyan wrote:
> > > > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> > > > ---
> > > >
> > > > fs/binfmt_elf.c | 4 ++--
> > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > --- a/fs/binfmt_elf.c
> > > > +++ b/fs/binfmt_elf.c
> > > > @@ -379,8 +379,8 @@ static unsigned long elf_map(struct file *filep, unsigned long addr,
> > > >
> > > > if ((type & MAP_FIXED_NOREPLACE) &&
> > > > PTR_ERR((void *)map_addr) == -EEXIST)
> > > > - pr_info("%d (%s): Uhuuh, elf segment at %px requested but the memory is mapped already\n",
> > > > - task_pid_nr(current), current->comm, (void *)addr);
> > > > + pr_info("%d (%s): Uhuuh, elf segment at %lx requested but the memory is mapped already\n",
> > > > + task_pid_nr(current), current->comm, addr);
> > >
> > > "%px" does not hash. For what reason you replace %px with %lx ?
> >
> > Duh. There is no reason to use non-standard %px.
> >
>
> See the comment for pointer() function in lib/vsprintf.c .
> In Linux kernel world, various extension for %p is supported.
%p has this funny property: scanf(printf("%p", ptr)) does not equal %p
because small pointer will become (null) or (errptr) or whatever is
decided in recent vsnprintf thread, therefore the less %p is used
the better.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-05-09 16:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-04 21:23 [PATCH] elf: don't hash userspace addresses Alexey Dobriyan
2018-05-05 0:31 ` Tetsuo Handa
2018-05-05 12:32 ` Alexey Dobriyan
2018-05-05 13:19 ` Tetsuo Handa
2018-05-09 16:40 ` Alexey Dobriyan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).