From: Joerg Roedel <joro@8bytes.org>
To: Gary R Hook <gary.hook@amd.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU
Date: Tue, 29 May 2018 14:09:38 +0200 [thread overview]
Message-ID: <20180529120938.GK18595@8bytes.org> (raw)
In-Reply-To: <3eefbef8-142e-0a29-3e97-536717f63a98@amd.com>
On Fri, May 18, 2018 at 04:02:46PM -0500, Gary R Hook wrote:
> "Preferred", perhaps. Neither is incorrect. And really, the Makefile/Kconfig
> choice is somewhat separate from the organization issue.
>
> So I've made the changes for this. Now I'm waiting on Joerg to make a
> decision on the code/file organization. I still prefer a separate file for
> the debug fs code.
The Kconfig option looks nicer to me, please use it. Then you can also
put the code into a separate file.
Joerg
prev parent reply other threads:[~2018-05-29 12:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 17:20 [PATCH v7 0/2] Base enablement of IOMMU debugfs support Gary R Hook
2018-05-14 17:20 ` [PATCH v7 1/2] iommu - Enable debugfs exposure of IOMMU driver internals Gary R Hook
2018-05-24 9:18 ` Greg KH
2018-06-05 16:48 ` Gary R Hook
2018-05-14 17:20 ` [PATCH v7 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU Gary R Hook
2018-05-14 17:50 ` Randy Dunlap
2018-05-14 20:00 ` Gary R Hook
2018-05-14 21:00 ` Randy Dunlap
2018-05-15 13:46 ` Joerg Roedel
2018-05-18 15:20 ` Gary R Hook
2018-05-18 16:49 ` Randy Dunlap
2018-05-18 21:02 ` Gary R Hook
2018-05-24 23:51 ` Gary R Hook
2018-05-29 12:09 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180529120938.GK18595@8bytes.org \
--to=joro@8bytes.org \
--cc=gary.hook@amd.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).