From: Randy Dunlap <rdunlap@infradead.org>
To: Gary R Hook <gary.hook@amd.com>, iommu@lists.linux-foundation.org
Cc: joro@8bytes.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU
Date: Mon, 14 May 2018 10:50:29 -0700 [thread overview]
Message-ID: <ba2bb6f7-77ea-4431-af0f-d20c19820d5d@infradead.org> (raw)
In-Reply-To: <152631842907.18929.8819955271544326298.stgit@sosxen2.amd.com>
On 05/14/2018 10:20 AM, Gary R Hook wrote:
> Implement a skeleton framework for debugfs support in the
> AMD IOMMU.
>
> Signed-off-by: Gary R Hook <gary.hook@amd.com>
> ---
> drivers/iommu/Makefile | 5 +++++
> drivers/iommu/amd_iommu_debugfs.c | 39 +++++++++++++++++++++++++++++++++++++
> drivers/iommu/amd_iommu_init.c | 6 ++++--
> drivers/iommu/amd_iommu_proto.h | 6 ++++++
> drivers/iommu/amd_iommu_types.h | 3 +++
> 5 files changed, 57 insertions(+), 2 deletions(-)
> create mode 100644 drivers/iommu/amd_iommu_debugfs.c
>
> diff --git a/drivers/iommu/Makefile b/drivers/iommu/Makefile
> index 74cfbc392862..dd980f7dd8b6 100644
> --- a/drivers/iommu/Makefile
> +++ b/drivers/iommu/Makefile
> @@ -30,3 +30,8 @@ obj-$(CONFIG_EXYNOS_IOMMU) += exynos-iommu.o
> obj-$(CONFIG_FSL_PAMU) += fsl_pamu.o fsl_pamu_domain.o
> obj-$(CONFIG_S390_IOMMU) += s390-iommu.o
> obj-$(CONFIG_QCOM_IOMMU) += qcom_iommu.o
> +
> +# This ensures that only the required files are compiled
> +ifeq ($(CONFIG_IOMMU_DEBUGFS), y)
Most Makefiles don't use a space before the 'y', but since you tested it,
I guess either way works.
But why do this in the Makefile at all? Why not just add another Kconfig
symbol and simplify the Makefile?
> +obj-$(CONFIG_AMD_IOMMU) += amd_iommu_debugfs.o
> +endif
--
~Randy
next prev parent reply other threads:[~2018-05-14 17:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 17:20 [PATCH v7 0/2] Base enablement of IOMMU debugfs support Gary R Hook
2018-05-14 17:20 ` [PATCH v7 1/2] iommu - Enable debugfs exposure of IOMMU driver internals Gary R Hook
2018-05-24 9:18 ` Greg KH
2018-06-05 16:48 ` Gary R Hook
2018-05-14 17:20 ` [PATCH v7 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU Gary R Hook
2018-05-14 17:50 ` Randy Dunlap [this message]
2018-05-14 20:00 ` Gary R Hook
2018-05-14 21:00 ` Randy Dunlap
2018-05-15 13:46 ` Joerg Roedel
2018-05-18 15:20 ` Gary R Hook
2018-05-18 16:49 ` Randy Dunlap
2018-05-18 21:02 ` Gary R Hook
2018-05-24 23:51 ` Gary R Hook
2018-05-29 12:09 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba2bb6f7-77ea-4431-af0f-d20c19820d5d@infradead.org \
--to=rdunlap@infradead.org \
--cc=gary.hook@amd.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).