From: Gary R Hook <gary.hook@amd.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: Randy Dunlap <rdunlap@infradead.org>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU
Date: Fri, 18 May 2018 10:20:39 -0500 [thread overview]
Message-ID: <4041cb33-19a2-5542-4211-1dce51de5e40@amd.com> (raw)
In-Reply-To: <20180515134603.GD18595@8bytes.org>
On 05/15/2018 08:46 AM, Joerg Roedel wrote:
> On Mon, May 14, 2018 at 03:00:50PM -0500, Gary R Hook wrote:
>> This was brought up a few weeks ago in, I believe, version 3 of this patch.
>> That question was discussed (because that's what I did the first time out),
>> and _someone_ _else_ asked about why I didn't just do it the way I've done
>> it here.
>
> You don't have this problem if you put the code in amd_iommu.c in an
> IOMMU_DEBUGFS ifdef.
Of course. My preference, however, is a separate file to avoid size
creep. That's why I've done it this way.
To whit: there have been threads discussing the
advisability/acceptability of using #ifdefs for debug code. My take-away
was to avoid them. Perhaps I misunderstood.
So: I don't understand your comment. Is this an observation, or is it an
imperative statement? I'd like for a maintainer to clearly indicate what
is acceptable, and I'll do it.
next prev parent reply other threads:[~2018-05-18 15:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 17:20 [PATCH v7 0/2] Base enablement of IOMMU debugfs support Gary R Hook
2018-05-14 17:20 ` [PATCH v7 1/2] iommu - Enable debugfs exposure of IOMMU driver internals Gary R Hook
2018-05-24 9:18 ` Greg KH
2018-06-05 16:48 ` Gary R Hook
2018-05-14 17:20 ` [PATCH v7 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU Gary R Hook
2018-05-14 17:50 ` Randy Dunlap
2018-05-14 20:00 ` Gary R Hook
2018-05-14 21:00 ` Randy Dunlap
2018-05-15 13:46 ` Joerg Roedel
2018-05-18 15:20 ` Gary R Hook [this message]
2018-05-18 16:49 ` Randy Dunlap
2018-05-18 21:02 ` Gary R Hook
2018-05-24 23:51 ` Gary R Hook
2018-05-29 12:09 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4041cb33-19a2-5542-4211-1dce51de5e40@amd.com \
--to=gary.hook@amd.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).