* [PATCH] cpufreq: kryo: Add module remove and exit
@ 2018-06-07 20:58 ilia.lin
2018-06-08 4:29 ` Viresh Kumar
2018-06-14 20:42 ` [PATCH v2] " ilia.lin
0 siblings, 2 replies; 7+ messages in thread
From: ilia.lin @ 2018-06-07 20:58 UTC (permalink / raw)
To: Ilia Lin, Ilia Lin, Rafael J . Wysocki, Viresh Kumar
Cc: Arnd Bergmann, Dan Carpenter, linux-pm, linux-kernel
From: Ilia Lin <ilia.lin@gmail.com>
Add device remove and module exit code to make the driver
functioning as a loadable module.
Fixes: ac28927659be (cpufreq: kryo: allow building as a loadable module)
Signed-off-by: Ilia Lin <ilia.lin@gmail.com>
---
drivers/cpufreq/qcom-cpufreq-kryo.c | 24 +++++++++++++++++++++---
1 file changed, 21 insertions(+), 3 deletions(-)
diff --git a/drivers/cpufreq/qcom-cpufreq-kryo.c b/drivers/cpufreq/qcom-cpufreq-kryo.c
index d049fe4b80c4..a08de0253169 100644
--- a/drivers/cpufreq/qcom-cpufreq-kryo.c
+++ b/drivers/cpufreq/qcom-cpufreq-kryo.c
@@ -71,10 +71,10 @@ static enum _msm8996_version __init qcom_cpufreq_kryo_get_msm_id(void)
return version;
}
+struct platform_device *cpufreq_dt_pdev;
static int qcom_cpufreq_kryo_probe(struct platform_device *pdev)
{
struct opp_table *opp_tables[NR_CPUS] = {0};
- struct platform_device *cpufreq_dt_pdev;
enum _msm8996_version msm8996_version;
struct nvmem_cell *speedbin_nvmem;
struct device_node *np;
@@ -115,6 +115,8 @@ static int qcom_cpufreq_kryo_probe(struct platform_device *pdev)
speedbin = nvmem_cell_read(speedbin_nvmem, &len);
nvmem_cell_put(speedbin_nvmem);
+ if (IS_ERR(speedbin))
+ return PTR_ERR(speedbin);
switch (msm8996_version) {
case MSM8996_V3:
@@ -162,8 +164,15 @@ static int qcom_cpufreq_kryo_probe(struct platform_device *pdev)
return ret;
}
+static int qcom_cpufreq_kryo_remove(struct platform_device *pdev)
+{
+ platform_device_unregister(cpufreq_dt_pdev);
+ return 0;
+}
+
static struct platform_driver qcom_cpufreq_kryo_driver = {
.probe = qcom_cpufreq_kryo_probe,
+ .remove = qcom_cpufreq_kryo_remove,
.driver = {
.name = "qcom-cpufreq-kryo",
},
@@ -174,6 +183,7 @@ static const struct of_device_id qcom_cpufreq_kryo_match_list[] __initconst = {
{ .compatible = "qcom,msm8996", },
};
+struct platform_device *kryo_cpufreq_pdev;
/*
* Since the driver depends on smem and nvmem drivers, which may
* return EPROBE_DEFER, all the real activity is done in the probe,
@@ -198,8 +208,9 @@ static int __init qcom_cpufreq_kryo_init(void)
if (unlikely(ret < 0))
return ret;
- ret = PTR_ERR_OR_ZERO(platform_device_register_simple(
- "qcom-cpufreq-kryo", -1, NULL, 0));
+ kryo_cpufreq_pdev = platform_device_register_simple(
+ "qcom-cpufreq-kryo", -1, NULL, 0);
+ ret = PTR_ERR_OR_ZERO(kryo_cpufreq_pdev);
if (0 == ret)
return 0;
@@ -208,5 +219,12 @@ static int __init qcom_cpufreq_kryo_init(void)
}
module_init(qcom_cpufreq_kryo_init);
+static void __init qcom_cpufreq_kryo_exit(void)
+{
+ platform_device_unregister(kryo_cpufreq_pdev);
+ platform_driver_unregister(&qcom_cpufreq_kryo_driver);
+}
+module_exit(qcom_cpufreq_kryo_exit);
+
MODULE_DESCRIPTION("Qualcomm Technologies, Inc. Kryo CPUfreq driver");
MODULE_LICENSE("GPL v2");
--
2.11.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] cpufreq: kryo: Add module remove and exit
2018-06-07 20:58 [PATCH] cpufreq: kryo: Add module remove and exit ilia.lin
@ 2018-06-08 4:29 ` Viresh Kumar
2018-06-14 20:42 ` [PATCH v2] " ilia.lin
1 sibling, 0 replies; 7+ messages in thread
From: Viresh Kumar @ 2018-06-08 4:29 UTC (permalink / raw)
To: ilia.lin
Cc: Ilia Lin, Rafael J . Wysocki, Arnd Bergmann, Dan Carpenter,
linux-pm, linux-kernel
On 07-06-18, 20:58, ilia.lin@gmail.com wrote:
> From: Ilia Lin <ilia.lin@gmail.com>
>
> Add device remove and module exit code to make the driver
> functioning as a loadable module.
>
> Fixes: ac28927659be (cpufreq: kryo: allow building as a loadable module)
> Signed-off-by: Ilia Lin <ilia.lin@gmail.com>
> ---
> drivers/cpufreq/qcom-cpufreq-kryo.c | 24 +++++++++++++++++++++---
> 1 file changed, 21 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/cpufreq/qcom-cpufreq-kryo.c b/drivers/cpufreq/qcom-cpufreq-kryo.c
> index d049fe4b80c4..a08de0253169 100644
> --- a/drivers/cpufreq/qcom-cpufreq-kryo.c
> +++ b/drivers/cpufreq/qcom-cpufreq-kryo.c
> @@ -71,10 +71,10 @@ static enum _msm8996_version __init qcom_cpufreq_kryo_get_msm_id(void)
> return version;
> }
>
> +struct platform_device *cpufreq_dt_pdev;
Move this and the other platform device pointer at the top of the file after the
enum declarations. They don't look nice in the middle of nowhere.
> static int qcom_cpufreq_kryo_probe(struct platform_device *pdev)
> {
> struct opp_table *opp_tables[NR_CPUS] = {0};
> - struct platform_device *cpufreq_dt_pdev;
> enum _msm8996_version msm8996_version;
> struct nvmem_cell *speedbin_nvmem;
> struct device_node *np;
> @@ -115,6 +115,8 @@ static int qcom_cpufreq_kryo_probe(struct platform_device *pdev)
>
> speedbin = nvmem_cell_read(speedbin_nvmem, &len);
> nvmem_cell_put(speedbin_nvmem);
> + if (IS_ERR(speedbin))
> + return PTR_ERR(speedbin);
This doesn't look related to this patch. Should it be a different commit ?
And I just saw definition of nvmem_cell_read() and it says the returned buffer
must be freed by caller using kfree(). I dont' see you doing that. Please also
check if any other such resources are there which you forgot to free.
>
> switch (msm8996_version) {
> case MSM8996_V3:
> @@ -162,8 +164,15 @@ static int qcom_cpufreq_kryo_probe(struct platform_device *pdev)
> return ret;
> }
>
> +static int qcom_cpufreq_kryo_remove(struct platform_device *pdev)
> +{
> + platform_device_unregister(cpufreq_dt_pdev);
> + return 0;
> +}
> +
> static struct platform_driver qcom_cpufreq_kryo_driver = {
> .probe = qcom_cpufreq_kryo_probe,
> + .remove = qcom_cpufreq_kryo_remove,
> .driver = {
> .name = "qcom-cpufreq-kryo",
> },
> @@ -174,6 +183,7 @@ static const struct of_device_id qcom_cpufreq_kryo_match_list[] __initconst = {
> { .compatible = "qcom,msm8996", },
> };
>
> +struct platform_device *kryo_cpufreq_pdev;
> /*
> * Since the driver depends on smem and nvmem drivers, which may
> * return EPROBE_DEFER, all the real activity is done in the probe,
> @@ -198,8 +208,9 @@ static int __init qcom_cpufreq_kryo_init(void)
> if (unlikely(ret < 0))
> return ret;
>
> - ret = PTR_ERR_OR_ZERO(platform_device_register_simple(
> - "qcom-cpufreq-kryo", -1, NULL, 0));
> + kryo_cpufreq_pdev = platform_device_register_simple(
> + "qcom-cpufreq-kryo", -1, NULL, 0);
> + ret = PTR_ERR_OR_ZERO(kryo_cpufreq_pdev);
> if (0 == ret)
> return 0;
>
> @@ -208,5 +219,12 @@ static int __init qcom_cpufreq_kryo_init(void)
> }
> module_init(qcom_cpufreq_kryo_init);
>
> +static void __init qcom_cpufreq_kryo_exit(void)
> +{
> + platform_device_unregister(kryo_cpufreq_pdev);
> + platform_driver_unregister(&qcom_cpufreq_kryo_driver);
> +}
> +module_exit(qcom_cpufreq_kryo_exit);
> +
> MODULE_DESCRIPTION("Qualcomm Technologies, Inc. Kryo CPUfreq driver");
> MODULE_LICENSE("GPL v2");
--
viresh
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH v2] cpufreq: kryo: Add module remove and exit
2018-06-07 20:58 [PATCH] cpufreq: kryo: Add module remove and exit ilia.lin
2018-06-08 4:29 ` Viresh Kumar
@ 2018-06-14 20:42 ` ilia.lin
2018-06-15 2:45 ` Viresh Kumar
2018-06-17 20:01 ` [PATCH v3] " ilia.lin
1 sibling, 2 replies; 7+ messages in thread
From: ilia.lin @ 2018-06-14 20:42 UTC (permalink / raw)
To: Ilia Lin, Ilia Lin, Rafael J . Wysocki, Viresh Kumar
Cc: Arnd Bergmann, linux-pm, linux-kernel
From: Ilia Lin <ilia.lin@gmail.com>
Add device remove and module exit code to make the driver
functioning as a loadable module.
Fixes: ac28927659be (cpufreq: kryo: allow building as a loadable module)
Signed-off-by: Ilia Lin <ilia.lin@gmail.com>
---
drivers/cpufreq/qcom-cpufreq-kryo.c | 23 ++++++++++++++++++++---
1 file changed, 20 insertions(+), 3 deletions(-)
diff --git a/drivers/cpufreq/qcom-cpufreq-kryo.c b/drivers/cpufreq/qcom-cpufreq-kryo.c
index 5e9511223ce9..01bddacf5c3b 100644
--- a/drivers/cpufreq/qcom-cpufreq-kryo.c
+++ b/drivers/cpufreq/qcom-cpufreq-kryo.c
@@ -42,6 +42,8 @@ enum _msm8996_version {
NUM_OF_MSM8996_VERSIONS,
};
+struct platform_device *cpufreq_dt_pdev, *kryo_cpufreq_pdev;
+
static enum _msm8996_version __init qcom_cpufreq_kryo_get_msm_id(void)
{
size_t len;
@@ -74,7 +76,6 @@ static enum _msm8996_version __init qcom_cpufreq_kryo_get_msm_id(void)
static int qcom_cpufreq_kryo_probe(struct platform_device *pdev)
{
struct opp_table *opp_tables[NR_CPUS] = {0};
- struct platform_device *cpufreq_dt_pdev;
enum _msm8996_version msm8996_version;
struct nvmem_cell *speedbin_nvmem;
struct device_node *np;
@@ -129,6 +130,7 @@ static int qcom_cpufreq_kryo_probe(struct platform_device *pdev)
BUG();
break;
}
+ kfree(speedbin);
for_each_possible_cpu(cpu) {
cpu_dev = get_cpu_device(cpu);
@@ -164,8 +166,15 @@ static int qcom_cpufreq_kryo_probe(struct platform_device *pdev)
return ret;
}
+static int qcom_cpufreq_kryo_remove(struct platform_device *pdev)
+{
+ platform_device_unregister(cpufreq_dt_pdev);
+ return 0;
+}
+
static struct platform_driver qcom_cpufreq_kryo_driver = {
.probe = qcom_cpufreq_kryo_probe,
+ .remove = qcom_cpufreq_kryo_remove,
.driver = {
.name = "qcom-cpufreq-kryo",
},
@@ -200,8 +209,9 @@ static int __init qcom_cpufreq_kryo_init(void)
if (unlikely(ret < 0))
return ret;
- ret = PTR_ERR_OR_ZERO(platform_device_register_simple(
- "qcom-cpufreq-kryo", -1, NULL, 0));
+ kryo_cpufreq_pdev = platform_device_register_simple(
+ "qcom-cpufreq-kryo", -1, NULL, 0);
+ ret = PTR_ERR_OR_ZERO(kryo_cpufreq_pdev);
if (0 == ret)
return 0;
@@ -210,5 +220,12 @@ static int __init qcom_cpufreq_kryo_init(void)
}
module_init(qcom_cpufreq_kryo_init);
+static void __init qcom_cpufreq_kryo_exit(void)
+{
+ platform_device_unregister(kryo_cpufreq_pdev);
+ platform_driver_unregister(&qcom_cpufreq_kryo_driver);
+}
+module_exit(qcom_cpufreq_kryo_exit);
+
MODULE_DESCRIPTION("Qualcomm Technologies, Inc. Kryo CPUfreq driver");
MODULE_LICENSE("GPL v2");
--
2.11.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v2] cpufreq: kryo: Add module remove and exit
2018-06-14 20:42 ` [PATCH v2] " ilia.lin
@ 2018-06-15 2:45 ` Viresh Kumar
2018-06-17 20:01 ` [PATCH v3] " ilia.lin
1 sibling, 0 replies; 7+ messages in thread
From: Viresh Kumar @ 2018-06-15 2:45 UTC (permalink / raw)
To: ilia.lin
Cc: Ilia Lin, Rafael J . Wysocki, Arnd Bergmann, linux-pm, linux-kernel
On 14-06-18, 22:42, ilia.lin@gmail.com wrote:
> From: Ilia Lin <ilia.lin@gmail.com>
>
> Add device remove and module exit code to make the driver
> functioning as a loadable module.
>
> Fixes: ac28927659be (cpufreq: kryo: allow building as a loadable module)
> Signed-off-by: Ilia Lin <ilia.lin@gmail.com>
> ---
> drivers/cpufreq/qcom-cpufreq-kryo.c | 23 ++++++++++++++++++++---
> 1 file changed, 20 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/cpufreq/qcom-cpufreq-kryo.c b/drivers/cpufreq/qcom-cpufreq-kryo.c
> index 5e9511223ce9..01bddacf5c3b 100644
> --- a/drivers/cpufreq/qcom-cpufreq-kryo.c
> +++ b/drivers/cpufreq/qcom-cpufreq-kryo.c
> @@ -42,6 +42,8 @@ enum _msm8996_version {
> NUM_OF_MSM8996_VERSIONS,
> };
>
> +struct platform_device *cpufreq_dt_pdev, *kryo_cpufreq_pdev;
> +
> static enum _msm8996_version __init qcom_cpufreq_kryo_get_msm_id(void)
> {
> size_t len;
> @@ -74,7 +76,6 @@ static enum _msm8996_version __init qcom_cpufreq_kryo_get_msm_id(void)
> static int qcom_cpufreq_kryo_probe(struct platform_device *pdev)
> {
> struct opp_table *opp_tables[NR_CPUS] = {0};
> - struct platform_device *cpufreq_dt_pdev;
> enum _msm8996_version msm8996_version;
> struct nvmem_cell *speedbin_nvmem;
> struct device_node *np;
> @@ -129,6 +130,7 @@ static int qcom_cpufreq_kryo_probe(struct platform_device *pdev)
> BUG();
> break;
> }
> + kfree(speedbin);
Again, stuff like this can't go in this patch itself. It is a separate
bug fix and you should send it with a matching fixes tag separately.
>
> for_each_possible_cpu(cpu) {
> cpu_dev = get_cpu_device(cpu);
> @@ -164,8 +166,15 @@ static int qcom_cpufreq_kryo_probe(struct platform_device *pdev)
> return ret;
> }
>
> +static int qcom_cpufreq_kryo_remove(struct platform_device *pdev)
> +{
> + platform_device_unregister(cpufreq_dt_pdev);
> + return 0;
> +}
> +
> static struct platform_driver qcom_cpufreq_kryo_driver = {
> .probe = qcom_cpufreq_kryo_probe,
> + .remove = qcom_cpufreq_kryo_remove,
> .driver = {
> .name = "qcom-cpufreq-kryo",
> },
> @@ -200,8 +209,9 @@ static int __init qcom_cpufreq_kryo_init(void)
> if (unlikely(ret < 0))
> return ret;
>
> - ret = PTR_ERR_OR_ZERO(platform_device_register_simple(
> - "qcom-cpufreq-kryo", -1, NULL, 0));
> + kryo_cpufreq_pdev = platform_device_register_simple(
> + "qcom-cpufreq-kryo", -1, NULL, 0);
> + ret = PTR_ERR_OR_ZERO(kryo_cpufreq_pdev);
> if (0 == ret)
> return 0;
>
> @@ -210,5 +220,12 @@ static int __init qcom_cpufreq_kryo_init(void)
> }
> module_init(qcom_cpufreq_kryo_init);
>
> +static void __init qcom_cpufreq_kryo_exit(void)
> +{
> + platform_device_unregister(kryo_cpufreq_pdev);
> + platform_driver_unregister(&qcom_cpufreq_kryo_driver);
> +}
> +module_exit(qcom_cpufreq_kryo_exit);
> +
> MODULE_DESCRIPTION("Qualcomm Technologies, Inc. Kryo CPUfreq driver");
> MODULE_LICENSE("GPL v2");
> --
> 2.11.0
--
viresh
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH v3] cpufreq: kryo: Add module remove and exit
2018-06-14 20:42 ` [PATCH v2] " ilia.lin
2018-06-15 2:45 ` Viresh Kumar
@ 2018-06-17 20:01 ` ilia.lin
2018-06-18 4:55 ` Viresh Kumar
1 sibling, 1 reply; 7+ messages in thread
From: ilia.lin @ 2018-06-17 20:01 UTC (permalink / raw)
To: ilia.lin; +Cc: Rafael J. Wysocki, Viresh Kumar, linux-pm, linux-kernel
From: Ilia Lin <ilia.lin@gmail.com>
Add device remove and module exit code to make the driver
functioning as a loadable module.
Fixes: ac28927659be (cpufreq: kryo: allow building as a loadable module)
Signed-off-by: Ilia Lin <ilia.lin@gmail.com>
---
drivers/cpufreq/qcom-cpufreq-kryo.c | 22 +++++++++++++++++++---
1 file changed, 19 insertions(+), 3 deletions(-)
diff --git a/drivers/cpufreq/qcom-cpufreq-kryo.c b/drivers/cpufreq/qcom-cpufreq-kryo.c
index 74b9b93d511b..01bddacf5c3b 100644
--- a/drivers/cpufreq/qcom-cpufreq-kryo.c
+++ b/drivers/cpufreq/qcom-cpufreq-kryo.c
@@ -42,6 +42,8 @@ enum _msm8996_version {
NUM_OF_MSM8996_VERSIONS,
};
+struct platform_device *cpufreq_dt_pdev, *kryo_cpufreq_pdev;
+
static enum _msm8996_version __init qcom_cpufreq_kryo_get_msm_id(void)
{
size_t len;
@@ -74,7 +76,6 @@ static enum _msm8996_version __init qcom_cpufreq_kryo_get_msm_id(void)
static int qcom_cpufreq_kryo_probe(struct platform_device *pdev)
{
struct opp_table *opp_tables[NR_CPUS] = {0};
- struct platform_device *cpufreq_dt_pdev;
enum _msm8996_version msm8996_version;
struct nvmem_cell *speedbin_nvmem;
struct device_node *np;
@@ -165,8 +166,15 @@ static int qcom_cpufreq_kryo_probe(struct platform_device *pdev)
return ret;
}
+static int qcom_cpufreq_kryo_remove(struct platform_device *pdev)
+{
+ platform_device_unregister(cpufreq_dt_pdev);
+ return 0;
+}
+
static struct platform_driver qcom_cpufreq_kryo_driver = {
.probe = qcom_cpufreq_kryo_probe,
+ .remove = qcom_cpufreq_kryo_remove,
.driver = {
.name = "qcom-cpufreq-kryo",
},
@@ -201,8 +209,9 @@ static int __init qcom_cpufreq_kryo_init(void)
if (unlikely(ret < 0))
return ret;
- ret = PTR_ERR_OR_ZERO(platform_device_register_simple(
- "qcom-cpufreq-kryo", -1, NULL, 0));
+ kryo_cpufreq_pdev = platform_device_register_simple(
+ "qcom-cpufreq-kryo", -1, NULL, 0);
+ ret = PTR_ERR_OR_ZERO(kryo_cpufreq_pdev);
if (0 == ret)
return 0;
@@ -211,5 +220,12 @@ static int __init qcom_cpufreq_kryo_init(void)
}
module_init(qcom_cpufreq_kryo_init);
+static void __init qcom_cpufreq_kryo_exit(void)
+{
+ platform_device_unregister(kryo_cpufreq_pdev);
+ platform_driver_unregister(&qcom_cpufreq_kryo_driver);
+}
+module_exit(qcom_cpufreq_kryo_exit);
+
MODULE_DESCRIPTION("Qualcomm Technologies, Inc. Kryo CPUfreq driver");
MODULE_LICENSE("GPL v2");
--
2.11.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v3] cpufreq: kryo: Add module remove and exit
2018-06-17 20:01 ` [PATCH v3] " ilia.lin
@ 2018-06-18 4:55 ` Viresh Kumar
2018-06-21 13:23 ` Rafael J. Wysocki
0 siblings, 1 reply; 7+ messages in thread
From: Viresh Kumar @ 2018-06-18 4:55 UTC (permalink / raw)
To: ilia.lin; +Cc: Rafael J. Wysocki, linux-pm, linux-kernel
On 17-06-18, 22:01, ilia.lin@gmail.com wrote:
> From: Ilia Lin <ilia.lin@gmail.com>
>
> Add device remove and module exit code to make the driver
> functioning as a loadable module.
>
> Fixes: ac28927659be (cpufreq: kryo: allow building as a loadable module)
> Signed-off-by: Ilia Lin <ilia.lin@gmail.com>
> ---
> drivers/cpufreq/qcom-cpufreq-kryo.c | 22 +++++++++++++++++++---
> 1 file changed, 19 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/cpufreq/qcom-cpufreq-kryo.c b/drivers/cpufreq/qcom-cpufreq-kryo.c
> index 74b9b93d511b..01bddacf5c3b 100644
> --- a/drivers/cpufreq/qcom-cpufreq-kryo.c
> +++ b/drivers/cpufreq/qcom-cpufreq-kryo.c
> @@ -42,6 +42,8 @@ enum _msm8996_version {
> NUM_OF_MSM8996_VERSIONS,
> };
>
> +struct platform_device *cpufreq_dt_pdev, *kryo_cpufreq_pdev;
> +
> static enum _msm8996_version __init qcom_cpufreq_kryo_get_msm_id(void)
> {
> size_t len;
> @@ -74,7 +76,6 @@ static enum _msm8996_version __init qcom_cpufreq_kryo_get_msm_id(void)
> static int qcom_cpufreq_kryo_probe(struct platform_device *pdev)
> {
> struct opp_table *opp_tables[NR_CPUS] = {0};
> - struct platform_device *cpufreq_dt_pdev;
> enum _msm8996_version msm8996_version;
> struct nvmem_cell *speedbin_nvmem;
> struct device_node *np;
> @@ -165,8 +166,15 @@ static int qcom_cpufreq_kryo_probe(struct platform_device *pdev)
> return ret;
> }
>
> +static int qcom_cpufreq_kryo_remove(struct platform_device *pdev)
> +{
> + platform_device_unregister(cpufreq_dt_pdev);
> + return 0;
> +}
> +
> static struct platform_driver qcom_cpufreq_kryo_driver = {
> .probe = qcom_cpufreq_kryo_probe,
> + .remove = qcom_cpufreq_kryo_remove,
> .driver = {
> .name = "qcom-cpufreq-kryo",
> },
> @@ -201,8 +209,9 @@ static int __init qcom_cpufreq_kryo_init(void)
> if (unlikely(ret < 0))
> return ret;
>
> - ret = PTR_ERR_OR_ZERO(platform_device_register_simple(
> - "qcom-cpufreq-kryo", -1, NULL, 0));
> + kryo_cpufreq_pdev = platform_device_register_simple(
> + "qcom-cpufreq-kryo", -1, NULL, 0);
> + ret = PTR_ERR_OR_ZERO(kryo_cpufreq_pdev);
> if (0 == ret)
> return 0;
>
> @@ -211,5 +220,12 @@ static int __init qcom_cpufreq_kryo_init(void)
> }
> module_init(qcom_cpufreq_kryo_init);
>
> +static void __init qcom_cpufreq_kryo_exit(void)
> +{
> + platform_device_unregister(kryo_cpufreq_pdev);
> + platform_driver_unregister(&qcom_cpufreq_kryo_driver);
> +}
> +module_exit(qcom_cpufreq_kryo_exit);
> +
> MODULE_DESCRIPTION("Qualcomm Technologies, Inc. Kryo CPUfreq driver");
> MODULE_LICENSE("GPL v2");
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v3] cpufreq: kryo: Add module remove and exit
2018-06-18 4:55 ` Viresh Kumar
@ 2018-06-21 13:23 ` Rafael J. Wysocki
0 siblings, 0 replies; 7+ messages in thread
From: Rafael J. Wysocki @ 2018-06-21 13:23 UTC (permalink / raw)
To: Viresh Kumar, ilia.lin; +Cc: linux-pm, linux-kernel
On Monday, June 18, 2018 6:55:50 AM CEST Viresh Kumar wrote:
> On 17-06-18, 22:01, ilia.lin@gmail.com wrote:
> > From: Ilia Lin <ilia.lin@gmail.com>
> >
> > Add device remove and module exit code to make the driver
> > functioning as a loadable module.
> >
> > Fixes: ac28927659be (cpufreq: kryo: allow building as a loadable module)
> > Signed-off-by: Ilia Lin <ilia.lin@gmail.com>
> > ---
> > drivers/cpufreq/qcom-cpufreq-kryo.c | 22 +++++++++++++++++++---
> > 1 file changed, 19 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/cpufreq/qcom-cpufreq-kryo.c b/drivers/cpufreq/qcom-cpufreq-kryo.c
> > index 74b9b93d511b..01bddacf5c3b 100644
> > --- a/drivers/cpufreq/qcom-cpufreq-kryo.c
> > +++ b/drivers/cpufreq/qcom-cpufreq-kryo.c
> > @@ -42,6 +42,8 @@ enum _msm8996_version {
> > NUM_OF_MSM8996_VERSIONS,
> > };
> >
> > +struct platform_device *cpufreq_dt_pdev, *kryo_cpufreq_pdev;
> > +
> > static enum _msm8996_version __init qcom_cpufreq_kryo_get_msm_id(void)
> > {
> > size_t len;
> > @@ -74,7 +76,6 @@ static enum _msm8996_version __init qcom_cpufreq_kryo_get_msm_id(void)
> > static int qcom_cpufreq_kryo_probe(struct platform_device *pdev)
> > {
> > struct opp_table *opp_tables[NR_CPUS] = {0};
> > - struct platform_device *cpufreq_dt_pdev;
> > enum _msm8996_version msm8996_version;
> > struct nvmem_cell *speedbin_nvmem;
> > struct device_node *np;
> > @@ -165,8 +166,15 @@ static int qcom_cpufreq_kryo_probe(struct platform_device *pdev)
> > return ret;
> > }
> >
> > +static int qcom_cpufreq_kryo_remove(struct platform_device *pdev)
> > +{
> > + platform_device_unregister(cpufreq_dt_pdev);
> > + return 0;
> > +}
> > +
> > static struct platform_driver qcom_cpufreq_kryo_driver = {
> > .probe = qcom_cpufreq_kryo_probe,
> > + .remove = qcom_cpufreq_kryo_remove,
> > .driver = {
> > .name = "qcom-cpufreq-kryo",
> > },
> > @@ -201,8 +209,9 @@ static int __init qcom_cpufreq_kryo_init(void)
> > if (unlikely(ret < 0))
> > return ret;
> >
> > - ret = PTR_ERR_OR_ZERO(platform_device_register_simple(
> > - "qcom-cpufreq-kryo", -1, NULL, 0));
> > + kryo_cpufreq_pdev = platform_device_register_simple(
> > + "qcom-cpufreq-kryo", -1, NULL, 0);
> > + ret = PTR_ERR_OR_ZERO(kryo_cpufreq_pdev);
> > if (0 == ret)
> > return 0;
> >
> > @@ -211,5 +220,12 @@ static int __init qcom_cpufreq_kryo_init(void)
> > }
> > module_init(qcom_cpufreq_kryo_init);
> >
> > +static void __init qcom_cpufreq_kryo_exit(void)
> > +{
> > + platform_device_unregister(kryo_cpufreq_pdev);
> > + platform_driver_unregister(&qcom_cpufreq_kryo_driver);
> > +}
> > +module_exit(qcom_cpufreq_kryo_exit);
> > +
> > MODULE_DESCRIPTION("Qualcomm Technologies, Inc. Kryo CPUfreq driver");
> > MODULE_LICENSE("GPL v2");
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Patch applied, thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-06-21 13:24 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-07 20:58 [PATCH] cpufreq: kryo: Add module remove and exit ilia.lin
2018-06-08 4:29 ` Viresh Kumar
2018-06-14 20:42 ` [PATCH v2] " ilia.lin
2018-06-15 2:45 ` Viresh Kumar
2018-06-17 20:01 ` [PATCH v3] " ilia.lin
2018-06-18 4:55 ` Viresh Kumar
2018-06-21 13:23 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).