* [PATCH 1/2] ath10k: do not mix spaces and tabs in Kconfig @ 2018-06-12 11:39 Niklas Cassel 2018-06-12 11:39 ` [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST Niklas Cassel 2018-06-14 15:18 ` [1/2] ath10k: do not mix spaces and tabs in Kconfig Kalle Valo 0 siblings, 2 replies; 16+ messages in thread From: Niklas Cassel @ 2018-06-12 11:39 UTC (permalink / raw) To: Kalle Valo, David S. Miller Cc: Niklas Cassel, ath10k, linux-wireless, netdev, linux-kernel Do not mix spaces and tabs in Kconfig. Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org> --- drivers/net/wireless/ath/ath10k/Kconfig | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/Kconfig b/drivers/net/wireless/ath/ath10k/Kconfig index 84f071ac0d84..54ff5930126c 100644 --- a/drivers/net/wireless/ath/ath10k/Kconfig +++ b/drivers/net/wireless/ath/ath10k/Kconfig @@ -1,15 +1,15 @@ config ATH10K - tristate "Atheros 802.11ac wireless cards support" - depends on MAC80211 && HAS_DMA + tristate "Atheros 802.11ac wireless cards support" + depends on MAC80211 && HAS_DMA select ATH_COMMON select CRC32 select WANT_DEV_COREDUMP select ATH10K_CE - ---help--- - This module adds support for wireless adapters based on - Atheros IEEE 802.11ac family of chipsets. + ---help--- + This module adds support for wireless adapters based on + Atheros IEEE 802.11ac family of chipsets. - If you choose to build a module, it'll be called ath10k. + If you choose to build a module, it'll be called ath10k. config ATH10K_CE bool @@ -41,12 +41,12 @@ config ATH10K_USB work in progress and will not fully work. config ATH10K_SNOC - tristate "Qualcomm ath10k SNOC support (EXPERIMENTAL)" - depends on ATH10K && ARCH_QCOM - ---help--- - This module adds support for integrated WCN3990 chip connected - to system NOC(SNOC). Currently work in progress and will not - fully work. + tristate "Qualcomm ath10k SNOC support (EXPERIMENTAL)" + depends on ATH10K && ARCH_QCOM + ---help--- + This module adds support for integrated WCN3990 chip connected + to system NOC(SNOC). Currently work in progress and will not + fully work. config ATH10K_DEBUG bool "Atheros ath10k debugging" -- 2.17.1 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST 2018-06-12 11:39 [PATCH 1/2] ath10k: do not mix spaces and tabs in Kconfig Niklas Cassel @ 2018-06-12 11:39 ` Niklas Cassel [not found] ` <7058492257914633b55fcd423e4c0b59@aphydexm01b.ap.qualcomm.com> ` (5 more replies) 2018-06-14 15:18 ` [1/2] ath10k: do not mix spaces and tabs in Kconfig Kalle Valo 1 sibling, 6 replies; 16+ messages in thread From: Niklas Cassel @ 2018-06-12 11:39 UTC (permalink / raw) To: Kalle Valo, David S. Miller Cc: Niklas Cassel, ath10k, linux-wireless, netdev, linux-kernel ATH10K_SNOC builds just fine with COMPILE_TEST, so make that possible. Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org> --- drivers/net/wireless/ath/ath10k/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/Kconfig b/drivers/net/wireless/ath/ath10k/Kconfig index 54ff5930126c..6572a43590a8 100644 --- a/drivers/net/wireless/ath/ath10k/Kconfig +++ b/drivers/net/wireless/ath/ath10k/Kconfig @@ -42,7 +42,8 @@ config ATH10K_USB config ATH10K_SNOC tristate "Qualcomm ath10k SNOC support (EXPERIMENTAL)" - depends on ATH10K && ARCH_QCOM + depends on ATH10K + depends on ARCH_QCOM || COMPILE_TEST ---help--- This module adds support for integrated WCN3990 chip connected to system NOC(SNOC). Currently work in progress and will not -- 2.17.1 ^ permalink raw reply related [flat|nested] 16+ messages in thread
[parent not found: <7058492257914633b55fcd423e4c0b59@aphydexm01b.ap.qualcomm.com>]
* Re: FW: [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST [not found] ` <7058492257914633b55fcd423e4c0b59@aphydexm01b.ap.qualcomm.com> @ 2018-06-12 12:32 ` Govind Singh 2018-06-12 12:44 ` Niklas Cassel 0 siblings, 1 reply; 16+ messages in thread From: Govind Singh @ 2018-06-12 12:32 UTC (permalink / raw) To: niklas.cassel, kvalo, davem; +Cc: netdev, linux-wireless, linux-kernel On 2018-06-12 17:45, Govind Singh wrote: > -----Original Message----- > From: ath10k <ath10k-bounces@lists.infradead.org> On Behalf Of Niklas > Cassel > Sent: Tuesday, June 12, 2018 5:09 PM > To: Kalle Valo <kvalo@codeaurora.org>; David S. Miller > <davem@davemloft.net> > Cc: Niklas Cassel <niklas.cassel@linaro.org>; netdev@vger.kernel.org; > linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org; > ath10k@lists.infradead.org > Subject: [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST > > ATH10K_SNOC builds just fine with COMPILE_TEST, so make that possible. > > Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org> > --- > drivers/net/wireless/ath/ath10k/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath10k/Kconfig > b/drivers/net/wireless/ath/ath10k/Kconfig > index 54ff5930126c..6572a43590a8 100644 > --- a/drivers/net/wireless/ath/ath10k/Kconfig > +++ b/drivers/net/wireless/ath/ath10k/Kconfig > @@ -42,7 +42,8 @@ config ATH10K_USB > > config ATH10K_SNOC > tristate "Qualcomm ath10k SNOC support (EXPERIMENTAL)" > - depends on ATH10K && ARCH_QCOM > + depends on ATH10K > + depends on ARCH_QCOM || COMPILE_TEST > ---help--- > This module adds support for integrated WCN3990 chip connected > to system NOC(SNOC). Currently work in progress and will not Thanks Niklas for enabling COMPILE_TEST. With QMI set of changes(https://patchwork.kernel.org/patch/10448183/), we need to enable COMPILE_TEST for QCOM_SCM/QMI_HELPERS which seems broken today. Are you planning to fix the same. config QCOM_SCM bool - depends on ARM || ARM64 + depends on ARM || ARM64 || COMPILE_TEST select RESET_CONTROLLER config QCOM_SCM_64 def_bool y - depends on QCOM_SCM && ARM64 + depends on QCOM_SCM && ARM64 || COMPILE_TEST config QCOM_QMI_HELPERS tristate - depends on ARCH_QCOM && NET + depends on (ARCH_QCOM || COMPILE_TEST) && NET -obj-$(CONFIG_ARCH_QCOM) += qcom/ +obj-y += qcom/ __qcom_scm_init/qcom_scm_call wrapper to support COMPILE_TEST. BR, Govind ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: FW: [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST 2018-06-12 12:32 ` FW: " Govind Singh @ 2018-06-12 12:44 ` Niklas Cassel 2018-06-13 8:47 ` Kalle Valo 2018-06-13 13:28 ` Niklas Cassel 0 siblings, 2 replies; 16+ messages in thread From: Niklas Cassel @ 2018-06-12 12:44 UTC (permalink / raw) To: Govind Singh, bjorn.andersson Cc: kvalo, davem, netdev, linux-wireless, linux-kernel On Tue, Jun 12, 2018 at 06:02:48PM +0530, Govind Singh wrote: > On 2018-06-12 17:45, Govind Singh wrote: > > -----Original Message----- > > From: ath10k <ath10k-bounces@lists.infradead.org> On Behalf Of Niklas > > Cassel > > Sent: Tuesday, June 12, 2018 5:09 PM > > To: Kalle Valo <kvalo@codeaurora.org>; David S. Miller > > <davem@davemloft.net> > > Cc: Niklas Cassel <niklas.cassel@linaro.org>; netdev@vger.kernel.org; > > linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org; > > ath10k@lists.infradead.org > > Subject: [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST > > > > ATH10K_SNOC builds just fine with COMPILE_TEST, so make that possible. > > > > Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org> > > --- > > drivers/net/wireless/ath/ath10k/Kconfig | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/wireless/ath/ath10k/Kconfig > > b/drivers/net/wireless/ath/ath10k/Kconfig > > index 54ff5930126c..6572a43590a8 100644 > > --- a/drivers/net/wireless/ath/ath10k/Kconfig > > +++ b/drivers/net/wireless/ath/ath10k/Kconfig > > @@ -42,7 +42,8 @@ config ATH10K_USB > > > > config ATH10K_SNOC > > tristate "Qualcomm ath10k SNOC support (EXPERIMENTAL)" > > - depends on ATH10K && ARCH_QCOM > > + depends on ATH10K > > + depends on ARCH_QCOM || COMPILE_TEST > > ---help--- > > This module adds support for integrated WCN3990 chip connected > > to system NOC(SNOC). Currently work in progress and will not > > Thanks Niklas for enabling COMPILE_TEST. With QMI set of > changes(https://patchwork.kernel.org/patch/10448183/), we need to enable > COMPILE_TEST for > QCOM_SCM/QMI_HELPERS which seems broken today. Are you planning to fix the > same. Argh.. qcom_scm seems fine, it is just missing a single definition in the #else clause of include/linux/qcom_scm.h. +++ b/include/linux/qcom_scm.h @@ -89,6 +89,10 @@ static inline int qcom_scm_pas_mem_setup(u32 peripheral, phys_addr_t addr, static inline int qcom_scm_pas_auth_and_reset(u32 peripheral) { return -ENODEV; } static inline int qcom_scm_pas_shutdown(u32 peripheral) { return -ENODEV; } +static inline int qcom_scm_assign_mem(phys_addr_t mem_addr, size_t mem_sz, + unsigned int *src, + struct qcom_scm_vmperm *newvm, + int dest_cnt) { return -ENODEV; } static inline void qcom_scm_cpu_power_down(u32 flags) {} static inline u32 qcom_scm_get_version(void) { return 0; } include/linux/soc/qcom/qmi.h on the other hand doesn't have any dummy defintions at all. I think that it makes sense to be able to compile test the QMI helpers also on other archs.. Bjorn, any opinion? > > config QCOM_SCM > bool > - depends on ARM || ARM64 > + depends on ARM || ARM64 || COMPILE_TEST > select RESET_CONTROLLER > > > config QCOM_SCM_64 > def_bool y > - depends on QCOM_SCM && ARM64 > + depends on QCOM_SCM && ARM64 || COMPILE_TEST > > config QCOM_QMI_HELPERS > tristate > - depends on ARCH_QCOM && NET > + depends on (ARCH_QCOM || COMPILE_TEST) && NET > > -obj-$(CONFIG_ARCH_QCOM) += qcom/ > +obj-y += qcom/ > > __qcom_scm_init/qcom_scm_call wrapper to support COMPILE_TEST. > > > > BR, > Govind ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: FW: [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST 2018-06-12 12:44 ` Niklas Cassel @ 2018-06-13 8:47 ` Kalle Valo 2018-06-13 13:28 ` Niklas Cassel 1 sibling, 0 replies; 16+ messages in thread From: Kalle Valo @ 2018-06-13 8:47 UTC (permalink / raw) To: Niklas Cassel Cc: Govind Singh, bjorn.andersson, davem, netdev, linux-wireless, linux-kernel, ath10k Niklas Cassel <niklas.cassel@linaro.org> writes: > On Tue, Jun 12, 2018 at 06:02:48PM +0530, Govind Singh wrote: >> On 2018-06-12 17:45, Govind Singh wrote: >> > -----Original Message----- >> > From: ath10k <ath10k-bounces@lists.infradead.org> On Behalf Of Niklas >> > Cassel >> > Sent: Tuesday, June 12, 2018 5:09 PM >> > To: Kalle Valo <kvalo@codeaurora.org>; David S. Miller >> > <davem@davemloft.net> >> > Cc: Niklas Cassel <niklas.cassel@linaro.org>; netdev@vger.kernel.org; >> > linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org; >> > ath10k@lists.infradead.org >> > Subject: [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST >> > >> > ATH10K_SNOC builds just fine with COMPILE_TEST, so make that possible. >> > >> > Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org> >> > --- >> > drivers/net/wireless/ath/ath10k/Kconfig | 3 ++- >> > 1 file changed, 2 insertions(+), 1 deletion(-) >> > >> > diff --git a/drivers/net/wireless/ath/ath10k/Kconfig >> > b/drivers/net/wireless/ath/ath10k/Kconfig >> > index 54ff5930126c..6572a43590a8 100644 >> > --- a/drivers/net/wireless/ath/ath10k/Kconfig >> > +++ b/drivers/net/wireless/ath/ath10k/Kconfig >> > @@ -42,7 +42,8 @@ config ATH10K_USB >> > >> > config ATH10K_SNOC >> > tristate "Qualcomm ath10k SNOC support (EXPERIMENTAL)" >> > - depends on ATH10K && ARCH_QCOM >> > + depends on ATH10K >> > + depends on ARCH_QCOM || COMPILE_TEST >> > ---help--- >> > This module adds support for integrated WCN3990 chip connected >> > to system NOC(SNOC). Currently work in progress and will not >> >> Thanks Niklas for enabling COMPILE_TEST. With QMI set of >> changes(https://patchwork.kernel.org/patch/10448183/), we need to enable >> COMPILE_TEST for >> QCOM_SCM/QMI_HELPERS which seems broken today. Are you planning to fix the >> same. > > > Argh.. > > qcom_scm seems fine, it is just missing a single definition in the > #else clause of include/linux/qcom_scm.h. > > +++ b/include/linux/qcom_scm.h > @@ -89,6 +89,10 @@ static inline int qcom_scm_pas_mem_setup(u32 peripheral, phys_addr_t addr, > static inline int > qcom_scm_pas_auth_and_reset(u32 peripheral) { return -ENODEV; } > static inline int qcom_scm_pas_shutdown(u32 peripheral) { return -ENODEV; } > +static inline int qcom_scm_assign_mem(phys_addr_t mem_addr, size_t mem_sz, > + unsigned int *src, > + struct qcom_scm_vmperm *newvm, > + int dest_cnt) { return -ENODEV; } > static inline void qcom_scm_cpu_power_down(u32 flags) {} > static inline u32 qcom_scm_get_version(void) { return 0; } > > > > include/linux/soc/qcom/qmi.h on the other hand doesn't have any > dummy defintions at all. > I think that it makes sense to be able to compile test > the QMI helpers also on other archs.. > > Bjorn, any opinion? Please don't drop ath10k list, adding it back. -- Kalle Valo ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: FW: [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST 2018-06-12 12:44 ` Niklas Cassel 2018-06-13 8:47 ` Kalle Valo @ 2018-06-13 13:28 ` Niklas Cassel 2018-06-14 14:09 ` Kalle Valo 1 sibling, 1 reply; 16+ messages in thread From: Niklas Cassel @ 2018-06-13 13:28 UTC (permalink / raw) To: Govind Singh, bjorn.andersson Cc: kvalo, davem, netdev, linux-wireless, linux-kernel, ath10k On Tue, Jun 12, 2018 at 02:44:03PM +0200, Niklas Cassel wrote: > On Tue, Jun 12, 2018 at 06:02:48PM +0530, Govind Singh wrote: > > On 2018-06-12 17:45, Govind Singh wrote: > > > -----Original Message----- > > > From: ath10k <ath10k-bounces@lists.infradead.org> On Behalf Of Niklas > > > Cassel > > > Sent: Tuesday, June 12, 2018 5:09 PM > > > To: Kalle Valo <kvalo@codeaurora.org>; David S. Miller > > > <davem@davemloft.net> > > > Cc: Niklas Cassel <niklas.cassel@linaro.org>; netdev@vger.kernel.org; > > > linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org; > > > ath10k@lists.infradead.org > > > Subject: [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST > > > > > > ATH10K_SNOC builds just fine with COMPILE_TEST, so make that possible. > > > > > > Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org> > > > --- > > > drivers/net/wireless/ath/ath10k/Kconfig | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/wireless/ath/ath10k/Kconfig > > > b/drivers/net/wireless/ath/ath10k/Kconfig > > > index 54ff5930126c..6572a43590a8 100644 > > > --- a/drivers/net/wireless/ath/ath10k/Kconfig > > > +++ b/drivers/net/wireless/ath/ath10k/Kconfig > > > @@ -42,7 +42,8 @@ config ATH10K_USB > > > > > > config ATH10K_SNOC > > > tristate "Qualcomm ath10k SNOC support (EXPERIMENTAL)" > > > - depends on ATH10K && ARCH_QCOM > > > + depends on ATH10K > > > + depends on ARCH_QCOM || COMPILE_TEST > > > ---help--- > > > This module adds support for integrated WCN3990 chip connected > > > to system NOC(SNOC). Currently work in progress and will not > > > > Thanks Niklas for enabling COMPILE_TEST. With QMI set of > > changes(https://patchwork.kernel.org/patch/10448183/), we need to enable > > COMPILE_TEST for > > QCOM_SCM/QMI_HELPERS which seems broken today. Are you planning to fix the > > same. > > This patch is good as is. However, Govind's QMI patch set together with this patch resulted in build errors. FTR, these are fixed by: https://marc.info/?l=linux-kernel&m=152880985402356 https://marc.info/?l=linux-kernel&m=152889452326350 Regards, Niklas ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: FW: [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST 2018-06-13 13:28 ` Niklas Cassel @ 2018-06-14 14:09 ` Kalle Valo 2018-06-14 18:42 ` Niklas Cassel 0 siblings, 1 reply; 16+ messages in thread From: Kalle Valo @ 2018-06-14 14:09 UTC (permalink / raw) To: Niklas Cassel Cc: Govind Singh, bjorn.andersson, davem, netdev, linux-wireless, linux-kernel, ath10k Niklas Cassel <niklas.cassel@linaro.org> writes: > On Tue, Jun 12, 2018 at 02:44:03PM +0200, Niklas Cassel wrote: >> On Tue, Jun 12, 2018 at 06:02:48PM +0530, Govind Singh wrote: >> > On 2018-06-12 17:45, Govind Singh wrote: >> > > >> > > ATH10K_SNOC builds just fine with COMPILE_TEST, so make that possible. >> > > >> > > Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org> >> > > --- >> > > drivers/net/wireless/ath/ath10k/Kconfig | 3 ++- >> > > 1 file changed, 2 insertions(+), 1 deletion(-) >> > > >> > > diff --git a/drivers/net/wireless/ath/ath10k/Kconfig >> > > b/drivers/net/wireless/ath/ath10k/Kconfig >> > > index 54ff5930126c..6572a43590a8 100644 >> > > --- a/drivers/net/wireless/ath/ath10k/Kconfig >> > > +++ b/drivers/net/wireless/ath/ath10k/Kconfig >> > > @@ -42,7 +42,8 @@ config ATH10K_USB >> > > >> > > config ATH10K_SNOC >> > > tristate "Qualcomm ath10k SNOC support (EXPERIMENTAL)" >> > > - depends on ATH10K && ARCH_QCOM >> > > + depends on ATH10K >> > > + depends on ARCH_QCOM || COMPILE_TEST >> > > ---help--- >> > > This module adds support for integrated WCN3990 chip connected >> > > to system NOC(SNOC). Currently work in progress and will not >> > >> > Thanks Niklas for enabling COMPILE_TEST. With QMI set of >> > changes(https://patchwork.kernel.org/patch/10448183/), we need to enable >> > COMPILE_TEST for >> > QCOM_SCM/QMI_HELPERS which seems broken today. Are you planning to fix the >> > same. > > This patch is good as is. > > However, Govind's QMI patch set together with this patch > resulted in build errors. > > FTR, these are fixed by: > https://marc.info/?l=linux-kernel&m=152880985402356 > https://marc.info/?l=linux-kernel&m=152889452326350 So the problem is that if I apply this patch I can't apply Govind's QMI patchset (due to the build problems) until Niklas' fixes to qcom and rpmsg subsystems propogate back to my tree and that might take weeks, or even months. But I really would like to apply the QMI patchset ASAP so that we can complete the wcn3990 support and not unnecessarily delay it. So what I propose is that I put this patch 2 as 'Awaiting Upstream' in patchwork and apply it once Niklas' patches get to my tree. Does that sound good? -- Kalle Valo ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: FW: [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST 2018-06-14 14:09 ` Kalle Valo @ 2018-06-14 18:42 ` Niklas Cassel 0 siblings, 0 replies; 16+ messages in thread From: Niklas Cassel @ 2018-06-14 18:42 UTC (permalink / raw) To: Kalle Valo Cc: Govind Singh, bjorn.andersson, davem, netdev, linux-wireless, linux-kernel, ath10k On Thu, Jun 14, 2018 at 05:09:04PM +0300, Kalle Valo wrote: > Niklas Cassel <niklas.cassel@linaro.org> writes: > > > On Tue, Jun 12, 2018 at 02:44:03PM +0200, Niklas Cassel wrote: > >> On Tue, Jun 12, 2018 at 06:02:48PM +0530, Govind Singh wrote: > >> > On 2018-06-12 17:45, Govind Singh wrote: > >> > > > >> > > ATH10K_SNOC builds just fine with COMPILE_TEST, so make that possible. > >> > > > >> > > Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org> > >> > > --- > >> > > drivers/net/wireless/ath/ath10k/Kconfig | 3 ++- > >> > > 1 file changed, 2 insertions(+), 1 deletion(-) > >> > > > >> > > diff --git a/drivers/net/wireless/ath/ath10k/Kconfig > >> > > b/drivers/net/wireless/ath/ath10k/Kconfig > >> > > index 54ff5930126c..6572a43590a8 100644 > >> > > --- a/drivers/net/wireless/ath/ath10k/Kconfig > >> > > +++ b/drivers/net/wireless/ath/ath10k/Kconfig > >> > > @@ -42,7 +42,8 @@ config ATH10K_USB > >> > > > >> > > config ATH10K_SNOC > >> > > tristate "Qualcomm ath10k SNOC support (EXPERIMENTAL)" > >> > > - depends on ATH10K && ARCH_QCOM > >> > > + depends on ATH10K > >> > > + depends on ARCH_QCOM || COMPILE_TEST > >> > > ---help--- > >> > > This module adds support for integrated WCN3990 chip connected > >> > > to system NOC(SNOC). Currently work in progress and will not > >> > > >> > Thanks Niklas for enabling COMPILE_TEST. With QMI set of > >> > changes(https://patchwork.kernel.org/patch/10448183/), we need to enable > >> > COMPILE_TEST for > >> > QCOM_SCM/QMI_HELPERS which seems broken today. Are you planning to fix the > >> > same. > > > > This patch is good as is. > > > > However, Govind's QMI patch set together with this patch > > resulted in build errors. > > > > FTR, these are fixed by: > > https://marc.info/?l=linux-kernel&m=152880985402356 > > https://marc.info/?l=linux-kernel&m=152889452326350 > > So the problem is that if I apply this patch I can't apply Govind's QMI > patchset (due to the build problems) until Niklas' fixes to qcom and > rpmsg subsystems propogate back to my tree and that might take weeks, or > even months. But I really would like to apply the QMI patchset ASAP so > that we can complete the wcn3990 support and not unnecessarily delay it. > > So what I propose is that I put this patch 2 as 'Awaiting Upstream' in > patchwork and apply it once Niklas' patches get to my tree. Does that > sound good? Absolutely. I didn't realize this until after sending the patch. Kind regards, Niklas ^ permalink raw reply [flat|nested] 16+ messages in thread
* [RFC PATCH] ath10k: ath10k_snoc_get_ce_id_from_irq() can be static 2018-06-12 11:39 ` [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST Niklas Cassel [not found] ` <7058492257914633b55fcd423e4c0b59@aphydexm01b.ap.qualcomm.com> @ 2018-06-12 14:50 ` kbuild test robot 2018-06-13 9:57 ` Kalle Valo 2018-06-12 14:50 ` [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST kbuild test robot ` (3 subsequent siblings) 5 siblings, 1 reply; 16+ messages in thread From: kbuild test robot @ 2018-06-12 14:50 UTC (permalink / raw) To: Niklas Cassel Cc: kbuild-all, Kalle Valo, David S. Miller, Niklas Cassel, ath10k, linux-wireless, netdev, linux-kernel Fixes: aecf55e7df3a ("ath10k: allow ATH10K_SNOC with COMPILE_TEST") Signed-off-by: kbuild test robot <fengguang.wu@intel.com> --- snoc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c index a3a7042..92ddb1c 100644 --- a/drivers/net/wireless/ath/ath10k/snoc.c +++ b/drivers/net/wireless/ath/ath10k/snoc.c @@ -820,7 +820,7 @@ static const struct ath10k_bus_ops ath10k_snoc_bus_ops = { .write32 = ath10k_snoc_write32, }; -int ath10k_snoc_get_ce_id_from_irq(struct ath10k *ar, int irq) +static int ath10k_snoc_get_ce_id_from_irq(struct ath10k *ar, int irq) { struct ath10k_snoc *ar_snoc = ath10k_snoc_priv(ar); int i; @@ -868,7 +868,7 @@ static int ath10k_snoc_napi_poll(struct napi_struct *ctx, int budget) return done; } -void ath10k_snoc_init_napi(struct ath10k *ar) +static void ath10k_snoc_init_napi(struct ath10k *ar) { netif_napi_add(&ar->napi_dev, &ar->napi, ath10k_snoc_napi_poll, ATH10K_NAPI_BUDGET); ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [RFC PATCH] ath10k: ath10k_snoc_get_ce_id_from_irq() can be static 2018-06-12 14:50 ` [RFC PATCH] ath10k: ath10k_snoc_get_ce_id_from_irq() can be static kbuild test robot @ 2018-06-13 9:57 ` Kalle Valo 0 siblings, 0 replies; 16+ messages in thread From: Kalle Valo @ 2018-06-13 9:57 UTC (permalink / raw) To: kbuild test robot Cc: Niklas Cassel, kbuild-all, David S. Miller, ath10k, linux-wireless, netdev, linux-kernel kbuild test robot <fengguang.wu@intel.com> writes: > Fixes: aecf55e7df3a ("ath10k: allow ATH10K_SNOC with COMPILE_TEST") > Signed-off-by: kbuild test robot <fengguang.wu@intel.com> There's already an identical patch pending: ath10k: make some functions static https://patchwork.kernel.org/patch/10440159/ -- Kalle Valo ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST 2018-06-12 11:39 ` [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST Niklas Cassel [not found] ` <7058492257914633b55fcd423e4c0b59@aphydexm01b.ap.qualcomm.com> 2018-06-12 14:50 ` [RFC PATCH] ath10k: ath10k_snoc_get_ce_id_from_irq() can be static kbuild test robot @ 2018-06-12 14:50 ` kbuild test robot 2018-06-13 9:56 ` Kalle Valo 2018-07-04 9:59 ` [2/2] " Kalle Valo ` (2 subsequent siblings) 5 siblings, 1 reply; 16+ messages in thread From: kbuild test robot @ 2018-06-12 14:50 UTC (permalink / raw) To: Niklas Cassel Cc: kbuild-all, Kalle Valo, David S. Miller, Niklas Cassel, ath10k, linux-wireless, netdev, linux-kernel Hi Niklas, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on ath6kl/ath-next] [also build test WARNING on next-20180612] [cannot apply to v4.17] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Niklas-Cassel/ath10k-do-not-mix-spaces-and-tabs-in-Kconfig/20180612-194241 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath-next reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> drivers/net/wireless/ath/ath10k/snoc.c:823:5: sparse: symbol 'ath10k_snoc_get_ce_id_from_irq' was not declared. Should it be static? >> drivers/net/wireless/ath/ath10k/snoc.c:871:6: sparse: symbol 'ath10k_snoc_init_napi' was not declared. Should it be static? Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST 2018-06-12 14:50 ` [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST kbuild test robot @ 2018-06-13 9:56 ` Kalle Valo 0 siblings, 0 replies; 16+ messages in thread From: Kalle Valo @ 2018-06-13 9:56 UTC (permalink / raw) To: kbuild test robot Cc: Niklas Cassel, kbuild-all, David S. Miller, ath10k, linux-wireless, netdev, linux-kernel kbuild test robot <lkp@intel.com> writes: > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on ath6kl/ath-next] > [also build test WARNING on next-20180612] > [cannot apply to v4.17] > [if your patch is applied to the wrong git tree, please drop us a note > to help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Niklas-Cassel/ath10k-do-not-mix-spaces-and-tabs-in-Kconfig/20180612-194241 > base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath-next > reproduce: > # apt-get install sparse > make ARCH=x86_64 allmodconfig > make C=1 CF=-D__CHECK_ENDIAN__ > > > sparse warnings: (new ones prefixed by >>) > >>> drivers/net/wireless/ath/ath10k/snoc.c:823:5: sparse: symbol >>> 'ath10k_snoc_get_ce_id_from_irq' was not declared. Should it be >>> static? >>> drivers/net/wireless/ath/ath10k/snoc.c:871:6: sparse: symbol >>> 'ath10k_snoc_init_napi' was not declared. Should it be static? > > Please review and possibly fold the followup patch. There's already a patch pending to fix these: ath10k: make some functions static https://patchwork.kernel.org/patch/10440159/ -- Kalle Valo ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST 2018-06-12 11:39 ` [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST Niklas Cassel ` (2 preceding siblings ...) 2018-06-12 14:50 ` [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST kbuild test robot @ 2018-07-04 9:59 ` Kalle Valo [not found] ` <20180704095913.772C9606AC@smtp.codeaurora.org> 2018-09-03 16:59 ` [PATCH 2/2] " Kalle Valo 5 siblings, 0 replies; 16+ messages in thread From: Kalle Valo @ 2018-07-04 9:59 UTC (permalink / raw) To: Niklas Cassel Cc: David S. Miller, Niklas Cassel, ath10k, linux-wireless, netdev, linux-kernel Niklas Cassel <niklas.cassel@linaro.org> wrote: > ATH10K_SNOC builds just fine with COMPILE_TEST, so make that possible. > > Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org> Note to myself, I see these dependencies in linux-next (but not in Linus' tree yet): 67cd0eec5b62 rpmsg: smd: Add missing include of sizes.h 376e1f304fc7 firmware: qcom: scm: add a dummy qcom_scm_assign_mem() These I don't see in linux-next yet: soc: qcom: smem: Add missing include of sizes.h soc: qcom: smp2p: Add select IRQ_DOMAIN soc: qcom: smsm: Add select IRQ_DOMAIN soc: qcom: Remove depends on ARCH_QCOM -- https://patchwork.kernel.org/patch/10460103/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ^ permalink raw reply [flat|nested] 16+ messages in thread
[parent not found: <20180704095913.772C9606AC@smtp.codeaurora.org>]
* Re: [2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST [not found] ` <20180704095913.772C9606AC@smtp.codeaurora.org> @ 2018-07-04 11:20 ` Niklas Cassel 0 siblings, 0 replies; 16+ messages in thread From: Niklas Cassel @ 2018-07-04 11:20 UTC (permalink / raw) To: Kalle Valo; +Cc: netdev, linux-wireless, linux-kernel, ath10k, David S. Miller On Wed, Jul 04, 2018 at 09:59:13AM +0000, Kalle Valo wrote: > Niklas Cassel <niklas.cassel@linaro.org> wrote: > > > ATH10K_SNOC builds just fine with COMPILE_TEST, so make that possible. > > > > Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org> > > Note to myself, I see these dependencies in linux-next (but not in Linus' tree yet): > > 67cd0eec5b62 rpmsg: smd: Add missing include of sizes.h > 376e1f304fc7 firmware: qcom: scm: add a dummy qcom_scm_assign_mem() > > These I don't see in linux-next yet: > > soc: qcom: smem: Add missing include of sizes.h > soc: qcom: smp2p: Add select IRQ_DOMAIN > soc: qcom: smsm: Add select IRQ_DOMAIN > soc: qcom: Remove depends on ARCH_QCOM Hello Kalle, You are correct. I submitted a v3 of this just yesterday: https://marc.info/?l=linux-kernel&m=153060245727472&w=2 So hopefully it will be in linux-next within 2 weeks. Regards, Niklas > > -- > https://patchwork.kernel.org/patch/10460103/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches > > > _______________________________________________ > ath10k mailing list > ath10k@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/ath10k ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST 2018-06-12 11:39 ` [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST Niklas Cassel ` (4 preceding siblings ...) [not found] ` <20180704095913.772C9606AC@smtp.codeaurora.org> @ 2018-09-03 16:59 ` Kalle Valo 5 siblings, 0 replies; 16+ messages in thread From: Kalle Valo @ 2018-09-03 16:59 UTC (permalink / raw) To: Niklas Cassel Cc: David S. Miller, Niklas Cassel, ath10k, linux-wireless, netdev, linux-kernel Niklas Cassel <niklas.cassel@linaro.org> wrote: > ATH10K_SNOC builds just fine with COMPILE_TEST, so make that possible. > > Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks. f1908735f141 ath10k: allow ATH10K_SNOC with COMPILE_TEST -- https://patchwork.kernel.org/patch/10460103/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [1/2] ath10k: do not mix spaces and tabs in Kconfig 2018-06-12 11:39 [PATCH 1/2] ath10k: do not mix spaces and tabs in Kconfig Niklas Cassel 2018-06-12 11:39 ` [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST Niklas Cassel @ 2018-06-14 15:18 ` Kalle Valo 1 sibling, 0 replies; 16+ messages in thread From: Kalle Valo @ 2018-06-14 15:18 UTC (permalink / raw) To: Niklas Cassel Cc: David S. Miller, Niklas Cassel, ath10k, linux-wireless, netdev, linux-kernel Niklas Cassel <niklas.cassel@linaro.org> wrote: > Do not mix spaces and tabs in Kconfig. > > Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks. 50c51f394e68 ath10k: do not mix spaces and tabs in Kconfig -- https://patchwork.kernel.org/patch/10460095/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2018-09-03 16:59 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-12 11:39 [PATCH 1/2] ath10k: do not mix spaces and tabs in Kconfig Niklas Cassel
2018-06-12 11:39 ` [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST Niklas Cassel
[not found] ` <7058492257914633b55fcd423e4c0b59@aphydexm01b.ap.qualcomm.com>
2018-06-12 12:32 ` FW: " Govind Singh
2018-06-12 12:44 ` Niklas Cassel
2018-06-13 8:47 ` Kalle Valo
2018-06-13 13:28 ` Niklas Cassel
2018-06-14 14:09 ` Kalle Valo
2018-06-14 18:42 ` Niklas Cassel
2018-06-12 14:50 ` [RFC PATCH] ath10k: ath10k_snoc_get_ce_id_from_irq() can be static kbuild test robot
2018-06-13 9:57 ` Kalle Valo
2018-06-12 14:50 ` [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST kbuild test robot
2018-06-13 9:56 ` Kalle Valo
2018-07-04 9:59 ` [2/2] " Kalle Valo
[not found] ` <20180704095913.772C9606AC@smtp.codeaurora.org>
2018-07-04 11:20 ` Niklas Cassel
2018-09-03 16:59 ` [PATCH 2/2] " Kalle Valo
2018-06-14 15:18 ` [1/2] ath10k: do not mix spaces and tabs in Kconfig Kalle Valo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).