linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] PCI: controller: dwc: Do not let PCIE_DW_PLAT_HOST default to yes
@ 2018-06-19 17:19 Geert Uytterhoeven
  2018-06-20  9:22 ` Gustavo Pimentel
  2018-06-29 13:40 ` Lorenzo Pieralisi
  0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2018-06-19 17:19 UTC (permalink / raw)
  To: Gustavo Pimentel, Lorenzo Pieralisi, Bjorn Helgaas
  Cc: linux-pci, linux-kernel, Geert Uytterhoeven

PCIE_DW_PLAT_HOST does not have any platform dependency, so it should
not default to yes.

Fixes: 1d906b22076e12cf ("PCI: dwc: Add support for EP mode")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - Rebased on top of the big PCI controller move.
---
 drivers/pci/controller/dwc/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
index 16f52c626b4bd510..91b0194240a57e8f 100644
--- a/drivers/pci/controller/dwc/Kconfig
+++ b/drivers/pci/controller/dwc/Kconfig
@@ -58,7 +58,6 @@ config PCIE_DW_PLAT_HOST
 	depends on PCI && PCI_MSI_IRQ_DOMAIN
 	select PCIE_DW_HOST
 	select PCIE_DW_PLAT
-	default y
 	help
 	  Enables support for the PCIe controller in the Designware IP to
 	  work in host mode. There are two instances of PCIe controller in
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] PCI: controller: dwc: Do not let PCIE_DW_PLAT_HOST default to yes
  2018-06-19 17:19 [PATCH v2] PCI: controller: dwc: Do not let PCIE_DW_PLAT_HOST default to yes Geert Uytterhoeven
@ 2018-06-20  9:22 ` Gustavo Pimentel
  2018-06-29 13:40 ` Lorenzo Pieralisi
  1 sibling, 0 replies; 3+ messages in thread
From: Gustavo Pimentel @ 2018-06-20  9:22 UTC (permalink / raw)
  To: Geert Uytterhoeven, Gustavo Pimentel, Lorenzo Pieralisi, Bjorn Helgaas
  Cc: linux-pci, linux-kernel

Hi Geert,

On 19/06/2018 18:19, Geert Uytterhoeven wrote:
> PCIE_DW_PLAT_HOST does not have any platform dependency, so it should
> not default to yes.

That's right, thanks.

Regards,
Gustavo

Acked-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
> 
> Fixes: 1d906b22076e12cf ("PCI: dwc: Add support for EP mode")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2:
>   - Rebased on top of the big PCI controller move.
> ---
>  drivers/pci/controller/dwc/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> index 16f52c626b4bd510..91b0194240a57e8f 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -58,7 +58,6 @@ config PCIE_DW_PLAT_HOST
>  	depends on PCI && PCI_MSI_IRQ_DOMAIN
>  	select PCIE_DW_HOST
>  	select PCIE_DW_PLAT
> -	default y
>  	help
>  	  Enables support for the PCIe controller in the Designware IP to
>  	  work in host mode. There are two instances of PCIe controller in
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] PCI: controller: dwc: Do not let PCIE_DW_PLAT_HOST default to yes
  2018-06-19 17:19 [PATCH v2] PCI: controller: dwc: Do not let PCIE_DW_PLAT_HOST default to yes Geert Uytterhoeven
  2018-06-20  9:22 ` Gustavo Pimentel
@ 2018-06-29 13:40 ` Lorenzo Pieralisi
  1 sibling, 0 replies; 3+ messages in thread
From: Lorenzo Pieralisi @ 2018-06-29 13:40 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Gustavo Pimentel, Bjorn Helgaas, linux-pci, linux-kernel

On Tue, Jun 19, 2018 at 07:19:17PM +0200, Geert Uytterhoeven wrote:
> PCIE_DW_PLAT_HOST does not have any platform dependency, so it should
> not default to yes.
> 
> Fixes: 1d906b22076e12cf ("PCI: dwc: Add support for EP mode")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2:
>   - Rebased on top of the big PCI controller move.
> ---
>  drivers/pci/controller/dwc/Kconfig | 1 -
>  1 file changed, 1 deletion(-)

Applied to pci/controller-fixes to be tentatively merged for
-rc4, thanks.

Lorenzo

> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> index 16f52c626b4bd510..91b0194240a57e8f 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -58,7 +58,6 @@ config PCIE_DW_PLAT_HOST
>  	depends on PCI && PCI_MSI_IRQ_DOMAIN
>  	select PCIE_DW_HOST
>  	select PCIE_DW_PLAT
> -	default y
>  	help
>  	  Enables support for the PCIe controller in the Designware IP to
>  	  work in host mode. There are two instances of PCIe controller in
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-06-29 13:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-19 17:19 [PATCH v2] PCI: controller: dwc: Do not let PCIE_DW_PLAT_HOST default to yes Geert Uytterhoeven
2018-06-20  9:22 ` Gustavo Pimentel
2018-06-29 13:40 ` Lorenzo Pieralisi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).