* [rcu:dev 211/211] kernel/rcu/rcutorture.c:212:5: sparse: symbol 'err_segs_recorded' was not declared. Should it be static?
@ 2018-07-17 1:44 kbuild test robot
2018-07-17 1:44 ` [RFC PATCH rcu] rcutorture: err_segs_recorded can be static kbuild test robot
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2018-07-17 1:44 UTC (permalink / raw)
To: Paul E. McKenney; +Cc: kbuild-all, linux-kernel
tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev
head: 07809ecaa895e92b00c28e8c0b7442bddb8a9324
commit: 07809ecaa895e92b00c28e8c0b7442bddb8a9324 [211/211] rcutorture: Dump reader protection sequence if failures or close calls
reproduce:
# apt-get install sparse
git checkout 07809ecaa895e92b00c28e8c0b7442bddb8a9324
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> kernel/rcu/rcutorture.c:212:5: sparse: symbol 'err_segs_recorded' was not declared. Should it be static?
>> kernel/rcu/rcutorture.c:213:20: sparse: symbol 'err_segs' was not declared. Should it be static?
>> kernel/rcu/rcutorture.c:214:5: sparse: symbol 'rt_read_nsegs' was not declared. Should it be static?
include/linux/overflow.h:242:13: sparse: undefined identifier '__builtin_mul_overflow'
include/linux/overflow.h:242:13: sparse: incorrect type in conditional
include/linux/overflow.h:242:13: got void
include/linux/overflow.h:244:13: sparse: undefined identifier '__builtin_mul_overflow'
include/linux/overflow.h:244:13: sparse: incorrect type in conditional
include/linux/overflow.h:244:13: got void
include/linux/slab.h:631:13: sparse: undefined identifier '__builtin_mul_overflow'
include/linux/slab.h:631:13: sparse: not a function <noident>
include/linux/slab.h:631:13: sparse: not a function <noident>
include/linux/slab.h:631:13: sparse: not a function <noident>
include/linux/slab.h:631:13: sparse: not a function <noident>
include/linux/overflow.h:242:13: sparse: call with no type!
include/linux/overflow.h:244:13: sparse: call with no type!
kernel/rcu/rcutorture.c:1183:9: sparse: context imbalance in 'rcutorture_one_extend' - different lock contexts for basic block
include/linux/slab.h:631:13: sparse: call with no type!
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 3+ messages in thread* [RFC PATCH rcu] rcutorture: err_segs_recorded can be static
2018-07-17 1:44 [rcu:dev 211/211] kernel/rcu/rcutorture.c:212:5: sparse: symbol 'err_segs_recorded' was not declared. Should it be static? kbuild test robot
@ 2018-07-17 1:44 ` kbuild test robot
2018-07-17 4:03 ` Paul E. McKenney
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2018-07-17 1:44 UTC (permalink / raw)
To: Paul E. McKenney; +Cc: kbuild-all, linux-kernel
Fixes: 07809ecaa895 ("rcutorture: Dump reader protection sequence if failures or close calls")
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---
rcutorture.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
index ef85bde..a7a947e 100644
--- a/kernel/rcu/rcutorture.c
+++ b/kernel/rcu/rcutorture.c
@@ -209,9 +209,9 @@ struct rt_read_seg {
unsigned long rt_delay_us;
bool rt_preempted;
};
-int err_segs_recorded;
-struct rt_read_seg err_segs[RCUTORTURE_RDR_MAX_SEGS];
-int rt_read_nsegs;
+static int err_segs_recorded;
+static struct rt_read_seg err_segs[RCUTORTURE_RDR_MAX_SEGS];
+static int rt_read_nsegs;
static const char *rcu_torture_writer_state_getname(void)
{
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [RFC PATCH rcu] rcutorture: err_segs_recorded can be static
2018-07-17 1:44 ` [RFC PATCH rcu] rcutorture: err_segs_recorded can be static kbuild test robot
@ 2018-07-17 4:03 ` Paul E. McKenney
0 siblings, 0 replies; 3+ messages in thread
From: Paul E. McKenney @ 2018-07-17 4:03 UTC (permalink / raw)
To: kbuild test robot; +Cc: kbuild-all, linux-kernel
On Tue, Jul 17, 2018 at 09:44:52AM +0800, kbuild test robot wrote:
>
> Fixes: 07809ecaa895 ("rcutorture: Dump reader protection sequence if failures or close calls")
> Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
Good catch! I have folded this in with attribution.
Thanx, Paul
> ---
> rcutorture.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
> index ef85bde..a7a947e 100644
> --- a/kernel/rcu/rcutorture.c
> +++ b/kernel/rcu/rcutorture.c
> @@ -209,9 +209,9 @@ struct rt_read_seg {
> unsigned long rt_delay_us;
> bool rt_preempted;
> };
> -int err_segs_recorded;
> -struct rt_read_seg err_segs[RCUTORTURE_RDR_MAX_SEGS];
> -int rt_read_nsegs;
> +static int err_segs_recorded;
> +static struct rt_read_seg err_segs[RCUTORTURE_RDR_MAX_SEGS];
> +static int rt_read_nsegs;
>
> static const char *rcu_torture_writer_state_getname(void)
> {
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-17 4:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-17 1:44 [rcu:dev 211/211] kernel/rcu/rcutorture.c:212:5: sparse: symbol 'err_segs_recorded' was not declared. Should it be static? kbuild test robot
2018-07-17 1:44 ` [RFC PATCH rcu] rcutorture: err_segs_recorded can be static kbuild test robot
2018-07-17 4:03 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).