* [PATCH] nfc: fdp: remove redundant pointer 'client'
@ 2018-07-20 18:16 Colin King
2018-07-23 8:12 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2018-07-20 18:16 UTC (permalink / raw)
To: Samuel Ortiz, Amit Pundir, Andy Shevchenko, linux-wireless
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Pointer 'client' is being assigned but is never used hence it is
redundant and can be removed.
Cleans up clang warning:
warning: variable 'client' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/nfc/fdp/i2c.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/nfc/fdp/i2c.c b/drivers/nfc/fdp/i2c.c
index 70a970c7375c..5d3ea63e405f 100644
--- a/drivers/nfc/fdp/i2c.c
+++ b/drivers/nfc/fdp/i2c.c
@@ -210,7 +210,6 @@ static int fdp_nci_i2c_read(struct fdp_i2c_phy *phy, struct sk_buff **skb)
static irqreturn_t fdp_nci_i2c_irq_thread_fn(int irq, void *phy_id)
{
struct fdp_i2c_phy *phy = phy_id;
- struct i2c_client *client;
struct sk_buff *skb;
int r;
@@ -219,8 +218,6 @@ static irqreturn_t fdp_nci_i2c_irq_thread_fn(int irq, void *phy_id)
return IRQ_NONE;
}
- client = phy->i2c_dev;
-
r = fdp_nci_i2c_read(phy, &skb);
if (r == -EREMOTEIO)
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nfc: fdp: remove redundant pointer 'client'
2018-07-20 18:16 [PATCH] nfc: fdp: remove redundant pointer 'client' Colin King
@ 2018-07-23 8:12 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2018-07-23 8:12 UTC (permalink / raw)
To: Colin King, Samuel Ortiz, Amit Pundir, linux-wireless
Cc: kernel-janitors, linux-kernel
On Fri, 2018-07-20 at 19:16 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer 'client' is being assigned but is never used hence it is
> redundant and can be removed.
>
> Cleans up clang warning:
> warning: variable 'client' set but not used [-Wunused-but-set-
> variable]
Oh, thanks! It seems I had missed this when did a refactoring.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/nfc/fdp/i2c.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/nfc/fdp/i2c.c b/drivers/nfc/fdp/i2c.c
> index 70a970c7375c..5d3ea63e405f 100644
> --- a/drivers/nfc/fdp/i2c.c
> +++ b/drivers/nfc/fdp/i2c.c
> @@ -210,7 +210,6 @@ static int fdp_nci_i2c_read(struct fdp_i2c_phy
> *phy, struct sk_buff **skb)
> static irqreturn_t fdp_nci_i2c_irq_thread_fn(int irq, void *phy_id)
> {
> struct fdp_i2c_phy *phy = phy_id;
> - struct i2c_client *client;
> struct sk_buff *skb;
> int r;
>
> @@ -219,8 +218,6 @@ static irqreturn_t fdp_nci_i2c_irq_thread_fn(int
> irq, void *phy_id)
> return IRQ_NONE;
> }
>
> - client = phy->i2c_dev;
> -
> r = fdp_nci_i2c_read(phy, &skb);
>
> if (r == -EREMOTEIO)
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-23 8:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-20 18:16 [PATCH] nfc: fdp: remove redundant pointer 'client' Colin King
2018-07-23 8:12 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).