* [PATCH] dt-bindings: input: pwm-vibrator: correct pwm-names in example
@ 2018-08-18 19:58 Brian Masney
2018-08-20 22:38 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Brian Masney @ 2018-08-18 19:58 UTC (permalink / raw)
To: dmitry.torokhov, linux-input, devicetree, linux-kernel,
sebastian.reichel, robh, mark.rutland, masneyb
In the example for the pwm-vibrator bindings, pwm8 is the direction pin,
and pwm9 is the enable pin. The pwm-names on the vibrator node has these
two values swapped. This patch corrects the values for pwm-names.
Signed-off-by: Brian Masney <masneyb@onstation.org>
---
arch/arm/boot/dts/omap4-droid4-xt894.dts is actual implementation for
the example and it is correct.
Documentation/devicetree/bindings/input/pwm-vibrator.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/input/pwm-vibrator.txt b/Documentation/devicetree/bindings/input/pwm-vibrator.txt
index 09145d18491d..2731cbb7e8d7 100644
--- a/Documentation/devicetree/bindings/input/pwm-vibrator.txt
+++ b/Documentation/devicetree/bindings/input/pwm-vibrator.txt
@@ -60,7 +60,7 @@ Example from Motorola Droid 4:
compatible = "pwm-vibrator";
pwms = <&pwm8 0 1000000000 0>,
<&pwm9 0 1000000000 0>;
- pwm-names = "enable", "direction";
+ pwm-names = "direction", "enable";
direction-duty-cycle-ns = <1000000000>;
};
};
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dt-bindings: input: pwm-vibrator: correct pwm-names in example
2018-08-18 19:58 [PATCH] dt-bindings: input: pwm-vibrator: correct pwm-names in example Brian Masney
@ 2018-08-20 22:38 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2018-08-20 22:38 UTC (permalink / raw)
To: Brian Masney
Cc: dmitry.torokhov, linux-input, devicetree, linux-kernel,
sebastian.reichel, mark.rutland
On Sat, Aug 18, 2018 at 03:58:55PM -0400, Brian Masney wrote:
> In the example for the pwm-vibrator bindings, pwm8 is the direction pin,
> and pwm9 is the enable pin. The pwm-names on the vibrator node has these
> two values swapped. This patch corrects the values for pwm-names.
>
> Signed-off-by: Brian Masney <masneyb@onstation.org>
> ---
> arch/arm/boot/dts/omap4-droid4-xt894.dts is actual implementation for
> the example and it is correct.
>
> Documentation/devicetree/bindings/input/pwm-vibrator.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/input/pwm-vibrator.txt b/Documentation/devicetree/bindings/input/pwm-vibrator.txt
> index 09145d18491d..2731cbb7e8d7 100644
> --- a/Documentation/devicetree/bindings/input/pwm-vibrator.txt
> +++ b/Documentation/devicetree/bindings/input/pwm-vibrator.txt
> @@ -60,7 +60,7 @@ Example from Motorola Droid 4:
> compatible = "pwm-vibrator";
> pwms = <&pwm8 0 1000000000 0>,
> <&pwm9 0 1000000000 0>;
> - pwm-names = "enable", "direction";
> + pwm-names = "direction", "enable";
As enable is required and direction is optional, enable should come
first. So fix the pwms property instead. (And perhaps make the binding
more explicit as to what the order should be.
> direction-duty-cycle-ns = <1000000000>;
> };
> };
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-20 22:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-18 19:58 [PATCH] dt-bindings: input: pwm-vibrator: correct pwm-names in example Brian Masney
2018-08-20 22:38 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).