* [PATCH v2 1/3] dt-bindings: iio: vadc: Fix documentation of 'reg'
2018-09-06 21:04 [PATCH v2 0/3] arm64: dts: qcom: pm8998: Add ADC node and die temperature channel Matthias Kaehlcke
@ 2018-09-06 21:04 ` Matthias Kaehlcke
2018-09-08 14:11 ` Jonathan Cameron
2018-09-06 21:04 ` [PATCH v2 2/3] arm64: dts: qcom: pm8998: Add adc node Matthias Kaehlcke
2018-09-06 21:04 ` [PATCH v2 3/3] arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC Matthias Kaehlcke
2 siblings, 1 reply; 9+ messages in thread
From: Matthias Kaehlcke @ 2018-09-06 21:04 UTC (permalink / raw)
To: Andy Gross, David Brown, Rob Herring, Mark Rutland,
Catalin Marinas, Will Deacon, Jonathan Cameron, Hartmut Knaack,
Lars-Peter Clausen, Peter Meerwald-Stadler
Cc: linux-arm-msm, linux-soc, devicetree, linux-arm-kernel,
linux-kernel, linux-iio, Douglas Anderson, Matthias Kaehlcke
The documentation of Qualcomm's SPMI PMIC voltage ADC claims that the
'reg' property consists of two values, the SPMI address and the length
of the controller's registers. However the SPMI bus to which it is added
specifies "#size-cells = <0>;". Remove the controller register length
from the documentation of the field and the example.
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
--
Changes in v2:
- none
---
Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt
index 0fb46137f936..d0c188e5c922 100644
--- a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt
+++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt
@@ -13,7 +13,7 @@ VADC node:
- reg:
Usage: required
Value type: <prop-encoded-array>
- Definition: VADC base address and length in the SPMI PMIC register map.
+ Definition: VADC base address in the SPMI PMIC register map.
- #address-cells:
Usage: required
@@ -104,7 +104,7 @@ Example:
/* VADC node */
pmic_vadc: vadc@3100 {
compatible = "qcom,spmi-vadc";
- reg = <0x3100 0x100>;
+ reg = <0x3100>;
interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
#address-cells = <1>;
#size-cells = <0>;
--
2.19.0.rc2.392.g5ba43deb5a-goog
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: iio: vadc: Fix documentation of 'reg'
2018-09-06 21:04 ` [PATCH v2 1/3] dt-bindings: iio: vadc: Fix documentation of 'reg' Matthias Kaehlcke
@ 2018-09-08 14:11 ` Jonathan Cameron
0 siblings, 0 replies; 9+ messages in thread
From: Jonathan Cameron @ 2018-09-08 14:11 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: Andy Gross, David Brown, Rob Herring, Mark Rutland,
Catalin Marinas, Will Deacon, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, linux-arm-msm, linux-soc, devicetree,
linux-arm-kernel, linux-kernel, linux-iio, Douglas Anderson
On Thu, 6 Sep 2018 14:04:52 -0700
Matthias Kaehlcke <mka@chromium.org> wrote:
> The documentation of Qualcomm's SPMI PMIC voltage ADC claims that the
> 'reg' property consists of two values, the SPMI address and the length
> of the controller's registers. However the SPMI bus to which it is added
> specifies "#size-cells = <0>;". Remove the controller register length
> from the documentation of the field and the example.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Applied to the togreg branch of iio.git.
Thanks,
Jonathan
> --
> Changes in v2:
> - none
> ---
> Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt
> index 0fb46137f936..d0c188e5c922 100644
> --- a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt
> @@ -13,7 +13,7 @@ VADC node:
> - reg:
> Usage: required
> Value type: <prop-encoded-array>
> - Definition: VADC base address and length in the SPMI PMIC register map.
> + Definition: VADC base address in the SPMI PMIC register map.
>
> - #address-cells:
> Usage: required
> @@ -104,7 +104,7 @@ Example:
> /* VADC node */
> pmic_vadc: vadc@3100 {
> compatible = "qcom,spmi-vadc";
> - reg = <0x3100 0x100>;
> + reg = <0x3100>;
> interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
> #address-cells = <1>;
> #size-cells = <0>;
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 2/3] arm64: dts: qcom: pm8998: Add adc node
2018-09-06 21:04 [PATCH v2 0/3] arm64: dts: qcom: pm8998: Add ADC node and die temperature channel Matthias Kaehlcke
2018-09-06 21:04 ` [PATCH v2 1/3] dt-bindings: iio: vadc: Fix documentation of 'reg' Matthias Kaehlcke
@ 2018-09-06 21:04 ` Matthias Kaehlcke
2018-09-06 21:09 ` Doug Anderson
2018-09-06 21:04 ` [PATCH v2 3/3] arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC Matthias Kaehlcke
2 siblings, 1 reply; 9+ messages in thread
From: Matthias Kaehlcke @ 2018-09-06 21:04 UTC (permalink / raw)
To: Andy Gross, David Brown, Rob Herring, Mark Rutland,
Catalin Marinas, Will Deacon, Jonathan Cameron, Hartmut Knaack,
Lars-Peter Clausen, Peter Meerwald-Stadler
Cc: linux-arm-msm, linux-soc, devicetree, linux-arm-kernel,
linux-kernel, linux-iio, Douglas Anderson, Matthias Kaehlcke
This adds the adc node to pm8998 based on the examples in the
bindings. It also fixes the order of the included headers.
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
--
Changes in v2:
- removed io-channel-ranges attribute
---
arch/arm64/boot/dts/qcom/pm8998.dtsi | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts/qcom/pm8998.dtsi
index 92bed1e7d4bb..41593ebbea2c 100644
--- a/arch/arm64/boot/dts/qcom/pm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi
@@ -1,8 +1,9 @@
// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
/* Copyright 2018 Google LLC. */
-#include <dt-bindings/spmi/spmi.h>
+#include <dt-bindings/iio/qcom,spmi-vadc.h>
#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/spmi/spmi.h>
&spmi_bus {
pm8998_lsid0: pmic@0 {
@@ -11,6 +12,15 @@
#address-cells = <1>;
#size-cells = <0>;
+ pm8998_adc: adc@3100 {
+ compatible = "qcom,spmi-adc-rev2";
+ reg = <0x3100>;
+ interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ #io-channel-cells = <1>;
+ };
+
pm8998_gpio: gpios@c000 {
compatible = "qcom,pm8998-gpio", "qcom,spmi-gpio";
reg = <0xc000>;
--
2.19.0.rc2.392.g5ba43deb5a-goog
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/3] arm64: dts: qcom: pm8998: Add adc node
2018-09-06 21:04 ` [PATCH v2 2/3] arm64: dts: qcom: pm8998: Add adc node Matthias Kaehlcke
@ 2018-09-06 21:09 ` Doug Anderson
0 siblings, 0 replies; 9+ messages in thread
From: Doug Anderson @ 2018-09-06 21:09 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: Andy Gross, David Brown, Rob Herring, Mark Rutland,
Catalin Marinas, Will Deacon, Jonathan Cameron, Hartmut Knaack,
Lars-Peter Clausen, Peter Meerwald-Stadler, linux-arm-msm,
open list:ARM/QUALCOMM SUPPORT, devicetree, Linux ARM, LKML,
linux-iio
Hi,
On Thu, Sep 6, 2018 at 2:04 PM, Matthias Kaehlcke <mka@chromium.org> wrote:
> This adds the adc node to pm8998 based on the examples in the
> bindings. It also fixes the order of the included headers.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> --
> Changes in v2:
> - removed io-channel-ranges attribute
> ---
> arch/arm64/boot/dts/qcom/pm8998.dtsi | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
Reviewed-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 3/3] arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC
2018-09-06 21:04 [PATCH v2 0/3] arm64: dts: qcom: pm8998: Add ADC node and die temperature channel Matthias Kaehlcke
2018-09-06 21:04 ` [PATCH v2 1/3] dt-bindings: iio: vadc: Fix documentation of 'reg' Matthias Kaehlcke
2018-09-06 21:04 ` [PATCH v2 2/3] arm64: dts: qcom: pm8998: Add adc node Matthias Kaehlcke
@ 2018-09-06 21:04 ` Matthias Kaehlcke
2018-09-06 21:10 ` Doug Anderson
2 siblings, 1 reply; 9+ messages in thread
From: Matthias Kaehlcke @ 2018-09-06 21:04 UTC (permalink / raw)
To: Andy Gross, David Brown, Rob Herring, Mark Rutland,
Catalin Marinas, Will Deacon, Jonathan Cameron, Hartmut Knaack,
Lars-Peter Clausen, Peter Meerwald-Stadler
Cc: linux-arm-msm, linux-soc, devicetree, linux-arm-kernel,
linux-kernel, linux-iio, Douglas Anderson, Matthias Kaehlcke
Add a channel node for the die temperature to the ADC.
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
--
Changes in v2:
- none
---
arch/arm64/boot/dts/qcom/pm8998.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts/qcom/pm8998.dtsi
index 41593ebbea2c..d18d4f260fbe 100644
--- a/arch/arm64/boot/dts/qcom/pm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi
@@ -19,6 +19,11 @@
#address-cells = <1>;
#size-cells = <0>;
#io-channel-cells = <1>;
+
+ die-temp {
+ reg = <ADC5_DIE_TEMP>;
+ label = "die_temp";
+ };
};
pm8998_gpio: gpios@c000 {
--
2.19.0.rc2.392.g5ba43deb5a-goog
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 3/3] arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC
2018-09-06 21:04 ` [PATCH v2 3/3] arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC Matthias Kaehlcke
@ 2018-09-06 21:10 ` Doug Anderson
2018-09-06 21:22 ` Matthias Kaehlcke
0 siblings, 1 reply; 9+ messages in thread
From: Doug Anderson @ 2018-09-06 21:10 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: Andy Gross, David Brown, Rob Herring, Mark Rutland,
Catalin Marinas, Will Deacon, Jonathan Cameron, Hartmut Knaack,
Lars-Peter Clausen, Peter Meerwald-Stadler, linux-arm-msm,
open list:ARM/QUALCOMM SUPPORT, devicetree, Linux ARM, LKML,
linux-iio
Hi,
On Thu, Sep 6, 2018 at 2:04 PM, Matthias Kaehlcke <mka@chromium.org> wrote:
> Add a channel node for the die temperature to the ADC.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Double-SoB?
...presumably Andy can remove that when he lands and doesn't need a re-post...
-Doug
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 3/3] arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC
2018-09-06 21:10 ` Doug Anderson
@ 2018-09-06 21:22 ` Matthias Kaehlcke
2018-09-08 14:15 ` Jonathan Cameron
0 siblings, 1 reply; 9+ messages in thread
From: Matthias Kaehlcke @ 2018-09-06 21:22 UTC (permalink / raw)
To: Doug Anderson
Cc: Andy Gross, David Brown, Rob Herring, Mark Rutland,
Catalin Marinas, Will Deacon, Jonathan Cameron, Hartmut Knaack,
Lars-Peter Clausen, Peter Meerwald-Stadler, linux-arm-msm,
open list:ARM/QUALCOMM SUPPORT, devicetree, Linux ARM, LKML,
linux-iio
On Thu, Sep 06, 2018 at 02:10:43PM -0700, Doug Anderson wrote:
> Hi,
>
> On Thu, Sep 6, 2018 at 2:04 PM, Matthias Kaehlcke <mka@chromium.org> wrote:
> > Add a channel node for the die temperature to the ADC.
> >
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> > Reviewed-by: Douglas Anderson <dianders@chromium.org>
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
>
> Double-SoB?
I must have run 'amend' with '-s' out of habit, which wasn't the right
thing to do in this case :/
> ...presumably Andy can remove that when he lands and doesn't need a re-post...
Andy, in case you need me to repost let me know.
Thanks
Matthias
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 3/3] arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC
2018-09-06 21:22 ` Matthias Kaehlcke
@ 2018-09-08 14:15 ` Jonathan Cameron
0 siblings, 0 replies; 9+ messages in thread
From: Jonathan Cameron @ 2018-09-08 14:15 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: Doug Anderson, Andy Gross, David Brown, Rob Herring,
Mark Rutland, Catalin Marinas, Will Deacon, Hartmut Knaack,
Lars-Peter Clausen, Peter Meerwald-Stadler, linux-arm-msm,
open list:ARM/QUALCOMM SUPPORT, devicetree, Linux ARM, LKML,
linux-iio
On Thu, 6 Sep 2018 14:22:06 -0700
Matthias Kaehlcke <mka@chromium.org> wrote:
> On Thu, Sep 06, 2018 at 02:10:43PM -0700, Doug Anderson wrote:
> > Hi,
> >
> > On Thu, Sep 6, 2018 at 2:04 PM, Matthias Kaehlcke <mka@chromium.org> wrote:
> > > Add a channel node for the die temperature to the ADC.
> > >
> > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> > > Reviewed-by: Douglas Anderson <dianders@chromium.org>
> > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> >
> > Double-SoB?
>
> I must have run 'amend' with '-s' out of habit, which wasn't the right
> thing to do in this case :/
>
> > ...presumably Andy can remove that when he lands and doesn't need a re-post...
>
> Andy, in case you need me to repost let me know.
Slightly worse than that (as was patch 1). You accidentally used
-- rather than --- to separate the change log. So I ended up with
Signed-off-by: M..
Reviewed-by: ..
Signed-off-by: M..
--
Changelog
Signed-off-by: J....
Good think the double signed off was raised as chances are I wouldn't
have notice it.
Jonathan
>
> Thanks
>
> Matthias
^ permalink raw reply [flat|nested] 9+ messages in thread